date:20211219

Re: [Django] #33367: URLField throws ValueError instead of ValidationError on clean

2021-12-19 Thread Django

#33367: URLField throws ValueError instead of ValidationError on clean
-+-
 Reporter:  Florian Apolloner|Owner:  Pedro
 |  Schlickmann Mendes
 Type:  Bug  |   Status:  closed
Component:  Core (Other) |  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"e8b4feddc34ffe5759ec21da8fa027e86e653f1c" e8b4fedd]:
 {{{
 #!CommitTicketReference repository=""
 revision="e8b4feddc34ffe5759ec21da8fa027e86e653f1c"
 Fixed #33367 -- Fixed URLValidator crash in some edge cases.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.5de5c3aef06999ba5327fc1e2fb94948%40djangoproject.com.

Re: [Django] #33367: URLField throws ValueError instead of ValidationError on clean

2021-12-19 Thread Django

#33367: URLField throws ValueError instead of ValidationError on clean
-+-
 Reporter:  Florian Apolloner|Owner:  Pedro
 |  Schlickmann Mendes
 Type:  Bug  |   Status:  assigned
Component:  Core (Other) |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.880dc0fbe3ec5ac8ba1722262d22303d%40djangoproject.com.

Re: [Django] #33368: Durationfield.clean fails to handle broken data

2021-12-19 Thread Django

#33368: Durationfield.clean fails to handle broken data
-+-
 Reporter:  Florian Apolloner|Owner:  Pedro
 |  Schlickmann Mendes
 Type:  Bug  |   Status:  closed
Component:  Core (Other) |  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"4fd3044ca0135da903a70dfb66992293f529ecf1" 4fd3044c]:
 {{{
 #!CommitTicketReference repository=""
 revision="4fd3044ca0135da903a70dfb66992293f529ecf1"
 Fixed #33368 -- Fixed parse_duration() crash on invalid separators for
 decimal fractions.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.42dca9c56bab9f8162e970529bb79e84%40djangoproject.com.

Re: [Django] #33368: Durationfield.clean fails to handle broken data

2021-12-19 Thread Django

#33368: Durationfield.clean fails to handle broken data
-+-
 Reporter:  Florian Apolloner|Owner:  Pedro
 |  Schlickmann Mendes
 Type:  Bug  |   Status:  assigned
Component:  Core (Other) |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.e38ab1b786e129588dbb3d75095a5d1f%40djangoproject.com.

Re: [Django] #32600: GEOS Polygons and Collections (across versions) cause segmentation faults on macOS arm64 (M1)

2021-12-19 Thread Django

#32600: GEOS Polygons and Collections (across versions) cause segmentation 
faults
on macOS arm64 (M1)
-+-
 Reporter:  Aapo Rista   |Owner:  Brenton
 |  Partridge
 Type:  Bug  |   Status:  assigned
Component:  GIS  |  Version:  4.0
 Severity:  Release blocker  |   Resolution:
 Keywords:  Polygon, | Triage Stage:  Accepted
  MultiPoint, MultiLineString,   |
  MultiPolygon, Segmentation fault,  |
  GIS, GeoDjango, GEOS, macOS, M1,   |
  arm64  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  nobody => Brenton Partridge
 * status:  new => assigned
 * version:  dev => 4.0
 * severity:  Normal => Release blocker
 * stage:  Unreviewed => Accepted


Comment:

 Thanks for the investigation! It ends with `Segmentation fault` so IMO it
 qualifies for a backport to Django 4.0 as a crashing bug.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.5f024e4590ca1f095951cada7a4cb15a%40djangoproject.com.

Re: [Django] #2259: Primary keys should be readonly by default in admin

2021-12-19 Thread Django

#2259: Primary keys should be readonly by default in admin
-+-
 Reporter:  ed@… |Owner:
 |  siddhartha-star-dev
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by siddhartha-star-dev):

 Replying to [comment:39 Mariusz Felisiak]:
 Please look at my [comment:40 comment] and reply if possible

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.c06e024b1085c5332b5d4fb172024656%40djangoproject.com.

Re: [Django] #28889: Use JavaScript to prevent double submission of admin forms

2021-12-19 Thread Django

#28889: Use JavaScript to prevent double submission of admin forms
-+-
 Reporter:  Manuel Saelices  |Owner:  Marcelo
 Type:   |  Galigniana
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Marcelo Galigniana):

 * has_patch:  0 => 1
 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.bb2cb84f67859c3b6c0c4de81b0ed478%40djangoproject.com.

Re: [Django] #32600: GEOS Polygons and Collections (across versions) cause segmentation faults on macOS arm64 (M1) (was: Multi geometries cause Segmentation fault 11 on Macbook with M1 CPU)

2021-12-19 Thread Django

* status: closed => new
* cc: Brenton Partridge (added)
* version: 3.2 => dev
* keywords:
MultiPoint, MultiLinestring, MultiPolygon, Segmentation fault, GIS,
GeoDjango
=>
Polygon, MultiPoint, MultiLineString, MultiPolygon, Segmentation
fault, GIS, GeoDjango, GEOS, macOS, M1, arm64
* has_patch: 0 => 1
* resolution: invalid =>

Comment:

I can confirm that this is indeed a Django bug, and I was able to
replicate segfaults on Django's main branch, so it appears the GEOS 3.9
update in https://code.djangoproject.com/ticket/32544 did not fix this.
It's also been replicated in e.g.
https://github.com/libgeos/geos/issues/528.

It appears that in the current GEOS integration, argument signatures were
omitted in favor of automatically casting arguments for a few polygon-
related API calls. While this appears to have worked fine on x86 and x64,
on macOS arm64 (for native M1 processors), it causes seemingly random data
to be provided in place of arguments after the first, reliably causing
segmentation faults whenever a Polygon, MultiPolygon, or MultiLineString
is constructed. Underlying CFFI internals may be less lenient to
unspecified arguments in Apple's implementation than on other platforms.
Moving to explicit signatures works fine, and I see no reason having
explicit signatures should cause problems on other platforms (though we
should ensure CI passes).

I've submitted a PR at https://github.com/django/django/pull/15214.

All GIS tests now pass, and the changes are fully covered by test_geos.
The deeper issue in testing is that CI does not run on Apple hardware, so
it will be difficult to prevent regressions. However, the code changes are
small and well-documented, and I'd suggest that Apple/arm64 CI will be
important but not urgent.

For organizations using older versions of Django, I've also made a monkey-
patch available at
https://gist.github.com/bpartridge/26a11b28415d706bfb9993fc28767d68 which
can be added in any initialization code (or even called from settings.py)
before Polygon objects are created. When applied in test settings against
the main branch, all GIS tests pass as well; functionality is identical to
the PR above.

PR should be ready for review; happy to make changes as requested! Happy
holidays - and hopefully this brings some holiday cheer to developers who
might be seeing segfaults on their newly gifted machines!

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.a245674cb678adf28756e22604fe942e%40djangoproject.com.

Re: [Django] #33328: Use native JS events to trigger 'formset:added'/'formset:removed'

2021-12-19 Thread Django

#33328: Use native JS events to trigger 'formset:added'/'formset:removed'
--+
 Reporter:  Claude Paroz  |Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.admin |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by SwastikTripathi):

 * owner:  SwastikTripathi => (none)
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.4b1278e803e5ae53f113602a41097c69%40djangoproject.com.

Re: [Django] #33328: Use native JS events to trigger 'formset:added'/'formset:removed'

2021-12-19 Thread Django

#33328: Use native JS events to trigger 'formset:added'/'formset:removed'
-+-
 Reporter:  Claude Paroz |Owner:
 Type:   |  SwastikTripathi
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by SwastikTripathi):

 I'm really sorry for not communicating. Actually I've caught a cold, and
 require rest. So I don't think I'll be able to work on this now.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.d373b12f2110f6fbd52c98d3892e2742%40djangoproject.com.

Re: [Django] #33374: ExpressionWrapper for ~Q(pk__in=[]) crashes.

2021-12-19 Thread Django

#33374: ExpressionWrapper for ~Q(pk__in=[]) crashes.
-+-
 Reporter:  Stefan Brand |Owner:  David
 |  Wobrock
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  3.1
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by David Wobrock):

 * cc: David Wobrock (added)
 * owner:  nobody => David Wobrock
 * has_patch:  0 => 1
 * status:  new => assigned


Comment:

 Hi all,

 Opened a PR to tackle this bug https://github.com/django/django/pull/15213

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.759cd97f03399956e8553f22aa8942d9%40djangoproject.com.

Re: [Django] #29822: Timezone-aware widget for admin site

2021-12-19 Thread Django

#29822: Timezone-aware widget for admin site
---+
 Reporter:  Paul Tiplady   |Owner:  Shubh Parmar
 Type:  New feature|   Status:  assigned
Component:  contrib.admin  |  Version:  2.1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Shubh Parmar):

 Do I have to do anything else in this PR?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.debbc8b33784a3c52033d3bebd07e7a1%40djangoproject.com.

Re: [Django] #33367: URLField throws ValueError instead of ValidationError on clean

Re: [Django] #33367: URLField throws ValueError instead of ValidationError on clean

Re: [Django] #33368: Durationfield.clean fails to handle broken data

Re: [Django] #33368: Durationfield.clean fails to handle broken data

Re: [Django] #32600: GEOS Polygons and Collections (across versions) cause segmentation faults on macOS arm64 (M1)

Re: [Django] #2259: Primary keys should be readonly by default in admin

Re: [Django] #28889: Use JavaScript to prevent double submission of admin forms

Re: [Django] #32600: GEOS Polygons and Collections (across versions) cause segmentation faults on macOS arm64 (M1) (was: Multi geometries cause Segmentation fault 11 on Macbook with M1 CPU)

Re: [Django] #33328: Use native JS events to trigger 'formset:added'/'formset:removed'

Re: [Django] #33328: Use native JS events to trigger 'formset:added'/'formset:removed'

Re: [Django] #33374: ExpressionWrapper for ~Q(pk__in=[]) crashes.

Re: [Django] #29822: Timezone-aware widget for admin site

12 matches

Site Navigation

Mail list logo

Footer information