Re: [Django] #33841: Django shouldn't fail (bulk-)update silently when QuerySet is already evaluated.

2022-07-13 Thread Django
#33841: Django shouldn't fail (bulk-)update silently when QuerySet is already
evaluated.
-+-
 Reporter:  Shibel Karmi |Owner:  nobody
  Mansour|
 Type:  Uncategorized|   Status:  closed
Component:  Database layer   |  Version:  3.2
  (models, ORM)  |   Resolution:
 Severity:  Normal   |  worksforme
 Keywords:  update, bulk-| Triage Stage:
  update, queryset   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Shibel Karmi Mansour):

 I appreciate you taking the time to look into this, I don't think it
 should've been closed.

 Maybe in initial_queryset you filter out conditions that don't match
 any rows after adding MyOtherModel instances, it's hard to tell.

 That is not the case, and why would adding some `OtherModel` instances
 through iteration affect the results on `MyObject` models?

 The code I put up above does not omit any ORM-level action, I've stopped
 the debugger one line before the `update()` call and the queryset size is
 > 0, only after I call the `update()` the queryset size becomes 0 (I'm not
 doing ANY filtering when doing the `update()` call, so that seems non-
 sensical).

 In any case, I don't think an update should fail silently.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181f92a9b0b-714d6cc0-d2e7-48d8-ae01-8cf946a15cb9-00%40eu-central-1.amazonses.com.


Re: [Django] #23842: Transient failure of django.contrib.gis.tests.geoapp.tests.GeoQuerySetTest.test_make_line

2022-07-13 Thread Django
#23842: Transient failure of
django.contrib.gis.tests.geoapp.tests.GeoQuerySetTest.test_make_line
+--
 Reporter:  Simon Charette  |Owner:  nobody
 Type:  Bug |   Status:  closed
Component:  GIS |  Version:  dev
 Severity:  Normal  |   Resolution:  worksforme
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * resolution:   => worksforme


Comment:

 I haven't seen this failure in the last 2-3 years.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181f8fea32e-5dcd2689-ded7-4af7-a24e-e6d98987ba6e-00%40eu-central-1.amazonses.com.


Re: [Django] #19884: Inspectdb on Oracle doesn't produce correct field types

2022-07-13 Thread Django
#19884: Inspectdb on Oracle doesn't produce correct field types
-+-
 Reporter:  Anssi Kääriäinen |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.9
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * resolution:   => fixed


Old description:

> The test inspectdb.test_field_types() has multiple errors, at least:
>   - ~~CharField lengths not correctly inspected (returns double the
> length of generated field)~~
>   - ~~FloatField not correctly inspected (returns DecimalField with
> max_digits=-127)~~
>   - DateTimeField is inspected as TimeField
>
> Getting all these to work correctly will be somewhat hard. So, the
> suggested short-term fix is to just mark the test as expectedFailure on
> Oracle. Inspectdb isn't high-priority as the output should be hand-edited
> in any case.

New description:

 The test inspectdb.test_field_types() has multiple errors, at least:
   - ~~CharField lengths not correctly inspected (returns double the length
 of generated field)~~
   - ~~FloatField not correctly inspected (returns DecimalField with
 max_digits=-127)~~
   - DateTimeField is inspected as TimeField (**cannot be distinguished**)

 Getting all these to work correctly will be somewhat hard. So, the
 suggested short-term fix is to just mark the test as expectedFailure on
 Oracle. Inspectdb isn't high-priority as the output should be hand-edited
 in any case.

--

Comment:

 Both `DateTimeField` and `TimeField` use exactly the same datatype i.e.
 `TIMESTAMP`, they cannot be distinguished in introspection. IMO, we can
 treat this ticket as fixed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181f8f651fc-690df872-73e6-4d7e-ac8d-9879a1e5a740-00%40eu-central-1.amazonses.com.


Re: [Django] #33842: Add links to github for file paths in the documentation

2022-07-13 Thread Django
#33842: Add links to github for file paths in the documentation
-+-
 Reporter:  Ramil Yanbulatov |Owner:  Ramil
 Type:   |  Yanbulatov
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * stage:  Unreviewed => Accepted


Comment:

 OK, [https://github.com/django/django/pull/15808 ticket for existing PR].
 It's likely big enough to require one — thanks!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181f7f5ade0-4134ce2a-cd41-4d54-be1a-ce8a675e2bfe-00%40eu-central-1.amazonses.com.


Re: [Django] #33690: Allow disabling admin module dark theme

2022-07-13 Thread Django
#33690: Allow disabling admin module dark theme
-+-
 Reporter:  nv35 |Owner:  Sarah
 |  Abderemane
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  dark theme   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Carlton Gibson):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181f7da7533-b9389f41-8418-4b25-89ca-9e696a906561-00%40eu-central-1.amazonses.com.


Re: [Django] #33690: Allow disabling admin module dark theme

2022-07-13 Thread Django
#33690: Allow disabling admin module dark theme
-+-
 Reporter:  nv35 |Owner:  Sarah
 |  Abderemane
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  dark theme   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-

Comment (by Sarah Abderemane):

 [https://github.com/django/django/pull/15843 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181f7881abb-e1f12e95-623f-4072-ab26-a9606d280db1-00%40eu-central-1.amazonses.com.


Re: [Django] #33842: Add links to github for file paths in the documentation

2022-07-13 Thread Django
#33842: Add links to github for file paths in the documentation
-+-
 Reporter:  rayman1104   |Owner:
 Type:   |  rayman1104
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by rayman1104):

 * owner:  nobody => rayman1104
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181f7592719-744046de-8ff9-46ca-8814-0475fe3a1959-00%40eu-central-1.amazonses.com.


Re: [Django] #33842: Add links to github for file paths in the documentation

2022-07-13 Thread Django
#33842: Add links to github for file paths in the documentation
-+-
 Reporter:  rayman1104   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by rayman1104:

Old description:

> It's sometimes confusing to see such statements in the
> [https://docs.djangoproject.com/en/dev/ref/contrib/admin/#admin-
> overriding-templates docs]:
>
> > The admin template files are located in the
> **contrib/admin/templates/admin** directory.
>
> Since I don't have such path in my project, I don't know where to go to
> find it. Finally, I understood that the Django's source code is meant and
> I can find it on github. But it would be more clear if we just had a link
> on github there:
>
> > The admin template files are located in the
> [https://github.com/django/django/tree/main/django/contrib/admin/templates/admin
> django/contrib/admin/templates/admin] directory.
>
> Here is the ​[https://github.com/django/django/pull/15808 PR].

New description:

 It's sometimes confusing to see such statements in the
 [https://docs.djangoproject.com/en/dev/ref/contrib/admin/#admin-
 overriding-templates docs]:

 > The admin template files are located in the
 **contrib/admin/templates/admin** directory.

 Since I don't have such path in my project, I don't know where to go to
 find it. Finally, I understood that the Django's source code is meant and
 I can find it on github. But it would be more clear if we just had a link
 on github there:

 > The admin template files are located in the
 
[https://github.com/django/django/tree/main/django/contrib/admin/templates/admin
 django/contrib/admin/templates/admin] directory.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181f758748a-e6d0ffb3-df23-4576-adae-2645efa96d31-00%40eu-central-1.amazonses.com.


Re: [Django] #33842: Add links to github for file paths in the documentation

2022-07-13 Thread Django
#33842: Add links to github for file paths in the documentation
-+-
 Reporter:  rayman1104   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by rayman1104):

 [https://github.com/django/django/pull/15808 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181f756f717-ecbdcfac-2d23-41ca-85ad-c3c849eb26b3-00%40eu-central-1.amazonses.com.


[Django] #33842: Add links to github for file paths in the documentation

2022-07-13 Thread Django
#33842: Add links to github for file paths in the documentation
+
   Reporter:  rayman1104|  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Documentation |Version:  dev
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 It's sometimes confusing to see such statements in the
 [https://docs.djangoproject.com/en/dev/ref/contrib/admin/#admin-
 overriding-templates docs]:

 > The admin template files are located in the
 **contrib/admin/templates/admin** directory.

 Since I don't have such path in my project, I don't know where to go to
 find it. Finally, I understood that the Django's source code is meant and
 I can find it on github. But it would be more clear if we just had a link
 on github there:

 > The admin template files are located in the
 
[https://github.com/django/django/tree/main/django/contrib/admin/templates/admin
 django/contrib/admin/templates/admin] directory.

 Here is the ​[https://github.com/django/django/pull/15808 PR].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181f75647f3-0374cf78-18a2-4955-a6db-013f2b7e679e-00%40eu-central-1.amazonses.com.


Re: [Django] #30711: Document django.contrib.postgres.fields.hstore.KeyTransform.

2022-07-13 Thread Django
#30711: Document django.contrib.postgres.fields.hstore.KeyTransform.
-+-
 Reporter:  Gustav Eiman |Owner:  Alokik
 Type:   |  Roy
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  HStoreField F| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"7faf25d682b8e8f4fd2006eb7dfc71ed2a2193b7" 7faf25d]:
 {{{
 #!CommitTicketReference repository=""
 revision="7faf25d682b8e8f4fd2006eb7dfc71ed2a2193b7"
 Fixed #30711 -- Doc'd
 django.contrib.postgres.fields.hstore.KeyTransform().
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181f6e9ad0d-4912f489-8594-42f1-93f4-97f0154d36a6-00%40eu-central-1.amazonses.com.


Re: [Django] #30711: Document django.contrib.postgres.fields.hstore.KeyTransform.

2022-07-13 Thread Django
#30711: Document django.contrib.postgres.fields.hstore.KeyTransform.
-+-
 Reporter:  Gustav Eiman |Owner:  Alokik
 Type:   |  Roy
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  HStoreField F| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"0acaea1329e1b31d38dff2b58fc9088814981e0d" 0acaea13]:
 {{{
 #!CommitTicketReference repository=""
 revision="0acaea1329e1b31d38dff2b58fc9088814981e0d"
 [4.1.x] Fixed #30711 -- Doc'd
 django.contrib.postgres.fields.hstore.KeyTransform().

 Backport of 7faf25d682b8e8f4fd2006eb7dfc71ed2a2193b7 from main
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181f6e9ab7f-2261ad79-d040-448e-b350-7fbbbe23ff0b-00%40eu-central-1.amazonses.com.


Re: [Django] #30711: Document django.contrib.postgres.fields.hstore.KeyTransform.

2022-07-13 Thread Django
#30711: Document django.contrib.postgres.fields.hstore.KeyTransform.
-+-
 Reporter:  Gustav Eiman |Owner:  Alokik
 Type:   |  Roy
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  HStoreField F| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * has_patch:  0 => 1
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181f6c748a4-0ab3ecb0-92d1-4afd-8145-96a1070dd077-00%40eu-central-1.amazonses.com.


Re: [Django] #11927: Allow manage.py dumpdata to dump YAML in block style

2022-07-13 Thread Django
#11927: Allow manage.py dumpdata to dump YAML in block style
-+-
 Reporter:  sampablokuper|Owner:  Matthijs
 |  Kooijman
 Type:  New feature  |   Status:  closed
Component:  Core (Management |  Version:  dev
  commands)  |
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * status:  assigned => closed
 * resolution:   => wontfix
 * stage:  Accepted => Unreviewed


Comment:

 Given the difficulty of progressing this, and the amount of time it's sat
 untouched, I can't see that adding pass-through CLI options for
 serialisers is a good way forward.

 Rather, I'd think that creating a serialiser subclass, encapsulating your
 project options and using the existing
 [https://docs.djangoproject.com/en/4.0/ref/settings/#serialization-modules
 SERIALIZATION_MODULES] setting is the way forward.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181f6a8f880-950a6c1d-d281-4b19-a4ef-acd2997dfca2-00%40eu-central-1.amazonses.com.


Re: [Django] #32934: Fix Admin's sidebar height to be dynamic based on visible header

2022-07-13 Thread Django
#32934: Fix Admin's sidebar height to be dynamic based on visible header
-+-
 Reporter:  gary |Owner:
 |  Hrushikesh Vaidya
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  3.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  1
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181f684c95c-5a91e3df-2e2a-49e4-b23d-4a7b9e3b28a8-00%40eu-central-1.amazonses.com.


Re: [Django] #33839: Support pathlib.Path in loaders' get_template().

2022-07-13 Thread Django
#33839: Support pathlib.Path in loaders' get_template().
-+-
 Reporter:  simon klemenc|Owner:  simon klemenc
 Type:  New feature  |   Status:  closed
Component:  Template system  |  Version:  dev
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Carlton Gibson):

 I'll just note, the API contract here isn't to ''paths'' but to ''template
 names''. Really it's an implementation detail of the loaders that those
 names map to the file system. A DB-based loader (say) would be free to
 adopt a totally different naming scheme, such that getting passed
 `pathlib.Path` instances would be unexpected, shall we say.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181f66f2d3c-1896a5f7-4938-4af2-9184-e3d48125f0da-00%40eu-central-1.amazonses.com.


Re: [Django] #33839: Support pathlib.Path in loaders' get_template().

2022-07-13 Thread Django
#33839: Support pathlib.Path in loaders' get_template().
-+-
 Reporter:  simon klemenc|Owner:  simon klemenc
 Type:  New feature  |   Status:  closed
Component:  Template system  |  Version:  dev
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  assigned => closed
 * needs_tests:  1 => 0
 * needs_docs:  1 => 0
 * has_patch:  1 => 0
 * resolution:   => wontfix
 * stage:  Accepted => Unreviewed


Comment:

 Agreed with David and Carlton.

 Simon, please
 [https://docs.djangoproject.com/en/stable/internals/contributing/triaging-
 tickets/#closing-tickets follow the triaging guidelines with regards to
 wontfix tickets] and take this to DevelopersMailingList if you don't
 agree.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181f66afc2e-2f0a5cd2-cb13-4b1c-b5df-93941ba651d7-00%40eu-central-1.amazonses.com.


Re: [Django] #33839: Support pathlib.Path in loaders' get_template().

2022-07-13 Thread Django
#33839: Support pathlib.Path in loaders' get_template().
-+-
 Reporter:  simon klemenc|Owner:  simon klemenc
 Type:  New feature  |   Status:  assigned
Component:  Template system  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Carlton Gibson):

 TBH I think I'm -1 on this as well.

 I see no benefit in loosening the accepted type on the `template_name`
 argument, from `str` to `Union[str, Path]` as in the draft PR.
 It's a looser API, that doesn't match the underlying expectations, as
 David points out.

 I'd suggest casting to `str` as a last step if want to use `pathlib` for
 the manipulations.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181f666393e-4027d299-ff2f-46ab-a3b8-72bb15e3dd2e-00%40eu-central-1.amazonses.com.


Re: [Django] #33631: Blocktranslate asvar escapes variables, but stores the result as str instance, leading to double escaping

2022-07-13 Thread Django
#33631: Blocktranslate asvar escapes variables, but stores the result as str
instance, leading to double escaping
-+-
 Reporter:  Richard Ebeling  |Owner:  Cheng
 |  Yuan
 Type:  Bug  |   Status:  assigned
Component:  Uncategorized|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  blocktranslate   | Triage Stage:  Accepted
  asvar escape   |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_docs:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181f652fb7f-1a2d41f4-6796-40ef-9a7d-d6f6559ec77e-00%40eu-central-1.amazonses.com.


Re: [Django] #27236: Deprecate Model.Meta.index_together in favour of Model.Meta.indexes

2022-07-13 Thread Django
#27236: Deprecate Model.Meta.index_together in favour of Model.Meta.indexes
-+-
 Reporter:  Akshesh Doshi|Owner:  David
 Type:   |  Wobrock
  Cleanup/optimization   |   Status:  closed
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  index_together   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by David Wobrock ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"a6385b382e05a614a99e5a5913d8e631823159a2" a6385b3]:
 {{{
 #!CommitTicketReference repository=""
 revision="a6385b382e05a614a99e5a5913d8e631823159a2"
 Fixed #27236 -- Deprecated Meta.index_together in favor of Meta.indexes.

 This also deprecates AlterIndexTogether migration operation.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181f6456721-cf704517-be33-4b7d-9f0c-93897acbb973-00%40eu-central-1.amazonses.com.