Re: [Django] #11772: ModelAdmin - added a model_modified hook for full CRUD support

[Django]

#11772: ModelAdmin - added a model_modified hook for full CRUD support
-+-
 Reporter:  Rupe |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:  modeladmin hook  | Triage Stage:  Design
  modified save add change delete|  decision needed
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by mitar):

 What about my proposal about signals?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #11772: ModelAdmin - added a model_modified hook for full CRUD support

[Django]

#11772: ModelAdmin - added a model_modified hook for full CRUD support
-+-
 Reporter:  Rupe |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:  modeladmin hook  | Triage Stage:  Design
  modified save add change delete|  decision needed
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by aaugustin):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 `model_modified` duplicates existing functionality for hooking on model
 changes; I don't like that.

 This is really a feature request, please take it to django-developers and
 try to get consensus on a better way of achieving this goal.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #11772: ModelAdmin - added a model_modified hook for full CRUD support

[Django]

#11772: ModelAdmin - added a model_modified hook for full CRUD support
-+--
  Reporter:  Rupe| Owner:  nobody   
  
Status:  new | Milestone:   
  
 Component:  django.contrib.admin|   Version:  SVN  
  
Resolution:  |  Keywords:  modeladmin hook 
modified save add change delete
 Stage:  Design decision needed  | Has_patch:  1
  
Needs_docs:  1   |   Needs_tests:  1
  
Needs_better_patch:  0   |  
-+--
Comment (by Rupe):

 I'm ok with that. I'll do up the changes.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11772: ModelAdmin - added a model_modified hook for full CRUD support

[Django]

#11772: ModelAdmin - added a model_modified hook for full CRUD support
-+--
  Reporter:  Rupe| Owner:  nobody   
  
Status:  new | Milestone:   
  
 Component:  django.contrib.admin|   Version:  SVN  
  
Resolution:  |  Keywords:  modeladmin hook 
modified save add change delete
 Stage:  Design decision needed  | Has_patch:  1
  
Needs_docs:  1   |   Needs_tests:  1
  
Needs_better_patch:  0   |  
-+--
Changes (by mitar):

 * cc: mmi...@gmail.com (added)

Comment:

 I think we should go for signals here. There is no need to have some new
 hooks. If there is a wish for changing the response it can always be
 passed as an argument. Or a sender can be an admin object itself.

 In this way it is not necessary to subclass the admin class.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11772: ModelAdmin - added a model_modified hook for full CRUD support

[Django]

#11772: ModelAdmin - added a model_modified hook for full CRUD support
-+--
  Reporter:  Rupe| Owner:  nobody   
  
Status:  new | Milestone:   
  
 Component:  django.contrib.admin|   Version:  SVN  
  
Resolution:  |  Keywords:  modeladmin hook 
modified save add change delete
 Stage:  Design decision needed  | Has_patch:  1
  
Needs_docs:  1   |   Needs_tests:  1
  
Needs_better_patch:  0   |  
-+--
Changes (by ubernostrum):

  * milestone:  1.2 =>

Comment:

 1.2 is feature-frozen, moving this feature request off the milestone.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11772: ModelAdmin - added a model_modified hook for full CRUD support

[Django]

#11772: ModelAdmin - added a model_modified hook for full CRUD support
---+
  Reporter:  Rupe  | Owner:  nobody 

Status:  new   | Milestone:  1.2

 Component:  django.contrib.admin  |   Version:  SVN

Resolution:|  Keywords:  modeladmin hook 
modified save add change delete
 Stage:  Unreviewed| Has_patch:  1  

Needs_docs:  0 |   Needs_tests:  0  

Needs_better_patch:  0 |  
---+
Changes (by Rupe):

  * milestone:  => 1.2

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11772: ModelAdmin - added a model_modified hook for full CRUD support

[Django]

#11772: ModelAdmin - added a model_modified hook for full CRUD support
---+
  Reporter:  Rupe  | Owner:  nobody 

Status:  new   | Milestone: 

 Component:  django.contrib.admin  |   Version:  SVN

Resolution:|  Keywords:  modeladmin hook 
modified save add change delete
 Stage:  Unreviewed| Has_patch:  1  

Needs_docs:  0 |   Needs_tests:  0  

Needs_better_patch:  0 |  
---+
Comment (by Rupe):

 The has_changed hook doesn't look like it triggers on the delete of a
 record.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11772: ModelAdmin - added a model_modified hook for full CRUD support

[Django]

#11772: ModelAdmin - added a model_modified hook for full CRUD support
---+
  Reporter:  Rupe  | Owner:  nobody 

Status:  new   | Milestone: 

 Component:  django.contrib.admin  |   Version:  SVN

Resolution:|  Keywords:  modeladmin hook 
modified save add change delete
 Stage:  Unreviewed| Has_patch:  1  

Needs_docs:  0 |   Needs_tests:  0  

Needs_better_patch:  0 |  
---+
Changes (by Mnewman):

  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 Can you clear up for me why you need a hook here? You have access to
 model.form.has_changed() in any other hook on the modeladmin, and this
 looks like overkill for me. Maybe I am missing something.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

[Django] #11772: ModelAdmin - added a model_modified hook for full CRUD support

[Django]

#11772: ModelAdmin - added a model_modified hook for full CRUD support
-+--
 Reporter:  Rupe |   Owner:  
nobody
   Status:  new  |   Milestone: 
   
Component:  django.contrib.admin | Version:  
SVN   
 Keywords:  modeladmin hook modified save add change delete  |   Stage:  
Unreviewed
Has_patch:  1|  
-+--
 I added a simple hook called model_modified that is called after each
 insert, update, and delete via the ModelAdmin class. There are times when
 it's useful to know when a model changes in any way by the user (via the
 admin app), including delete. The current methodology of overriding the
 save_model hook does not include delete. The usefulness of this hook over
 using the model signals for model changes is that you have access to the
 response object. I used this hook to clear certain session variables that
 were dependent on the correlating models.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---