Re: [Django] #13721: pass extra content-type values to file upload handlers

[Django]

#13721: pass extra content-type values to file upload handlers
--+
 Reporter:  wkornewald|Owner:  mvschaik
 Type:  New feature   |   Status:  closed
Component:  File uploads/storage  |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by timo):

 Hi Gabe, this ticket trackers isn't a support channel. Please see
 https://docs.djangoproject.com/en/stable/faq/help/ for ways to get help.
 Thanks!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.cdac437a6bd0037e74827f1678b5387a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #13721: pass extra content-type values to file upload handlers

[Django]

#13721: pass extra content-type values to file upload handlers
--+
 Reporter:  wkornewald|Owner:  mvschaik
 Type:  New feature   |   Status:  closed
Component:  File uploads/storage  |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by Gabe):

 Hi guys!

 I'm using Django 1.5 with Python 2.7 running in Google App Engine. I got
 into this project recently, the former programmers didn't use the webapp
 framework, but now I have to be able to make file upload possible with
 large files (GAE doesn't allow more than 1 MB). I tried to make blobstore
 work, but I couldn't, then I started looking into this stuff and found
 this patch. Is it possible to make this patch work with GAE?

 Thanks in advance!

 Gabe

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.08ec31bc664d95f4d508f7cf052816d2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #13721: pass extra content-type values to file upload handlers

[Django]

#13721: pass extra content-type values to file upload handlers
--+
 Reporter:  wkornewald|Owner:  mvschaik
 Type:  New feature   |   Status:  closed
Component:  File uploads/storage  |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by Tim Graham ):

 In [changeset:"d3e33fff12266b51ab1488f7094855aef6061e9e"]:
 {{{
 #!CommitTicketReference repository=""
 revision="d3e33fff12266b51ab1488f7094855aef6061e9e"
 Made content_type_extra optional for TemporaryUploadedFile and
 MemoryUploadedFile.

 This provides better backwards compatibility for those constructing these
 objects manually.

 Refs #13721.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.99539ea0acefcdb0023596fcfbb9%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13721: pass extra content-type values to file upload handlers

[Django]

#13721: pass extra content-type values to file upload handlers
--+
 Reporter:  wkornewald|Owner:  mvschaik
 Type:  New feature   |   Status:  closed
Component:  File uploads/storage  |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"b0953dc91385fb2823294a76d3c99e01c7b7e4ee"]:
 {{{
 #!CommitTicketReference repository=""
 revision="b0953dc91385fb2823294a76d3c99e01c7b7e4ee"
 Fixed #13721 -- Added UploadedFile.content_type_extra.

 Thanks Waldemar Kornewald and mvschaik for work on the patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.7a4bacb71605068bec55c697e4469371%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13721: pass extra content-type values to file upload handlers

[Django]

#13721: pass extra content-type values to file upload handlers
--+
 Reporter:  wkornewald|Owner:  mvschaik
 Type:  New feature   |   Status:  assigned
Component:  File uploads/storage  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by timo):

 * cc: timograham@… (added)
 * needs_better_patch:  1 => 0


Comment:

 Edited version of kagia's branch:
 https://github.com/django/django/pull/1301

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.860d8e06ae003c3ede97cf573aa9fa04%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13721: pass extra content-type values to file upload handlers

[Django]

#13721: pass extra content-type values to file upload handlers
--+
 Reporter:  wkornewald|Owner:  mvschaik
 Type:  New feature   |   Status:  assigned
Component:  File uploads/storage  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+

Comment (by kagia):

 @mvschaik are you still working on this? You may want to take a look at
 this [https://github.com/kagia/django/compare/ticket_13721 my branch]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13721: pass extra content-type values to file upload handlers

[Django]

#13721: pass extra content-type values to file upload handlers
--+
 Reporter:  wkornewald|Owner:  mvschaik
 Type:  New feature   |   Status:  assigned
Component:  File uploads/storage  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+
Changes (by kagia):

 * needs_better_patch:  0 => 1


Comment:

 line 34 and 35 of the patch are made redundant by the previous line:

 {{{
 content_type_extra = meta_data.get('content-type', (0, {}))[1]
 }}}

 `content_type_extra` is then guaranteed not to be `None`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13721: pass extra content-type values to file upload handlers

[Django]

#13721: pass extra content-type values to file upload handlers
--+
 Reporter:  wkornewald|Owner:  mvschaik
 Type:  New feature   |   Status:  assigned
Component:  File uploads/storage  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by mvschaik):

 * owner:  nobody => mvschaik
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13721: pass extra content-type values to file upload handlers

[Django]

#13721: pass extra content-type values to file upload handlers
--+
 Reporter:  wkornewald|Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  File uploads/storage  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by anonymous):

 * easy:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13721: pass extra content-type values to file upload handlers

[Django]

#13721: pass extra content-type values to file upload handlers
--+
 Reporter:  wkornewald|Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  File uploads/storage  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by grant.callaghan@…):

 +1. I would really like to see this patch applied

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13721: pass extra content-type values to file upload handlers

[Django]

#13721: pass extra content-type values to file upload handlers
--+
 Reporter:  wkornewald|Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  File uploads/storage  |  Version:  SVN
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by wkornewald):

 * cc: wkornewald@… (removed)
 * ui_ux:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13721: pass extra content-type values to file upload handlers

[Django]

#13721: pass extra content-type values to file upload handlers
-+-
   Reporter: |  Owner:  nobody
  wkornewald | Status:  new
   Type:  New|  Component:  File
  feature|  uploads/storage
  Milestone:  1.4|   Severity:  Normal
Version:  SVN|   Keywords:
 Resolution: |  Has patch:  1
   Triage Stage:  Accepted   |Needs tests:  0
Needs documentation:  0  |  Easy pickings:  0
Patch needs improvement:  0  |
-+-
Changes (by wkornewald):

 * needs_better_patch:  1 => 0
 * version:  1.2 => SVN
 * milestone:  1.3 => 1.4


Comment:

 I've updated the patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13721: pass extra content-type values to file upload handlers

[Django]

#13721: pass extra content-type values to file upload handlers
-+-
   Reporter: |  Owner:  nobody
  wkornewald | Status:  new
   Type:  New|  Component:  File
  feature|  uploads/storage
  Milestone:  1.3|   Severity:  Normal
Version:  1.2|   Keywords:
 Resolution: |  Has patch:  1
   Triage Stage:  Accepted   |Needs tests:  0
Needs documentation:  0  |  Easy pickings:  0
Patch needs improvement:  1  |
-+-
Changes (by patchhammer):

 * needs_better_patch:  0 => 1
 * easy:   => 0


Comment:

 content_type_extra.diff fails to apply cleanly on to trunk

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13721: pass extra content-type values to file upload handlers

[Django]

#13721: pass extra content-type values to file upload handlers
+---
   Reporter:  wkornewald| Owner:  nobody
 Status:  new   | Milestone:  1.3   
  Component:  File uploads/storage  |   Version:  1.2   
 Resolution:|  Keywords:
   Triage Stage:  Accepted  | Has patch:  1 
Needs documentation:  0 |   Needs tests:  0 
Patch needs improvement:  0 |  
+---
Changes (by wkornewald):

 * cc: wkornewald@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13721: pass extra content-type values to file upload handlers

[Django]

#13721: pass extra content-type values to file upload handlers
---+
  Reporter:  wkornewald| Owner:  nobody
Status:  new   | Milestone:  1.3   
 Component:  File uploads/storage  |   Version:  1.2   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by wkornewald):

  * needs_docs:  1 => 0
  * needs_tests:  1 => 0

Comment:

 Done. I've added a simple test case and docs. Do you need anything else
 before it can be committed?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13721: pass extra content-type values to file upload handlers

[Django]

#13721: pass extra content-type values to file upload handlers
---+
  Reporter:  wkornewald| Owner:  nobody
Status:  new   | Milestone:  1.3   
 Component:  File uploads/storage  |   Version:  1.2   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  1 |   Needs_tests:  1 
Needs_better_patch:  0 |  
---+
Changes (by lrekucki):

  * needs_docs:  0 => 1
  * needs_tests:  0 => 1
  * stage:  Design decision needed => Accepted

Comment:

 Probably a simple test case and some docs for people that need this. I see
 no obvious reason not to do this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13721: pass extra content-type values to file upload handlers

[Django]

#13721: pass extra content-type values to file upload handlers
-+--
  Reporter:  wkornewald  | Owner:  nobody
Status:  new | Milestone:  1.3   
 Component:  File uploads/storage|   Version:  1.2   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by wkornewald):

  * has_patch:  0 => 1

Comment:

 What does it take to get this committed into trunk? This change is
 absolutely necessary for App Engine's Blobstore and it's a really harmless
 change.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13721: pass extra content-type values to file upload handlers

[Django]

#13721: pass extra content-type values to file upload handlers
-+--
  Reporter:  wkornewald  | Owner:  nobody
Status:  new | Milestone:  1.3   
 Component:  File uploads/storage|   Version:  1.2   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Comment (by wkornewald):

 Still no response from a committer? :(
 Is something missing?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13721: pass extra content-type values to file upload handlers

[Django]

#13721: pass extra content-type values to file upload handlers
-+--
  Reporter:  wkornewald  | Owner:  nobody
Status:  new | Milestone:  1.3   
 Component:  File uploads/storage|   Version:  1.2   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by adamnelson):

  * stage:  Unreviewed => Design decision needed

Comment:

 Good point, we should add that to the style guide:

 http://www.network-theory.co.uk/docs/pytut/DefaultArgumentValues.html

 Nevertheless, this ticket needs to be approved by a committer first.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13721: pass extra content-type values to file upload handlers

[Django]

#13721: pass extra content-type values to file upload handlers
---+
  Reporter:  wkornewald| Owner:  nobody
Status:  new   | Milestone:  1.3   
 Component:  File uploads/storage  |   Version:  1.2   
Resolution:|  Keywords:
 Stage:  Unreviewed| Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by wkornewald):

 Maybe it's fine with a .copy(), but then that's an unnecessary copy.
 Normally, I don't pass mutable objects as default arguments because that
 can lead to hidden, hard to track bugs, so I've just settled on always
 using None. Is this a show-stopper? :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13721: pass extra content-type values to file upload handlers

[Django]

#13721: pass extra content-type values to file upload handlers
---+
  Reporter:  wkornewald| Owner:  nobody
Status:  new   | Milestone:  1.3   
 Component:  File uploads/storage  |   Version:  1.2   
Resolution:|  Keywords:
 Stage:  Unreviewed| Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by adamnelson):

 It seems like you could use this definition:

 {{{
 def new_file(self, field_name, file_name, content_type, content_length,
 charset=None, content_type_extra={}):
 }}}

 Then you wouldn't have to check if content_type_extra is None.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13721: pass extra content-type values to file upload handlers

[Django]

#13721: pass extra content-type values to file upload handlers
---+
  Reporter:  wkornewald| Owner:  nobody
Status:  new   | Milestone:  1.3   
 Component:  File uploads/storage  |   Version:  1.2   
Resolution:|  Keywords:
 Stage:  Unreviewed| Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by wkornewald):

  * needs_better_patch:  => 0
  * component:  Uncategorized => File uploads/storage
  * needs_tests:  => 0
  * needs_docs:  => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #13721: pass extra content-type values to file upload handlers

[Django]

#13721: pass extra content-type values to file upload handlers
---+
 Reporter:  wkornewald |   Owner:  nobody
   Status:  new|   Milestone:  1.3   
Component:  Uncategorized  | Version:  1.2   
 Keywords: |   Stage:  Unreviewed
Has_patch:  0  |  
---+
 Currently, file upload handlers can only get the actual content type and
 charset, but App Engine's Blobstore file service passes a few extra vales
 to the content type which are needed to get the uploaded file's identifier
 ("blob-key"). Here's a sample snippet of an HTTP upload request's POST
 data:

 {{{
 --===0880245784==
 Content-Type: message/external-body; blob-key="WEexn9L82wky30ADBOWqYA==";
 access-type="X-AppEngine-BlobKey"
 MIME-Version: 1.0
 Content-Disposition: form-data; name="file"; filename="django-nonrel.diff"

 Content-Type: application/octet-stream
 MIME-Version: 1.0
 Content-Length: 8522
 content-type: application/octet-stream
 content-disposition: form-data; name="file"; filename="django-nonrel.diff"
 X-AppEngine-Upload-Creation: 2010-06-08 15:34:32.685000


 --===0880245784==--
 }}}

 The attached patch changes the file upload handling code such that it
 passes a dictionary with all extra content type arguments to the upload
 handler. With this I was able to successfully upload files to a model's
 FileField via a ModelForm.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.