Re: [Django] #14688: BaseInlineFormSet does not support "auto_id"

2019-04-16 Thread Django
#14688: BaseInlineFormSet does not support "auto_id"
---+
 Reporter:  Victor Andrée  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Forms  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  formsets   | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Nick Pope):

 * status:  closed => new
 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1
 * resolution:  fixed =>
 * needs_tests:  0 => 1


Comment:

 Reopening due to
 [https://github.com/django/django/pull/11237#issuecomment-483382596
 comment] on discarded PR.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.9748b8136301f734058e279d2ec6209e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #14688: BaseInlineFormSet does not support "auto_id"

2019-04-15 Thread Django
#14688: BaseInlineFormSet does not support "auto_id"
---+
 Reporter:  Victor Andrée  |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Forms  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords:  formsets   | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Tobias Kunze):

 * status:  new => closed
 * needs_better_patch:  1 => 0
 * has_patch:  1 => 0
 * resolution:   => fixed
 * needs_tests:  1 => 0


Comment:

 This issue has been fixed some time ago: In e308cfc0e15 (7 years ago, a
 year after this issue was opened), `BaseInlineFormSet` started passing
 `**kwargs` in its `super()` call.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.678e3b418cbdafdd747495be846c63ea%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #14688: BaseInlineFormSet does not support "auto_id"

2011-04-01 Thread Django
#14688: BaseInlineFormSet does not support "auto_id"
-+
   Reporter:  vicvicvic  |Owner:  nobody
   Type:  Bug|   Status:  new
  Milestone: |Component:  Forms
Version:  SVN| Severity:  Normal
 Resolution: | Keywords:  formsets
   Triage Stage:  Accepted   |Has patch:  1
Needs documentation:  0  |  Needs tests:  1
Patch needs improvement:  1  |
-+
Changes (by jaddison):

 * type:   => Bug
 * severity:   => Normal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.



Re: [Django] #14688: BaseInlineFormSet does not support "auto_id"

2010-12-30 Thread Django
#14688: BaseInlineFormSet does not support "auto_id"
+---
  Reporter:  vicvicvic  | Owner:  nobody  
Status:  new| Milestone:  
 Component:  Forms  |   Version:  SVN 
Resolution: |  Keywords:  formsets
 Stage:  Accepted   | Has_patch:  1   
Needs_docs:  0  |   Needs_tests:  1   
Needs_better_patch:  1  |  
+---
Changes (by russellm):

  * needs_better_patch:  => 1
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 1
  * needs_docs:  => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.



[Django] #14688: BaseInlineFormSet does not support "auto_id"

2010-11-14 Thread Django
#14688: BaseInlineFormSet does not support "auto_id"
---+
 Reporter:  vicvicvic  |   Owner:  nobody
   Status:  new|   Milestone:
Component:  Forms  | Version:  SVN   
 Keywords:  formsets   |   Stage:  Unreviewed
Has_patch:  1  |  
---+
 `BaseInlineFormSet.__init__` does not accept the `auto_id` argument,
 unlike its ancestors. Furthmore, its parent `BaseModelFormSet` takes
 `**kwargs` and passes them along.

 I can't think of a good reason for this omission/difference. I've attached
 a small patch to "match" `BaseInlineFormSet.__init__` with
 `BaseModelFormSet.__init__`. The patch puts the "new" `auto_id` argument
 last in order to maximize backwards compatibility (the order is different
 for `BaseModelFormSet`).

 Arguably, both `prefix` and `auto_id` could be removed from the explicit
 arg list since they're just passed along (in both `BaseModelFormSet` and
 `BaseInlineFormSet`).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.