Re: [Django] #14938: "Save as" does not save entries added with a Inline

2011-01-23 Thread Django 
#14938: "Save as" does not save entries added with a Inline
---+
  Reporter:  rax   | Owner:  nobody  
Status:  new   | Milestone:  1.3 
 Component:  Forms |   Version:  1.2-beta
Resolution:|  Keywords:  save-as 
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  1   
Needs_better_patch:  1 |  
---+
Changes (by russellm):

  * keywords:  save-as, blocker, regression => save-as

Comment:

 Not sure why I marked this blocker, regression; on inspection, it doesn't
 appear to be either. It's been a problem since at least 1.1.X, and it
 doesn't involve data loss (there's lost data on entry, but nothing
 destructive happens to existing data)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14938: "Save as" does not save entries added with a Inline

2011-01-13 Thread Django 
#14938: "Save as" does not save entries added with a Inline
---+
  Reporter:  rax   | Owner:  nobody  
Status:  new   | Milestone:  1.3 
 Component:  Forms |   Version:  1.2-beta
Resolution:|  Keywords:  save-as, blocker, regression
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  1   
Needs_better_patch:  1 |  
---+
Changes (by ramiro):

  * component:  django.contrib.admin => Forms

Comment:

 Actually, the modification proposed by the OP doesn't seem wrong. Simply
 removing the !BaseInlineFormSet implementation of the `total_form_count()`
 method and so leaving to defer to the implementation in !BaseFormSet makes
 the newly filled inline formsets to get validated and (once corrected if
 they didn't validate) saved associated with the new cloned parent model
 instance

 That `if self.save_as_new :` condition was added when these methods
 (`total_form_count()` and `initial_form_count()`) were introduced back in
 r10190 ~two years ago.

 Joseph Kocherhans expressed on IRC it is possible this might be an
 implementation bug.

 Changing component because this doesn't seem to be a admin-specific
 problem.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14938: "Save as" does not save entries added with a Inline

2011-01-13 Thread Django 
#14938: "Save as" does not save entries added with a Inline
---+
  Reporter:  rax   | Owner:  nobody 
 
Status:  new   | Milestone:  1.3
 
 Component:  django.contrib.admin  |   Version:  1.2-beta   
 
Resolution:|  Keywords:  save-as, blocker, 
regression
 Stage:  Accepted  | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  1  
 
Needs_better_patch:  1 |  
---+
Changes (by ramiro):

  * summary:  "Save as" does not save entries added with a TabularInline =>
  "Save as" does not save entries added with a
  Inline

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.