Re: [Django] #14955: URLField validation should use HEAD requet instead of GET

[Django]

#14955: URLField validation should use HEAD requet instead of GET
-+-
   Reporter:  claudep|  Owner:  jezdez
   Type: | Status:  closed
  Uncategorized  |  Component:  Core (Other)
  Milestone:  1.3|   Severity:  Normal
Version:  SVN|   Keywords:
 Resolution:  fixed  |  Has patch:  1
   Triage Stage:  Ready for  |Needs tests:  0
  checkin|  Easy pickings:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
  UI/UX:  0  |
-+-
Changes (by jamstooks ):

 * ui_ux:   => 0
 * type:   => Uncategorized
 * severity:   => Normal
 * easy:   => 0


Comment:

 After thinking about this, I wonder if it's worth falling back to GET for
 any failed request? I've found a variety of IIS servers running ASP.NET
 that are responding with 403 errors or simply timing out on HEAD requests.
 Any thoughts? Should I open another ticket about this?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14955: URLField validation should use HEAD requet instead of GET

[Django]

#14955: URLField validation should use HEAD requet instead of GET
+---
  Reporter:  claudep| Owner: 
Status:  new| Milestone:  1.3
 Component:  Core framework |   Version:  SVN
Resolution: |  Keywords: 
 Stage:  Ready for checkin  | Has_patch:  1  
Needs_docs:  0  |   Needs_tests:  0  
Needs_better_patch:  0  |  
+---
Changes (by jezdez):

  * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14955: URLField validation should use HEAD requet instead of GET

[Django]

#14955: URLField validation should use HEAD requet instead of GET
-+--
  Reporter:  claudep | Owner: 
Status:  new | Milestone:  1.3
 Component:  Core framework  |   Version:  SVN
Resolution:  |  Keywords: 
 Stage:  Accepted| Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Comment (by claudep):

 Thanks Alex for your input. I've modified the patch to get HeadRequest
 class out of the method.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14955: URLField validation should use HEAD requet instead of GET

[Django]

#14955: URLField validation should use HEAD requet instead of GET
-+--
  Reporter:  claudep | Owner: 
Status:  new | Milestone:  1.3
 Component:  Core framework  |   Version:  SVN
Resolution:  |  Keywords: 
 Stage:  Accepted| Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Comment (by Alex):

 Class should not be created inside the method; classes are some of the
 most expensive (memorywise) objects in CPython, and can be slow to gc.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14955: URLField validation should use HEAD requet instead of GET

[Django]

#14955: URLField validation should use HEAD requet instead of GET
-+--
  Reporter:  claudep | Owner: 
Status:  new | Milestone:  1.3
 Component:  Core framework  |   Version:  SVN
Resolution:  |  Keywords: 
 Stage:  Accepted| Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Changes (by claudep):

  * owner:  claudep =>
  * needs_better_patch:  1 => 0

Comment:

 Thanks Luke for the useful insight. The patch now falls back to GET when
 response code is 405 or 501.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14955: URLField validation should use HEAD requet instead of GET

[Django]

#14955: URLField validation should use HEAD requet instead of GET
-+--
  Reporter:  claudep | Owner:  claudep
Status:  new | Milestone:  1.3
 Component:  Core framework  |   Version:  SVN
Resolution:  |  Keywords: 
 Stage:  Accepted| Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  1   |  
-+--
Comment (by lukeplant):

 [http://www.w3.org/Protocols/rfc2616/rfc2616-sec5.html#sec5.1.1 RFC 2616]
 says that all general purpose servers MUST support both GET and HEAD.
 However, I don't think it hurts to fall back to GET, but only if the
 server returns a
 [http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.5.2 501
 code] or a
 [http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.4.6 405
 code].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14955: URLField validation should use HEAD requet instead of GET

[Django]

#14955: URLField validation should use HEAD requet instead of GET
-+--
  Reporter:  claudep | Owner:  claudep
Status:  new | Milestone:  1.3
 Component:  Core framework  |   Version:  SVN
Resolution:  |  Keywords: 
 Stage:  Accepted| Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  1   |  
-+--
Changes (by claudep):

  * owner:  nobody => claudep
  * needs_better_patch:  0 => 1
  * stage:  Ready for checkin => Accepted

Comment:

 Yeah, you are probably right. Even if it adds a supplementary request for
 each not found resource, a fallback to a GET request is probably more
 robust.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14955: URLField validation should use HEAD requet instead of GET

[Django]

#14955: URLField validation should use HEAD requet instead of GET
+---
  Reporter:  claudep| Owner:  nobody
Status:  new| Milestone:  1.3   
 Component:  Core framework |   Version:  SVN   
Resolution: |  Keywords:
 Stage:  Ready for checkin  | Has_patch:  1 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Comment (by Graeme):

 What about websites that don't allow HEAD request? There are some sites
 that only allow GET and POST.
 How about HEAD first fall back to GET?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14955: URLField validation should use HEAD requet instead of GET

[Django]

#14955: URLField validation should use HEAD requet instead of GET
+---
  Reporter:  claudep| Owner:  nobody
Status:  new| Milestone:  1.3   
 Component:  Core framework |   Version:  SVN   
Resolution: |  Keywords:
 Stage:  Ready for checkin  | Has_patch:  1 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by rasca):

  * stage:  Unreviewed => Ready for checkin
  * milestone:  => 1.3

Comment:

 I've applied it cleanly, tested it in a demo app and run the tests OK.
 Marking it as RFC.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14955: URLField validation should use HEAD requet instead of GET

[Django]

#14955: URLField validation should use HEAD requet instead of GET
-+--
  Reporter:  claudep | Owner:  nobody
Status:  new | Milestone:
 Component:  Core framework  |   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Unreviewed  | Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by claudep):

  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 Note that tests are already done in forms/tests/fields.py (e.g.
 test_urlfield_3).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #14955: URLField validation should use HEAD requet instead of GET

[Django]

#14955: URLField validation should use HEAD requet instead of GET
+---
 Reporter:  claudep |   Owner:  nobody
   Status:  new |   Milestone:
Component:  Core framework  | Version:  SVN   
 Keywords:  |   Stage:  Unreviewed
Has_patch:  1   |  
+---
 When an URLField has verify_exists to True, it checks that the page exists
 with urrlib2.urlopen. Doing a GET request (urllib2 default) is not
 necessary whereas a simple HEAD request should be sufficient to know if
 the page exists.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.