Re: [Django] #15098: SiteProfileNotAvailable needs silent_variable_failure=True

[Django]

#15098: SiteProfileNotAvailable needs silent_variable_failure=True
-+-
 Reporter:  tkolar   |Owner:  tkolar
 Type:  Bug  |   Status:  closed
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:  Ready for
  SiteProfileNotAvailable|  checkin
  silent_variable_failure|  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  1|
-+-
Changes (by apollo13):

 * status:  assigned => closed
 * resolution:   => wontfix


Comment:

 Django 1.5 will ship with a new method to add data to the user model and
 as such the current AUTH_PROFILE_MODULE is deprecated and will go away
 (including stuff like get_profile). As a result of the deprecation we
 won't fix any non critical bugs. Sry that we couldn't get this in earlier.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #15098: SiteProfileNotAvailable needs silent_variable_failure=True

[Django]

#15098: SiteProfileNotAvailable needs silent_variable_failure=True
-+-
 Reporter:  tkolar   |Owner:  tkolar
 Type:  Bug  |   Status:  assigned
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
  SiteProfileNotAvailable|  checkin
  silent_variable_failure|  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  1|
-+-
Changes (by vicould):

 * cc: ldelaveau@… (added)
 * stage:  Accepted => Ready for checkin


Comment:

 Bumping the ticket, looks ready for checkin with respect to the previous
 discussion.
 If needed, pull request is at [https://github.com/django/django/pull/449]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #15098: SiteProfileNotAvailable needs silent_variable_failure=True

[Django]

#15098: SiteProfileNotAvailable needs silent_variable_failure=True
-+-
   Reporter:  tkolar |  Owner:  tkolar
   Type:  Bug| Status:  assigned
  Milestone: |  Component:  contrib.auth
Version:  SVN|   Severity:  Normal
 Resolution: |   Keywords:
   Triage Stage:  Accepted   |  SiteProfileNotAvailable
Needs documentation:  0  |  silent_variable_failure
Patch needs improvement:  0  |  Has patch:  1
 |Needs tests:  0
 |  Easy pickings:  1
-+-
Changes (by tkolar):

 * easy:  0 => 1


Comment:

 And since all that anyone has to do with this patch to implement it is
 apply it, I set "easy pickings".

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15098: SiteProfileNotAvailable needs silent_variable_failure=True

[Django]

#15098: SiteProfileNotAvailable needs silent_variable_failure=True
-+-
   Reporter:  tkolar |  Owner:  tkolar
   Type:  Bug| Status:  assigned
  Milestone: |  Component:  contrib.auth
Version:  SVN|   Severity:  Normal
 Resolution: |   Keywords:
   Triage Stage:  Accepted   |  SiteProfileNotAvailable
Needs documentation:  0  |  silent_variable_failure
Patch needs improvement:  0  |  Has patch:  1
 |Needs tests:  0
 |  Easy pickings:  0
-+-
Changes (by tkolar):

 * easy:   => 0


Comment:

 Should the severity of this bug really be "normal"? If it isn't fixed,
 every template that does `{{ user.get_profile. }}` will be
 broken if users do not necessarily have a profile. Besides, there is no
 other reliable way to get profile fields at all in the given situation
 without changing the view. Also, my patch fixes it already.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15098: SiteProfileNotAvailable needs silent_variable_failure=True

[Django]

#15098: SiteProfileNotAvailable needs silent_variable_failure=True
-+-
   Reporter:  tkolar |Owner:  tkolar
   Type:  Bug|   Status:  assigned
  Milestone: |Component:  contrib.auth
Version:  SVN| Severity:  Normal
 Resolution: | Keywords:
   Triage Stage:  Accepted   |  SiteProfileNotAvailable
Needs documentation:  0  |  silent_variable_failure
Patch needs improvement:  0  |Has patch:  1
 |  Needs tests:  0
-+-
Changes (by jaddison):

 * type:   => Bug
 * severity:   => Normal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15098: SiteProfileNotAvailable needs silent_variable_failure=True

[Django]

#15098: SiteProfileNotAvailable needs silent_variable_failure=True
--+-
   Reporter:  tkolar  | Owner:  tkolar  
   
 Status:  assigned| Milestone:  
   
  Component:  Authentication  |   Version:  SVN 
   
 Resolution:  |  Keywords:  
SiteProfileNotAvailable silent_variable_failure
   Triage Stage:  Accepted| Has patch:  1   
   
Needs documentation:  0   |   Needs tests:  0   
   
Patch needs improvement:  0   |  
--+-
Changes (by tkolar):

  * status:  new => assigned
  * needs_better_patch:  1 => 0
  * needs_tests:  1 => 0
  * owner:  nobody => tkolar


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15098: SiteProfileNotAvailable needs silent_variable_failure=True

[Django]

#15098: SiteProfileNotAvailable needs silent_variable_failure=True
--+-
   Reporter:  tkolar  | Owner:  nobody  
   
 Status:  new | Milestone:  
   
  Component:  Authentication  |   Version:  SVN 
   
 Resolution:  |  Keywords:  
SiteProfileNotAvailable silent_variable_failure
   Triage Stage:  Accepted| Has patch:  1   
   
Needs documentation:  0   |   Needs tests:  1   
   
Patch needs improvement:  1   |  
--+-
Changes (by tkolar):

 * cc: tkolar (added)


Comment:

 Done ;)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15098: SiteProfileNotAvailable needs silent_variable_failure=True

[Django]

#15098: SiteProfileNotAvailable needs silent_variable_failure=True
-+--
  Reporter:  tkolar  | Owner:  nobody   
  
Status:  new | Milestone:   
  
 Component:  Authentication  |   Version:  SVN  
  
Resolution:  |  Keywords:  SiteProfileNotAvailable 
silent_variable_failure
 Stage:  Accepted| Has_patch:  1
  
Needs_docs:  0   |   Needs_tests:  1
  
Needs_better_patch:  1   |  
-+--
Changes (by russellm):

  * needs_better_patch:  0 => 1
  * has_patch:  0 => 1
  * needs_tests:  0 => 1
  * stage:  Unreviewed => Accepted

Comment:

 Seems like a reasonable suggestion. I can't think of any reason that
 get_profile should raise an exception during template rendering.

 For future reference, please upload patches, rather than full files.
 Patches should also include tests to validate that the change does what it
 says.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15098: SiteProfileNotAvailable needs silent_variable_failure=True

[Django]

#15098: SiteProfileNotAvailable needs silent_variable_failure=True
-+--
  Reporter:  tkolar  | Owner:  nobody   
  
Status:  new | Milestone:   
  
 Component:  Authentication  |   Version:  SVN  
  
Resolution:  |  Keywords:  SiteProfileNotAvailable 
silent_variable_failure
 Stage:  Unreviewed  | Has_patch:  0
  
Needs_docs:  0   |   Needs_tests:  0
  
Needs_better_patch:  0   |  
-+--
Changes (by tkolar):

  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 Sorry for the dead link in the file description - no idea how that
 happened.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #15098: SiteProfileNotAvailable needs silent_variable_failure=True

[Django]

#15098: SiteProfileNotAvailable needs silent_variable_failure=True
-+--
 Reporter:  tkolar   |   Owner:  
nobody
   Status:  new  |   Milestone: 
   
Component:  Authentication   | Version:  
SVN   
 Keywords:  SiteProfileNotAvailable silent_variable_failure  |   Stage:  
Unreviewed
Has_patch:  0|  
-+--
 This makes sense in the context of #15097. If I understand this correctly,
 the problem from #15097 should exist in the dev version (because of the
 behavior detailed in the paragraph directly above
 [http://docs.djangoproject.com/en/dev/ref/templates/api/#how-invalid-
 variables-are-handled]). My guess is that this is exactly the type of
 thing that `silent_variable_failure` is there for, and
 `SiteProfileNotAvailable` does not have `silent_variable_failure=True` in
 SVN. I have attached a `models.py` that fixes this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.