Re: [Django] #15187: CommonMiddleware should only send broken link emails if DEBUG is False

[Django]

#15187: CommonMiddleware should only send broken link emails if DEBUG is False
-+--
   Reporter:  dancarroll | Owner:  dancarroll   
 Status:  closed | Milestone:   
  Component:  Core framework |   Version:  1.2  
 Resolution:  fixed  |  Keywords:  common middleware
   Triage Stage:  Ready for checkin  | Has patch:  1
Needs documentation:  0  |   Needs tests:  0
Patch needs improvement:  0  |  
-+--
Changes (by russellm):

  * status:  assigned => closed
  * resolution:  => fixed


Comment:

 (In [15363]) Fixed #15187 -- Ensure that missing page emails aren't sent
 when running under debug. Thanks to Dan Carroll for the report and patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15187: CommonMiddleware should only send broken link emails if DEBUG is False

[Django]

#15187: CommonMiddleware should only send broken link emails if DEBUG is False
-+--
   Reporter:  dancarroll | Owner:  dancarroll   
 Status:  assigned   | Milestone:   
  Component:  Core framework |   Version:  1.2  
 Resolution: |  Keywords:  common middleware
   Triage Stage:  Ready for checkin  | Has patch:  1
Needs documentation:  0  |   Needs tests:  0
Patch needs improvement:  0  |  
-+--
Changes (by russellm):

  * stage:  Unreviewed => Ready for checkin


Comment:

 Low impact isn't really the measure here -- regardless of impact, every
 change *could* regress behavior, so it should be tested.

 However, in this case, the behavior is something that is difficult to
 accurately test for regression, because debug is turned off for testing
 purposes. *That* is a good reason to accept the patch without a test.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.