Re: [Django] #15250: Cannot fill parent model instance in cache

[Django]

#15250: Cannot fill parent model instance in cache
-+-
 Reporter:  vzima|Owner:  czpython
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Simon Charette ):

 In [changeset:"0bbab97c289ebcfd5676d4c84686c5549e650f8d" 0bbab97]:
 {{{
 #!CommitTicketReference repository=""
 revision="0bbab97c289ebcfd5676d4c84686c5549e650f8d"
 Refs #15250 -- Removed an obsolete comment regarding MTI cascade deletion.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.6bd14fd577b58c757304d3305f9a2b49%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #15250: Cannot fill parent model instance in cache

[Django]

#15250: Cannot fill parent model instance in cache
-+-
 Reporter:  vzima|Owner:  czpython
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"3e9f769fd1ae91f0accdfa5e3d8e6f4600517872" 3e9f769]:
 {{{
 #!CommitTicketReference repository=""
 revision="3e9f769fd1ae91f0accdfa5e3d8e6f4600517872"
 Refs #15250 -- Added docstring for ForwardOneToOneDescriptor.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.949c7a2ce8b88a7f46ed8ed3d2fb6be0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #15250: Cannot fill parent model instance in cache

[Django]

#15250: Cannot fill parent model instance in cache
-+-
 Reporter:  vzima|Owner:  czpython
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"38575b007a722d6af510ea46d46393a4cda9ca29" 38575b00]:
 {{{
 #!CommitTicketReference repository=""
 revision="38575b007a722d6af510ea46d46393a4cda9ca29"
 Fixed #15250 -- Avoided extra query on some multi-table inheritance
 queries.

 Thanks marekw2143 for the initial patch and carljm for support.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.6c9f89de1f2149504b67d44a04982703%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #15250: Cannot fill parent model instance in cache

[Django]

#15250: Cannot fill parent model instance in cache
-+-
 Reporter:  vzima|Owner:  czpython
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/6704 PR] with some comments for
 improvement.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.efb4ec21556ab4b39e35c81a70885529%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #15250: Cannot fill parent model instance in cache

[Django]

#15250: Cannot fill parent model instance in cache
-+-
 Reporter:  vzima|Owner:  czpython
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by czpython):

 * needs_tests:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.cc99161f569052604188c7d74ad55945%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #15250: Cannot fill parent model instance in cache

[Django]

#15250: Cannot fill parent model instance in cache
-+-
 Reporter:  vzima|Owner:  czpython
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by czpython):

 * owner:   => czpython
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.6590aa7c46dbafa0ed9f2308c1349074%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #15250: Cannot fill parent model instance in cache

[Django]

#15250: Cannot fill parent model instance in cache
-+-
 Reporter:  vzima|Owner:
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by timgraham):

 I closed #26523 as a duplicate (but it should be confirmed when solving
 this ticket).

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.7faa1e62913e13fab832d325ee62e206%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #15250: Cannot fill parent model instance in cache

[Django]

#15250: Cannot fill parent model instance in cache
-+-
 Reporter:  vzima|Owner:
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.2
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  1|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by marekw2143):

 * status:  assigned => new
 * owner:  marekw2143 =>
 * ui_ux:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15250: Cannot fill parent model instance in cache

[Django]

#15250: Cannot fill parent model instance in cache
-+-
   Reporter:  vzima  |  Owner:  marekw2143
   Type:  Bug| Status:  assigned
  Milestone: |  Component:  Database layer
Version:  1.2|  (models, ORM)
 Resolution: |   Severity:  Normal
   Triage Stage:  Accepted   |   Keywords:
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  0  |Needs tests:  1
 |  Easy pickings:  0
-+-
Changes (by aaugustin):

 * easy:   => 0


Comment:

 See #16043 for a similar bug that has a test case.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15250: Cannot fill parent model instance in cache

[Django]

#15250: Cannot fill parent model instance in cache
-+-
   Reporter:  vzima  |Owner:  marekw2143
   Type:  Bug|   Status:  assigned
  Milestone: |Component:  Database layer
Version:  1.2|  (models, ORM)
 Resolution: | Severity:  Normal
   Triage Stage:  Accepted   | Keywords:
Needs documentation:  0  |Has patch:  1
Patch needs improvement:  0  |  Needs tests:  1
-+-
Changes (by julien):

 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15250: Cannot fill parent model instance in cache

[Django]

#15250: Cannot fill parent model instance in cache
-+-
   Reporter:  vzima  |Owner:  marekw2143
 Status:  assigned   |Milestone:
  Component:  Database   |  Version:  1.2
  layer (models, ORM)| Keywords:
 Resolution: |Has patch:  1
   Triage Stage:  Accepted   |  Needs tests:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by marekw2143):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15250: Cannot fill parent model instance in cache

[Django]

#15250: Cannot fill parent model instance in cache
-+-
   Reporter:  vzima  |Owner:  marekw2143
 Status:  assigned   |Milestone:
  Component:  Database   |  Version:  1.2
  layer (models, ORM)| Keywords:
 Resolution: |Has patch:  0
   Triage Stage:  Accepted   |  Needs tests:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by marekw2143):

 * owner:  nobody => marekw2143
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15250: Cannot fill parent model instance in cache

[Django]

#15250: Cannot fill parent model instance in cache
+---
   Reporter:  vzima | Owner:  nobody
 Status:  new   | Milestone:
  Component:  Database layer (models, ORM)  |   Version:  1.2   
 Resolution:|  Keywords:
   Triage Stage:  Accepted  | Has patch:  0 
Needs documentation:  0 |   Needs tests:  0 
Patch needs improvement:  0 |  
+---
Changes (by russellm):

  * needs_better_patch:  => 0
  * needs_docs:  => 0
  * needs_tests:  => 0
  * stage:  Unreviewed => Accepted


Comment:

 Ok - thanks for the extra debug information. Looks like there is something
 going wrong here. As I indicated on #14371, the select_related() isn't
 necessary, but you've clearly shown that the parent object isn't being
 prepopulated as I said, either.

 As a matter of procedure -- this is the sort of situation where it would
 have been ok to reopen the old ticket. It's the same problem, but by
 providing more debugging information you can demonstrate that the
 assertion I made was wrong. If that's the case, its perfectly acceptable
 to reopen an old ticket.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #15250: Cannot fill parent model instance in cache

[Django]

#15250: Cannot fill parent model instance in cache
--+-
 Reporter:  vzima |  Owner:  nobody
   Status:  new   |  Milestone:
Component:  Database layer (models, ORM)  |Version:  1.2   
 Keywords:|   Triage Stage:  Unreviewed
Has patch:  0 |  
--+-
 Continue of #14371
 I tried again in django trunk (tested also in 1.2.4)

 I have following models (in SQLite3)
 {{{
 #!python
 class Parent(models.Model):
 parent_int = models.IntegerField()

 class Child(Parent):
 child_int = models.IntegerField()
 }}}

 {{{
 #!python
 In [1]: from django.db import connection

 In [2]: from testmodule.models import Parent, Child

 In [3]: Child.objects.create(parent_int = 1, child_int = 2)
 Out[3]: 

 In [4]: Child.objects.get(parent_int = 1, child_int = 2).parent_ptr
 Out[4]: 

 In [5]: connection.queries
 Out[5]:
 [{'sql': u'INSERT INTO "testmodule_parent" ("parent_int") VALUES (1)',
   'time': '0.001'},
  {'sql': u'INSERT INTO "testmodule_child" ("parent_ptr_id", "child_int")
 VALUES (2, 2)',
   'time': '0.000'},
  {'sql': u'SELECT "testmodule_parent"."id",
 "testmodule_parent"."parent_int", "testmodule_child"."parent_ptr_id",
 "testmodule_child"."child_int" FROM "testmodule_child" INNER JOIN
 "testmodule_parent" ON ("testmodule_child"."parent_ptr_id" =
 "testmodule_parent"."id") WHERE ("testmodule_parent"."parent_int" = 1  AND
 "testmodule_child"."child_int" = 2 )',
   'time': '0.000'},
  {'sql': u'SELECT "testmodule_parent"."id",
 "testmodule_parent"."parent_int" FROM "testmodule_parent" WHERE
 "testmodule_parent"."id" = 2 ',
   'time': '0.000'}]

 In [6]: Child.objects.select_related('parent').get(parent_int = 1,
 child_int = 2).parent_ptr
 Out[6]: 

 In [7]: connection.queries
 Out[7]:
 [{'sql': u'INSERT INTO "testmodule_parent" ("parent_int") VALUES (1)',
   'time': '0.001'},
  {'sql': u'INSERT INTO "testmodule_child" ("parent_ptr_id", "child_int")
 VALUES (2, 2)',
   'time': '0.000'},
  {'sql': u'SELECT "testmodule_parent"."id",
 "testmodule_parent"."parent_int", "testmodule_child"."parent_ptr_id",
 "testmodule_child"."child_int" FROM "testmodule_child" INNER JOIN
 "testmodule_parent" ON ("testmodule_child"."parent_ptr_id" =
 "testmodule_parent"."id") WHERE ("testmodule_parent"."parent_int" = 1  AND
 "testmodule_child"."child_int" = 2 )',
   'time': '0.000'},
  {'sql': u'SELECT "testmodule_parent"."id",
 "testmodule_parent"."parent_int" FROM "testmodule_parent" WHERE
 "testmodule_parent"."id" = 2 ',
   'time': '0.000'},
  {'sql': u'SELECT "testmodule_parent"."id",
 "testmodule_parent"."parent_int", "testmodule_child"."parent_ptr_id",
 "testmodule_child"."child_int" FROM "testmodule_child" INNER JOIN
 "testmodule_parent" ON ("testmodule_child"."parent_ptr_id" =
 "testmodule_parent"."id") WHERE ("testmodule_parent"."parent_int" = 1  AND
 "testmodule_child"."child_int" = 2 )',
   'time': '0.000'},
  {'sql': u'SELECT "testmodule_parent"."id",
 "testmodule_parent"."parent_int" FROM "testmodule_parent" WHERE
 "testmodule_parent"."id" = 2 ',
   'time': '0.000'}]
 }}}

 You can see that query is correct for selecting parent, but it's instance
 is not created in cache as usual and that leads to another select.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.