Re: [Django] #16021: Minor documentation fixes for Generic Class Views

[Django]

#16021: Minor documentation fixes for Generic Class Views
-+-
   Reporter:  Bradley|  Owner:  nobody
  Ayers | Status:  closed
   Type:  Bug|  Component:  Documentation
  Milestone: |   Severity:  Normal
Version:  1.3|   Keywords:
 Resolution:  fixed  |  Has patch:  1
   Triage Stage:  Ready for  |Needs tests:  0
  checkin|  Easy pickings:  1
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-

Comment (by julien):

 Whoops, sorry for the confusion. As I said originally, "model" should
 indeed *not* be capitalized.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16021: Minor documentation fixes for Generic Class Views

[Django]

#16021: Minor documentation fixes for Generic Class Views
-+-
   Reporter:  Bradley|  Owner:  nobody
  Ayers | Status:  closed
   Type:  Bug|  Component:  Documentation
  Milestone: |   Severity:  Normal
Version:  1.3|   Keywords:
 Resolution:  fixed  |  Has patch:  1
   Triage Stage:  Ready for  |Needs tests:  0
  checkin|  Easy pickings:  1
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-

Comment (by timo):

 In [16257]:
 {{{
 #!CommitTicketReference repository="" revision="16257"
 [1.3.X] Fixed #16021 - Minor documentation fixes for Generic Class Views;
 thanks Bradley Ayers.

 Backport of r16256 from trunk.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16021: Minor documentation fixes for Generic Class Views

[Django]

#16021: Minor documentation fixes for Generic Class Views
-+-
   Reporter:  Bradley|  Owner:  nobody
  Ayers | Status:  closed
   Type:  Bug|  Component:  Documentation
  Milestone: |   Severity:  Normal
Version:  1.3|   Keywords:
 Resolution:  fixed  |  Has patch:  1
   Triage Stage:  Ready for  |Needs tests:  0
  checkin|  Easy pickings:  1
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by timo):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [16256]:
 {{{
 #!CommitTicketReference repository="" revision="16256"
 Fixed #16021 - Minor documentation fixes for Generic Class Views; thanks
 Bradley Ayers.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16021: Minor documentation fixes for Generic Class Views

[Django]

#16021: Minor documentation fixes for Generic Class Views
-+-
   Reporter:  Bradley|  Owner:  nobody
  Ayers | Status:  new
   Type:  Bug|  Component:  Documentation
  Milestone: |   Severity:  Normal
Version:  1.3|   Keywords:
 Resolution: |  Has patch:  1
   Triage Stage:  Ready for  |Needs tests:  0
  checkin|  Easy pickings:  1
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by julien):

 * stage:  Accepted => Ready for checkin


Comment:

 Thanks a lot. The patch looks good. I've just capitalized the word "Model"
 ;-)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16021: Minor documentation fixes for Generic Class Views

[Django]

#16021: Minor documentation fixes for Generic Class Views
-+-
   Reporter:  Bradley|  Owner:  nobody
  Ayers | Status:  new
   Type:  Bug|  Component:  Documentation
  Milestone: |   Severity:  Normal
Version:  1.3|   Keywords:
 Resolution: |  Has patch:  1
   Triage Stage:  Accepted   |Needs tests:  0
Needs documentation:  0  |  Easy pickings:  1
Patch needs improvement:  0  |
-+-

Comment (by bradley.ayers@…):

 Thanks I'll fix up the patch with regard to the model capitalization. The
 reason why I swapped the order of the Meta and unicode method is due to
 Django's style guide
 http://docs.djangoproject.com/en/1.3/internals/contributing/#model-style.
 There's a list of of the order that the methods should be defined in
 around the third bullet point in that section.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16021: Minor documentation fixes for Generic Class Views

[Django]

#16021: Minor documentation fixes for Generic Class Views
-+-
   Reporter:  Bradley|  Owner:  nobody
  Ayers | Status:  new
   Type:  Bug|  Component:  Documentation
  Milestone: |   Severity:  Normal
Version:  1.3|   Keywords:
 Resolution: |  Has patch:  1
   Triage Stage:  Accepted   |Needs tests:  0
Needs documentation:  0  |  Easy pickings:  1
Patch needs improvement:  0  |
-+-
Changes (by julien):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 Thank you for this. The patch looks mostly fine. Just a couple of points:
 the word "model" should not be capitalised; also there are no reasons why
 the `Meta` class should be moved above the `__unicode__` method.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #16021: Minor documentation fixes for Generic Class Views

[Django]

#16021: Minor documentation fixes for Generic Class Views
-+-
 Reporter:  Bradley Ayers   |  Owner:  nobody
 Type:  Bug  | Status:  new
Milestone:   |  Component:
  Version:  1.3  |  Documentation
 Keywords:   |   Severity:  Normal
Has patch:  1|   Triage Stage:  Unreviewed
 |  Easy pickings:  1
-+-
 I noticed some minor styling problems, and one explicit error in the
 documentation for Generic Class Views.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.