Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+
 Reporter:  rasca  |Owner:  rasca
 Type:  New feature|   Status:  new
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by auvipy):

 * status:  closed => new
 * resolution:  wontfix =>


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.d57d0eda07795f85576b63f3d6e8371e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+
 Reporter:  rasca  |Owner:  auvipy
 Type:  New feature|   Status:  closed
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:  wontfix
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by timgraham):

 * status:  assigned => closed
 * resolution:   => wontfix


Comment:

 You may reopen a ticket after there is consensus to do so on the
 DevelopersMailingList. Thanks.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.71386f57fffe02963546ffc7b66507d9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+
 Reporter:  rasca  |Owner:  auvipy
 Type:  New feature|   Status:  assigned
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by auvipy):

 considering this ticket as a part of gsoc proposal. so reopening. django-
 extra-views and django-vanila-views are great and their philosophy should
 be implemented in django contrib apps/ django proper.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.b185d1063dadc0ab32f880738373f1ae%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+
 Reporter:  rasca  |Owner:  auvipy
 Type:  New feature|   Status:  assigned
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by auvipy):

 * status:  new => assigned
 * owner:  rasca => auvipy


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.310e1ced3856a5d804d4f69e850cea02%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+
 Reporter:  rasca  |Owner:  rasca
 Type:  New feature|   Status:  closed
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:  wontfix
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by tomchristie):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 There's really no reason we shouldn't be pushing for additional class
 based generic views to be implemented as third party packages.

 See 'Django Extra Views' or 'Django Vanilla Views' as examples of these.

 * https://github.com/AndrewIngram/django-extra-views
 * https://github.com/tomchristie/django-vanilla-views

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.3215d438c95a343accbefaf53cc04cf3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+
 Reporter:  rasca  |Owner:  rasca
 Type:  New feature|   Status:  new
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Fabio Caritas Barrionuevo da Luz ):

 What is the status of this?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.2056ae2f77dd84c44815e0a2c6001921%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+
 Reporter:  rasca  |Owner:  rasca
 Type:  New feature|   Status:  new
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by ville@…):

 * cc: ville@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.48bf0496142e64c0f6cc6ec28c4e8f94%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+
 Reporter:  rasca  |Owner:  rasca
 Type:  New feature|   Status:  new
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by dpwrussell):

 * cc: dpwrussell (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.f6f82b13314dd90cb2043453830c0957%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+
 Reporter:  rasca  |Owner:  rasca
 Type:  New feature|   Status:  new
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by MarkusH):

 * cc: MarkusH (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+
 Reporter:  rasca  |Owner:  rasca
 Type:  New feature|   Status:  new
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by hanne.moa@…):

 * cc: hanne.moa@… (added)
 * version:  1.3 => master


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+
 Reporter:  rasca  |Owner:  rasca
 Type:  New feature|   Status:  new
Component:  Generic views  |  Version:  1.3
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by charettes):

 * cc: charette.s@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+
 Reporter:  rasca  |Owner:  rasca
 Type:  New feature|   Status:  new
Component:  Generic views  |  Version:  1.3
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by treyhunner):

 * cc: treyhunner (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+
 Reporter:  rasca  |Owner:  rasca
 Type:  New feature|   Status:  new
Component:  Generic views  |  Version:  1.3
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by gerdemb):

 * cc: gerdemb (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+
 Reporter:  rasca  |Owner:  rasca
 Type:  New feature|   Status:  new
Component:  Generic views  |  Version:  1.3
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by rh0dium):

 * cc: rh0dium (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+
 Reporter:  rasca  |Owner:  rasca
 Type:  New feature|   Status:  new
Component:  Generic views  |  Version:  1.3
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by emyller):

 * cc: emyller@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+
 Reporter:  rasca  |Owner:  rasca
 Type:  New feature|   Status:  new
Component:  Generic views  |  Version:  1.3
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by darkpixel):

 * cc: aaron@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+
 Reporter:  rasca  |Owner:  rasca
 Type:  New feature|   Status:  new
Component:  Generic views  |  Version:  1.3
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by GotenXiao):

 * cc: GotenXiao (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+
 Reporter:  rasca  |Owner:  rasca
 Type:  New feature|   Status:  new
Component:  Generic views  |  Version:  1.3
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by zuko):

 * cc: anton@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+
 Reporter:  rasca  |Owner:  rasca
 Type:  New feature|   Status:  new
Component:  Generic views  |  Version:  1.3
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by MichaelA):

 If one (or more) of the core devs could give me some direction, I'd be
 happy to create an updated patch based on rasca's patch. The comments
 above leave more ambiguity than I feel comfortable dealing with on my own.

 This feature alone, for those developing their own custom admin
 interfaces, could be the most excellent advancement in Django since
 newforms (IMHO).


 Thanks
 Michael

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+
 Reporter:  rasca  |Owner:  rasca
 Type:  New feature|   Status:  new
Component:  Generic views  |  Version:  1.3
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by victorhooi):

 heya,

 Curious - is there any word on this ticket?

 I'm guessing it's not going to hit 1.4, but any word when it might hit
 trunk? Would love to try this out for a project I'm working on =).

 Cheers,
 Victor

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+---
   Reporter:  rasca|  Owner:  rasca
   Type:  New feature  | Status:  new
  Milestone:  1.4  |  Component:  Generic views
Version:  1.3  |   Severity:  Normal
 Resolution:   |   Keywords:
   Triage Stage:  Accepted |  Has patch:  1
Needs documentation:  1|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+---

Comment (by kd4ttc):

 See ticket 16418. The addition of a generic view for another object type
 should just be done by Subclassing the generic view and then redefining
 get_object() to return the  new object. The ticket 16418 points out a
 small bug in the approach, but a simple workaround is available until it
 gets fixed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+---
   Reporter:  rasca|  Owner:  rasca
   Type:  New feature  | Status:  new
  Milestone:  1.4  |  Component:  Generic views
Version:  1.3  |   Severity:  Normal
 Resolution:   |   Keywords:
   Triage Stage:  Accepted |  Has patch:  1
Needs documentation:  1|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+---

Comment (by jezdez):

 I agree with !AndrewIngram's plan for staying close to the already
 existing form related mixins and I believe rasca's approach is basically
 trying to do the impossible (porting admin) to early in the API design.

 So let's step back a bit and first implement the formset related views and
 then see what glue code or concept is needed to help concrete
 implementations like the admin to use the new API. We shouldn't carry
 around potentially bad API decisions in the admin into the generic views
 just to get it done quicker.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+---
   Reporter:  rasca|  Owner:  rasca
   Type:  New feature  | Status:  new
  Milestone:  1.4  |  Component:  Generic views
Version:  1.3  |   Severity:  Normal
 Resolution:   |   Keywords:
   Triage Stage:  Accepted |  Has patch:  1
Needs documentation:  1|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+---

Comment (by rasca):

 I do think the splitting of the view into a Create and a Update views is
 more like the other generic cbv views, although I end up joining them most
 of the times, but that's another issue.

 I still need a little more time to think about making views for 1 inline
 and for N inlines different. That way you end up having a formset_valid()
 in InlineFormSet which doesn't get used and might confuse people, for
 example.

 Anyone care to weight in on this?

 Being the logic the same in both implementations we might argue that the
 probability of it being correct is somewhat high =)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+---
   Reporter:  rasca|  Owner:  rasca
   Type:  New feature  | Status:  new
  Milestone:  1.4  |  Component:  Generic views
Version:  1.3  |   Severity:  Normal
 Resolution:   |   Keywords:
   Triage Stage:  Accepted |  Has patch:  1
Needs documentation:  1|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+---

Comment (by AndrewIngram):

 I had a go at my own implementation of what you've done with regards to
 editing inline formsets alongside a model (but I didn't touch the admin
 itself), the logic is nearly identical to your solution (largely
 coincidence, but I did borrow ideas for naming conventions), but I've done
 my best to mimic the structure of Django's existing class-based views for
 editing objects. The two new concrete views are:

 - CreateWithInlinesView
 - UpdateWithInlinesView

 Each can take an inlines attribute which is a list of classes that extend
 InlineFormSet (which itself is just a bit of trickery around my
 InlineFormSetMixin which is used for the much simpler InlineFormSetView).

 Code is here: https://github.com/AndrewIngram/django-extra-
 views/blob/master/extra_views/advanced.py

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+---
   Reporter:  rasca|  Owner:  rasca
   Type:  New feature  | Status:  new
  Milestone:  1.4  |  Component:  Generic views
Version:  1.3  |   Severity:  Normal
 Resolution:   |   Keywords:
   Triage Stage:  Accepted |  Has patch:  1
Needs documentation:  1|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+---

Comment (by rasca):

 Hi Andrew, my EnhancedFormSet et al resembles the admin's InlineAdmin,
 where we can set some things needed to instantiate the formset. For
 example, you've put {{{extra}}} and {{{can_order}}} inside the Mixin
 class, but we need to have a different set of parameters for each formset,
 so I made another class encapsulating this parameters.

 I don't like the naming though.

 About splitting everything in steps... I'm not sure about it. An
 implementation of inlineformsets that doesn't allow more than one inline
 doesn't make much sense IMO. I might bring this up in django-developers,
 gonna try #django-dev first.

 But surely, another ticket for multiple Forms or ModelForms would be
 great! I think they will be fairly easy to build from what we have so far.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+---
   Reporter:  rasca|  Owner:  rasca
   Type:  New feature  | Status:  new
  Milestone:  1.4  |  Component:  Generic views
Version:  1.3  |   Severity:  Normal
 Resolution:   |   Keywords:
   Triage Stage:  Accepted |  Has patch:  1
Needs documentation:  1|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+---

Comment (by AndrewIngram):

 I think you may have introduced too much in one go, I think this can all
 be broken down into discrete things that need to be built. The way I see
 it is like this (I haven't achieved all of this with my own implementation
 yet):

 1. FormSetView and ModelFormSet view should mimic FormView and
 ModelFormView as closely as possible. In the same way that ModelFormMixin
 extends FormMixin and SingleObjectMixin, ModelFormSetView should extend
 FormSetMixin and MultipleObjectMixin, this way we get stuff like
 pagination for free (I haven't done this yet, but it was part of the
 plan).
 2. For InlineFormSetView, I think we need to respect the API for
 inline_formsets, ie it just simplifies building these formsets. Your
 implementation of this view includes the form for the owner model, which I
 think is too much functionality, it's part of the bigger problem of
 finding a mechanism to combine various forms and formsets into a single
 view.
 3. Once we have established the functionality for creating views with
 single formsets, we can start looking at ways to bridge the gap between
 (for example) the needs of the admin and the basic formset views.

 I must confess that I've not got my head around all of what you've done.
 What is the purpose of the EnhancedFormset objects you've introduced?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+---
   Reporter:  rasca|  Owner:  rasca
   Type:  New feature  | Status:  new
  Milestone:  1.4  |  Component:  Generic views
Version:  1.3  |   Severity:  Normal
 Resolution:   |   Keywords:
   Triage Stage:  Accepted |  Has patch:  1
Needs documentation:  1|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+---

Comment (by rasca):

 I've just made InlineAdmin a subclass of EnhancedInlineFormSet and all
 tests pass! Maybe the first approach on refactoring the admin with generic
 cbv?

 One naming discrepancy I found was that I use {{{formset_class}}} and
 {{{form_class}}} and the admin uses {{{formset}}} and {{{form}}}. I fixed
 this by overriding get_formset_class and get_form_class.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+---
   Reporter:  rasca|  Owner:  rasca
   Type:  New feature  | Status:  new
  Milestone:  1.4  |  Component:  Generic views
Version:  1.3  |   Severity:  Normal
 Resolution:   |   Keywords:
   Triage Stage:  Accepted |  Has patch:  1
Needs documentation:  1|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+---

Comment (by rasca):

 Replying to [comment:8 AndrewIngram]:
 > With regards to handling multiple formsets in one view, I'd treat that
 as a separate problem. Ideally you'd want a single view that can handle
 forms *and* formsets. I've already attempted this (you can see it in the
 github repo mentioned in #16215, it's called MultiFormView)

 Yeah.. my main goal was to replicate the admin's inlines. We could create
 another ticket for the 'MutiFormView'...


 > but I struggled with creating a decent API that made it easy to
 instantiate forms and formsets that have custom init arguments and so on.

 What do you think about what I came up with?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+---
   Reporter:  rasca|  Owner:  rasca
   Type:  New feature  | Status:  new
  Milestone:  1.4  |  Component:  Generic views
Version:  1.3  |   Severity:  Normal
 Resolution:   |   Keywords:
   Triage Stage:  Accepted |  Has patch:  1
Needs documentation:  1|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+---

Comment (by AndrewIngram):

 With regards to handling multiple formsets in one view, I'd treat that as
 a separate problem. Ideally you'd want a single view that can handle forms
 *and* formsets. I've already attempted this (you can see it in the github
 repo mentioned in #16215, it's called MultiFormView), but I struggled with
 creating a decent API that made it easy to instantiate forms and formsets
 that have custom init arguments and so on.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+---
   Reporter:  rasca|  Owner:  rasca
   Type:  New feature  | Status:  new
  Milestone:  1.4  |  Component:  Generic views
Version:  1.3  |   Severity:  Normal
 Resolution:   |   Keywords:
   Triage Stage:  Accepted |  Has patch:  1
Needs documentation:  1|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+---

Comment (by rasca):

 Just for posterity, the 's' in FormSetsView et al was due to supporting
 multiple formsets in the same view. I can change it back if you like.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+---
   Reporter:  rasca|  Owner:  rasca
   Type:  New feature  | Status:  new
  Milestone:  1.4  |  Component:  Generic views
Version:  1.3  |   Severity:  Normal
 Resolution:   |   Keywords:
   Triage Stage:  Accepted |  Has patch:  1
Needs documentation:  1|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+---

Comment (by rasca):

 I have just closed #16215 in favor of this one. We should review the code
 in #16215 to look at what he may have done better in terms of API.

 The idea is to keep it as close as possible to the forms API.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+---
   Reporter:  rasca|  Owner:  rasca
   Type:  New feature  | Status:  new
  Milestone:  1.4  |  Component:  Generic views
Version:  1.3  |   Severity:  Normal
 Resolution:   |   Keywords:
   Triage Stage:  Accepted |  Has patch:  1
Needs documentation:  1|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+---
Changes (by rasca):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+---
   Reporter:  rasca|  Owner:  rasca
   Type:  New feature  | Status:  new
  Milestone:  1.4  |  Component:  Generic views
Version:  1.3  |   Severity:  Normal
 Resolution:   |   Keywords:
   Triage Stage:  Accepted |  Has patch:  1
Needs documentation:  1|Needs tests:  0
Patch needs improvement:  1|  Easy pickings:  0
  UI/UX:  0|
---+---
Changes (by jezdez):

 * needs_better_patch:  0 => 1


Comment:

 Agreed, using "FormSet" in the name is better.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16256: More class based views: formsets derived generic views

[Django]

#16256: More class based views: formsets derived generic views
---+---
   Reporter:  rasca|  Owner:  rasca
   Type:  New feature  | Status:  new
  Milestone:  1.4  |  Component:  Generic views
Version:  1.3  |   Severity:  Normal
 Resolution:   |   Keywords:
   Triage Stage:  Accepted |  Has patch:  1
Needs documentation:  1|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+---

Comment (by anonymous):

 Why your views are called FormSetsView, ModelFormSetsView and
 InlineFormSetsView, but not FormSetView, ModelFormSetView and
 InlineFormSetView?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16256: More class based views: formsets derived generic views (was: More class based views)

[Django]

#16256: More class based views: formsets derived generic views
---+---
   Reporter:  rasca|  Owner:  rasca
   Type:  New feature  | Status:  new
  Milestone:  1.4  |  Component:  Generic views
Version:  1.3  |   Severity:  Normal
 Resolution:   |   Keywords:
   Triage Stage:  Accepted |  Has patch:  1
Needs documentation:  1|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+---

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.