Re: [Django] #19508: Implement URL decoding according to RFC 3987

[Django]

#19508: Implement URL decoding according to RFC 3987
-+-
 Reporter:  aaugustin|Owner:  loic
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  master
Component:  HTTP handling|   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Loic Bistuer ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"10b17a22bec2eaf44c3315614aea87c127caee46"]:
 {{{
 #!CommitTicketReference repository=""
 revision="10b17a22bec2eaf44c3315614aea87c127caee46"
 Fixed #19508 -- Implemented uri_to_iri as per RFC.

 Thanks Loic Bistuer for helping in shaping the patch and Claude Paroz
 for the review.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.2141e681074b1ae917c4c7f2269603a7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19508: Implement URL decoding according to RFC 3987

[Django]

#19508: Implement URL decoding according to RFC 3987
-+-
 Reporter:  aaugustin|Owner:  loic
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  HTTP handling|   Resolution:
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by claudep):

 * stage:  Accepted => Ready for checkin


Comment:

 Looks good, thanks!

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.2e79a34c046e0d207ab4c4f2917e2ca1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19508: Implement URL decoding according to RFC 3987

[Django]

#19508: Implement URL decoding according to RFC 3987
--+
 Reporter:  aaugustin |Owner:  loic
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  HTTP handling |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by loic):

 I reworked the implementation of the "repercent" step. Anyone experienced
 with unicode to double check?

 I still want to review our usage of the various quote/unquote functions
 and their respective quirks in term of input/return values (and their
 discrepancies between PY2 and PY3).

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.44efccfdd9ea2db7d43476123d5425c9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19508: Implement URL decoding according to RFC 3987

[Django]

#19508: Implement URL decoding according to RFC 3987
--+
 Reporter:  aaugustin |Owner:  loic
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  HTTP handling |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by loic):

 * owner:  anubhav9042 => loic


Comment:

 This ticket was recently mentioned in a ML thread:
 https://groups.google.com/d/topic/django-developers/mS9-HXI4ljw/discussion

 I amended the patch from Anubhav to make `uri_to_iri()` return unicode
 rather than UTF-8 (Option 2 in PR comment
 https://github.com/django/django/pull/2932/files#r15440287). This is
 consistent with Werkzeug's implementation (Refs
 http://werkzeug.pocoo.org/docs/0.9/utils/#werkzeug.urls.uri_to_iri)


 Made a new PR - https://github.com/django/django/pull/3350 - feedback
 welcome.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.38ae0616b976b626fbdf059972bfed14%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19508: Implement URL decoding according to RFC 3987

[Django]

#19508: Implement URL decoding according to RFC 3987
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  anubhav9042
  Cleanup/optimization   |   Status:  assigned
Component:  HTTP handling|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by timgraham):

 [https://github.com/django/django/pull/2932 Alternate PR] from Anubhav.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.671a9e560f545207b87ff4c39cb7c1d4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19508: Implement URL decoding according to RFC 3987

[Django]

#19508: Implement URL decoding according to RFC 3987
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  anubhav9042
  Cleanup/optimization   |   Status:  assigned
Component:  HTTP handling|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by anubhav9042):

 * has_patch:  0 => 1


Comment:

 https://github.com/django/django/pull/2919

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.3ceaf427fc5c0636bc8f52fd99e4166b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19508: Implement URL decoding according to RFC 3987

[Django]

#19508: Implement URL decoding according to RFC 3987
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  anubhav9042
  Cleanup/optimization   |   Status:  assigned
Component:  HTTP handling|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by anubhav9042):

 Loic and I had a discussion on this today.
 Few things worth mentioning:

 - When having urls like `/test/~%A9`, we get `400` when project is
 deployed as `WSGIHandler` has fallback for `400` in case of
 `UnicodeDecodeError`.
 - In development we get `500` because `StaticFilesHandler` is used and it
 does not have that fallback.
 - It cannot be reproduced in tests because the `ClientHandler` again
 raises `UnicodeDecodeError` in `get_path_info()`.
 - The problem arises when in
 [https://github.com/django/django/blob/master/django/core/handlers/wsgi.py#L210
 get_path_info()], we decode the url in `utf-8`.
 - When we pass a url, it passes through `unquote()` in `urllib` where it
 converts all percent encodings, even those which should remain url-
 encoded.

 I am working on this now and will report again soon.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.fe7d5912b6340fe86680bd81ab11963c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19508: Implement URL decoding according to RFC 3987

[Django]

#19508: Implement URL decoding according to RFC 3987
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  anubhav9042
  Cleanup/optimization   |   Status:  assigned
Component:  HTTP handling|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by anubhav9042):

 * owner:  nobody => anubhav9042
 * status:  new => assigned


Comment:

 Will be working on this in my GSoC project

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e5ccd1f53e103dc5e616e03194de0c36%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19508: Implement URL decoding according to RFC 3987

[Django]

#19508: Implement URL decoding according to RFC 3987
--+
 Reporter:  aaugustin |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  HTTP handling |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by anubhav9042):

 * cc: anubhav9042@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.5c2b58cad80da26ce786238c81e96416%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19508: Implement URL decoding according to RFC 3987

[Django]

#19508: Implement URL decoding according to RFC 3987
--+
 Reporter:  aaugustin |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  HTTP handling |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by anubhav9042):

 I am thinking to work on this.
 I have some idea of what to do, by visiting the links provided in the
 summary.

 Can anyone give me some ideas to begin with...??

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7af94fd0b3ade896492a2cfeb467785e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19508: Implement URL decoding according to RFC 3987

[Django]

#19508: Implement URL decoding according to RFC 3987
--+
 Reporter:  aaugustin |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  HTTP handling |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by claudep):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #19508: Implement URL decoding according to RFC 3987

[Django]

#19508: Implement URL decoding according to RFC 3987
+
   Reporter:  aaugustin |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  HTTP handling |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 Since #5738, when Django fails to decode an URL because it isn't valid
 UTF-8, it returns a HTTP 400 error with no content.

 It's a bit sloppy to use a protocol-level message for an application-level
 requirement — in other words, to reply to a well-formed HTTP request with
 400 Bad Request. [http://tools.ietf.org/html/rfc3987#section-3.2 Section
 3.2 of RFC 3987] proposes a solution to this problem. Basically, non-ASCII
 bytes that do not create a valid utf-8 sequence should remain URL-encoded.
 This may not be trivial to implement, but it provide better error handling
 and it's normalized.

 With this change, non-existing but well-formed URLs will return a 404
 instead of a 400. That's what people expect, as shown in the comments of
 #5738 and #16541.

 Django builds URLs according to
 [http://tools.ietf.org/html/rfc3987#section-3.1 section 3.1 of RFC 3987].
 With this change, URLs will round trip cleanly through the reversing /
 resolving (that's one of the guarantees of RFC 3987) and Django will be
 able to deal with legacy, non-utf-8 URLs. I pursued these goals in #19468
 with a more primitive technique (depending only on the encoding) and that
 didn't work out.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.