Re: [Django] #21422: prefetch_related does not document restriction of requiring homogeneous results

[Django]

#21422: prefetch_related does not document restriction of requiring homogeneous
results
-+-
 Reporter:  pab@…|Owner:  Tim
 Type:   |  Graham 
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"683b3dff7b8f02e5d5a67e678698f420cbd018e9" 683b3df]:
 {{{
 #!CommitTicketReference repository=""
 revision="683b3dff7b8f02e5d5a67e678698f420cbd018e9"
 [1.8.x] Fixed #21422 -- Documented that prefetch_related() results must be
 homogeneous.

 Backport of 69239c0f968ee55cb9ca1e31323fb696db0c2aec from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/080.faa37cd528033a3908f9c69069613bf0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21422: prefetch_related does not document restriction of requiring homogeneous results

[Django]

#21422: prefetch_related does not document restriction of requiring homogeneous
results
-+-
 Reporter:  pab@…|Owner:  Tim
 Type:   |  Graham 
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"31a51a04e899f1fa7fa77be38e3484074d930369" 31a51a04]:
 {{{
 #!CommitTicketReference repository=""
 revision="31a51a04e899f1fa7fa77be38e3484074d930369"
 [1.9.x] Fixed #21422 -- Documented that prefetch_related() results must be
 homogeneous.

 Backport of 69239c0f968ee55cb9ca1e31323fb696db0c2aec from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/080.2dccb14ccf3e76ad4bf97daeab332400%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21422: prefetch_related does not document restriction of requiring homogeneous results

[Django]

#21422: prefetch_related does not document restriction of requiring homogeneous
results
-+-
 Reporter:  pab@…|Owner:  Tim
 Type:   |  Graham 
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * owner:   => Tim Graham 
 * resolution:   => fixed


Comment:

 In [changeset:"69239c0f968ee55cb9ca1e31323fb696db0c2aec" 69239c0f]:
 {{{
 #!CommitTicketReference repository=""
 revision="69239c0f968ee55cb9ca1e31323fb696db0c2aec"
 Fixed #21422 -- Documented that prefetch_related() results must be
 homogeneous.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/080.24e4479ee9024779f476a1088a46%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21422: prefetch_related does not document restriction of requiring homogeneous results (was: prefetch_related does not document restriction)

[Django]

#21422: prefetch_related does not document restriction of requiring homogeneous
results
-+-
 Reporter:  pab@…|Owner:
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/080.b7473ebd429e923683323ea1b7503f2c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21422: prefetch_related does not document restriction

[Django]

#21422: prefetch_related does not document restriction
-+-
 Reporter:  pab@…|Owner:
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by claudep):

 * owner:  donaldharvey =>
 * status:  assigned => new
 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/080.7bb53dc773fce1119bd219b8893f8ce6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21422: prefetch_related does not document restriction

[Django]

#21422: prefetch_related does not document restriction
-+-
 Reporter:  pab@…|Owner:
 Type:   |  donaldharvey
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/5512 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/080.5bd60422f973406490257d3a68979eb7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21422: prefetch_related does not document restriction

[Django]

#21422: prefetch_related does not document restriction
-+-
 Reporter:  pab@…|Owner:
 Type:   |  donaldharvey
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by donaldharvey):

 * status:  new => assigned
 * owner:  nobody => donaldharvey
 * version:  1.6 => master
 * easy:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/080.213b3c6d6abc979dbeea2c5817fe80a3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21422: prefetch_related does not document restriction

[Django]

#21422: prefetch_related does not document restriction
--+
 Reporter:  pab@… |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  1.6
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by ubernostrum):

 * easy:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/080.5c44a8ac2f2bf2220b016ba7f5ab60b6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21422: prefetch_related does not document restriction

[Django]

#21422: prefetch_related does not document restriction
--+
 Reporter:  pab@… |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  1.6
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by loic84):

 * cc: loic@… (added)
 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 I can confirm that the implementation relies on the assumption that all
 the retrieved objects are homogenous.

 This limitation should be documented.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/080.3ea737b680917646a68fd7df118770c6%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21422: prefetch_related does not document restriction

[Django]

#21422: prefetch_related does not document restriction
--+
 Reporter:  pab@… |  Owner:  nobody
 Type:  Cleanup/optimization  | Status:  new
Component:  Documentation |Version:  1.6
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 I have just been trying to track down a performance issue in my
 application using Django 1.6.  The solution was to use prefetch_related(),
 bit it didn't quite work as expected.  The documentation was great as far
 as it went and so I found the necessary function with little fuss - well
 done!  However it didn't warn me that prefetch_related() must be
 restricted to a homogenous set of results.

 In particular, I had query that needed to fetch data for objects found
 through a GenericForeignKey and then a ManyToManyField.  While the pre-
 fetch claimed it had worked, it only actually queried the ManyToManyField
 results for the first matching ContentType of the GenericForeignKey.
 Looking at the code, this is a deliberate design decision, but it is not
 documented anywhere I could see.

 I understand why this restriction is in place and so am not asking for a
 feature enhancement.  Instead, I think the documentation for this function
 needs to make clear that pre-fetching objects referenced by
 GenericForeignKeys is only supported if the query has restricted the key
 to one ContentType.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.6a349d2d1b1b0ad87ba5b08ecd3042ee%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.