Re: [Django] #23448: Update ISO_INPUT_FORMATS to allow date filtering for ISO8601 dates

[Django]

#23448: Update ISO_INPUT_FORMATS to allow date filtering for ISO8601 dates
-+-
 Reporter:  jaegerpicker |Owner:
 |  jaegerpicker
 Type:  New feature  |   Status:  closed
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:  datetime,| Triage Stage:  Accepted
  isoformat, ISO8601 |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * status:  assigned => closed
 * resolution:   => duplicate


Comment:

 Seems to be closely related to or a duplicate of #11385 and #25189. I
 think we need a discussion on the DevelopersMailingList if we are to make
 any changes here.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.d0145c41902f96906dae5474597927db%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23448: Update ISO_INPUT_FORMATS to allow date filtering for ISO8601 dates

[Django]

#23448: Update ISO_INPUT_FORMATS to allow date filtering for ISO8601 dates
-+-
 Reporter:  jaegerpicker |Owner:
 Type:  New feature  |  jaegerpicker
Component:  Utilities|   Status:  assigned
 Severity:  Normal   |  Version:  master
 Keywords:  datetime,|   Resolution:
  isoformat, ISO8601 | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by jaegerpicker):

 * owner:  jpadilla => jaegerpicker


Comment:

 I'd be glad to take this on, can't promise how soon I'll get to it though.
 It's entering our busiest part of the year at work. I'll try to work on it
 asap.


 Replying to [comment:8 jpadilla]:
 > Replying to [comment:6 jaegerpicker]:
 >
 > Since this was originally an issue you were working on, and apparently
 needs a bit more work after my PR, which I don't fully understand, would
 you want to pick this up again or should we just close it for now?
 >
 > > Sorry, I got swallowed by work and family commitments and wasn't able
 to come back and update the PR based upon feedback. Thanks @jpadilla for
 updating this.
 > >
 > > ISO_INPUT_FORMATS isn't referenced directly in either django-filter
 nor django-rest-framework. The chain goes like this:
 > > - DRF references DF.filterset (line 191 in my local django-filter)
 > >  - DF.filter.DateTimeFilter which references
 django.forms.fields.DateTimeFleld (on line 120 in filters.py in django-
 filters) which calls
 > > - django.formats.get_format_lazy('DATETIME_INPUT_FORMATS')
 which returns a list of all the setup datetime formats to try and parse
 the incoming string against using strptime
 > >- This is on line 490 in the django.forms.fields.py file.
 get_format_lazy calls get_format which references ISO_INPUT_FORMATS.
 > >
 > > That's why updating the ISO_INPUT_FORMATS dict fixes the DRF issue for
 most/some cases. I had overlooked the timezone issue with ISO8601
 apparently.  Maybe we should also update the BaseTemporalField
 (DateTimeFields super class) to use the django.utils.dateparse instead of
 strptime?
 > >
 > > That seems like a larger change than the original but seems like the
 correct answer to me.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.f1b36059fd2bfe6931cdee4365d23468%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23448: Update ISO_INPUT_FORMATS to allow date filtering for ISO8601 dates

[Django]

#23448: Update ISO_INPUT_FORMATS to allow date filtering for ISO8601 dates
-+-
 Reporter:  jaegerpicker |Owner:  jpadilla
 Type:  New feature  |   Status:  assigned
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  datetime,| Triage Stage:  Accepted
  isoformat, ISO8601 |  Needs documentation:  1
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by jpadilla):

 Replying to [comment:6 jaegerpicker]:

 Since this was originally an issue you were working on, and apparently
 needs a bit more work after my PR, which I don't fully understand, would
 you want to pick this up again or should we just close it for now?

 > Sorry, I got swallowed by work and family commitments and wasn't able to
 come back and update the PR based upon feedback. Thanks @jpadilla for
 updating this.
 >
 > ISO_INPUT_FORMATS isn't referenced directly in either django-filter nor
 django-rest-framework. The chain goes like this:
 > - DRF references DF.filterset (line 191 in my local django-filter)
 >  - DF.filter.DateTimeFilter which references
 django.forms.fields.DateTimeFleld (on line 120 in filters.py in django-
 filters) which calls
 > - django.formats.get_format_lazy('DATETIME_INPUT_FORMATS') which
 returns a list of all the setup datetime formats to try and parse the
 incoming string against using strptime
 >- This is on line 490 in the django.forms.fields.py file.
 get_format_lazy calls get_format which references ISO_INPUT_FORMATS.
 >
 > That's why updating the ISO_INPUT_FORMATS dict fixes the DRF issue for
 most/some cases. I had overlooked the timezone issue with ISO8601
 apparently.  Maybe we should also update the BaseTemporalField
 (DateTimeFields super class) to use the django.utils.dateparse instead of
 strptime?
 >
 > That seems like a larger change than the original but seems like the
 correct answer to me.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.3c04e4ee3b1eef35b3986b211ed0a280%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23448: Update ISO_INPUT_FORMATS to allow date filtering for ISO8601 dates

[Django]

#23448: Update ISO_INPUT_FORMATS to allow date filtering for ISO8601 dates
-+-
 Reporter:  jaegerpicker |Owner:  jpadilla
 Type:  New feature  |   Status:  assigned
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  datetime,| Triage Stage:  Accepted
  isoformat, ISO8601 |  Needs documentation:  1
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by tomchristie):

 > to use the django.utils.dateparse instead of strptime?

 I guess what's awkward about that is that it's then not obvious how to
 also support the input formats list.

 For reference, in REST framework we have a special format string 'ISO8601'
 that uses `dateparse`, and any other format strings use `strftime` I've no
 idea if that'd also make sense for Django or not.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.c1711acc746c3f7c2ff32d3d5cf9b15b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23448: Update ISO_INPUT_FORMATS to allow date filtering for ISO8601 dates

[Django]

#23448: Update ISO_INPUT_FORMATS to allow date filtering for ISO8601 dates
-+-
 Reporter:  jaegerpicker |Owner:  jpadilla
 Type:  New feature  |   Status:  assigned
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  datetime,| Triage Stage:  Accepted
  isoformat, ISO8601 |  Needs documentation:  1
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by jaegerpicker):

 Sorry, I got swallowed by work and family commitments and wasn't able to
 come back and update the PR based upon feedback. Thanks @jpadilla for
 updating this.

 ISO_INPUT_FORMATS isn't referenced directly in either django-filter nor
 django-rest-framework. The chain goes like this:
 - DRF references DF.filterset (line 191 in my local django-filter)
  - DF.filter.DateTimeFilter which references
 django.forms.fields.DateTimeFleld (on line 120 in filters.py in django-
 filters) which calls
 - django.formats.get_format_lazy('DATETIME_INPUT_FORMATS') which
 returns a list of all the setup datetime formats to try and parse the
 incoming string against using strptime
- This is on line 490 in the django.forms.fields.py file.
 get_format_lazy calls get_format which references ISO_INPUT_FORMATS.

 That's why updating the ISO_INPUT_FORMATS dict fixes the DRF issue for
 most/some cases. I had overlooked the timezone issue with ISO8601
 apparently.  Maybe we should also update the BaseTemporalField
 (DateTimeFields super class) to use the django.utils.dateparse instead of
 strptime?

 That seems like a larger change than the original but seems like the
 correct answer to me.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.f0ee4dfe51c985e2792f8a700d67e76d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23448: Update ISO_INPUT_FORMATS to allow date filtering for ISO8601 dates

[Django]

#23448: Update ISO_INPUT_FORMATS to allow date filtering for ISO8601 dates
-+-
 Reporter:  jaegerpicker |Owner:  jpadilla
 Type:  New feature  |   Status:  assigned
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  datetime,| Triage Stage:  Accepted
  isoformat, ISO8601 |  Needs documentation:  1
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by tomchristie):

 I'm slightly unsure about this - Django still wouldn't be able to handle
 ISO8601 timezone information after this change, and I assume that eg.
 `2006-10-25T14:30:59Z` and `2006-10-25T14:30:59+01:00` would both still
 fail. That doesn't necessarily make this change invalid, but it doesn't
 look like it'd resolve the issue as it is described. (And no, strftime
 *can't* handle all the ISO8601 cases, see `django.utils.dateparse`).

 Confusingly I also don't see `ISO_INPUT_FORMATS` referenced in `django-
 filter` or `django-rest-framework` (I know the later doesn't use it for
 sure) so I'm unclear on *exactly* what downstream issue we're trying to
 resolve, or able to review if this would be an adequate fix for that.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.74da8756ae71d1ea6e952abce143c97f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23448: Update ISO_INPUT_FORMATS to allow date filtering for ISO8601 dates

[Django]

#23448: Update ISO_INPUT_FORMATS to allow date filtering for ISO8601 dates
-+-
 Reporter:  jaegerpicker |Owner:  jpadilla
 Type:  New feature  |   Status:  assigned
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  datetime,| Triage Stage:  Accepted
  isoformat, ISO8601 |  Needs documentation:  1
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by jpadilla):

 Pull Request: https://github.com/django/django/pull/3268

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.ddda685b15e08c1afe1703bab2c9997a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23448: Update ISO_INPUT_FORMATS to allow date filtering for ISO8601 dates

[Django]

#23448: Update ISO_INPUT_FORMATS to allow date filtering for ISO8601 dates
-+-
 Reporter:  jaegerpicker |Owner:  jpadilla
 Type:  New feature  |   Status:  assigned
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  datetime,| Triage Stage:  Accepted
  isoformat, ISO8601 |  Needs documentation:  1
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by jpadilla):

 * owner:  nobody => jpadilla
 * status:  new => assigned


Comment:

 I decided to step up and finish updating this to get it done. Would we
 also have to update DATETIME_INPUT_FORMATS on global_settings to include
 then new formats?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.c13274b6265d05a5fa0a244cf7966170%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23448: Update ISO_INPUT_FORMATS to allow date filtering for ISO8601 dates

[Django]

#23448: Update ISO_INPUT_FORMATS to allow date filtering for ISO8601 dates
-+-
 Reporter:  jaegerpicker |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  datetime,| Triage Stage:  Accepted
  isoformat, ISO8601 |  Needs documentation:  1
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by prestontimmons):

 * needs_better_patch:  0 => 1
 * needs_docs:  0 => 1


Comment:

 Left some comments on the PR. It could use documentation updates and some
 more specific tests for DateTimeField.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.cec7b26bd3c40c44fd7aff716df8215b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23448: Update ISO_INPUT_FORMATS to allow date filtering for ISO8601 dates

[Django]

#23448: Update ISO_INPUT_FORMATS to allow date filtering for ISO8601 dates
-+-
 Reporter:  jaegerpicker |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  datetime,| Triage Stage:  Accepted
  isoformat, ISO8601 |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by claudep):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * version:  1.7 => master
 * needs_docs:   => 0
 * has_patch:  0 => 1
 * type:  Bug => New feature
 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.5e1e71dc7683f15df01b0296116825c6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #23448: Update ISO_INPUT_FORMATS to allow date filtering for ISO8601 dates

[Django]

#23448: Update ISO_INPUT_FORMATS to allow date filtering for ISO8601 dates
--+--
 Reporter:  jaegerpicker  |  Owner:  nobody
 Type:  Bug   | Status:  new
Component:  Utilities |Version:  1.7
 Severity:  Normal|   Keywords:  datetime, isoformat, ISO8601
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+--
 Currently django_filters and django_rest_framework pull in the
 ISO_INPUT_FORMATS dictionary from django.utils.formats to try and convert
 dates/datetimes passed in as strings to datetime objects. There is
 currently no format strings compatible with datetime.isoformat(). I have
 updated the dictionary to add compatible format strings and tested
 django_filters and django_rest_framework, both work correctly with this
 update. I've ran all of the tests in django and all pass as expected. This
 is the github pull request: https://github.com/django/django/pull/3195

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/055.ecd893627cbb3dc691eee6f7865cc02a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.