Re: [Django] #23618: Migrations only work for apps containing models

[Django]

#23618: Migrations only work for apps containing models
-+-
 Reporter:  seddonym |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  master
Component:  Migrations   |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"e50e0ee27bf16090fe36a87cf91fe2baa27b70f1"]:
 {{{
 #!CommitTicketReference repository=""
 revision="e50e0ee27bf16090fe36a87cf91fe2baa27b70f1"
 Fixed #23618 -- Allowed apps with no models to still have migrations

 Basically a4737bf6ae reapplied.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.1bee1435a813a7fa23a8a93e17c72374%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23618: Migrations only work for apps containing models

[Django]

#23618: Migrations only work for apps containing models
-+-
 Reporter:  seddonym |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  master
Component:  Migrations   |   Resolution:
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.8832c08037cc41f8dda103ced763%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23618: Migrations only work for apps containing models

[Django]

#23618: Migrations only work for apps containing models
--+
 Reporter:  seddonym  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by claudep):

 * needs_docs:  1 => 0
 * version:  1.7 => master


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.cb4c259ffa6e558e78c4f6866d8e8a11%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23618: Migrations only work for apps containing models

[Django]

#23618: Migrations only work for apps containing models
--+
 Reporter:  seddonym  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  1.7
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by claudep):

 * needs_better_patch:  1 => 0
 * needs_docs:  0 => 1


Comment:

 I think I resolved the test-order-related failures.
 I guess this warrants a release note.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.a0065fa853c2d04fcaab3739157a85a9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23618: Migrations only work for apps containing models

[Django]

#23618: Migrations only work for apps containing models
--+
 Reporter:  seddonym  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  1.7
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1
 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.26f3714481e50aee553b944d4ed4a77f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23618: Migrations only work for apps containing models

[Django]

#23618: Migrations only work for apps containing models
-+-
 Reporter:  seddonym |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  1.7
Component:  Migrations   |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by claudep):

 I've update https://github.com/django/django/pull/3340.
 At least the test suite now starts, but strangely, the test suite passes
 when I only run it with `django.contrib.gis` test label, but fails with no
 test labels.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.fa42aa3623f2f2f47029b7de44996afa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23618: Migrations only work for apps containing models

[Django]

#23618: Migrations only work for apps containing models
-+-
 Reporter:  seddonym |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  1.7
Component:  Migrations   |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by claudep):

 Typical GIS error (whatever the backend) when removing the
 `app_config.models_module` check:
 {{{
 Applying gis_migrations.0001_initial...Traceback (most recent call last):
   File "./runtests.py", line 391, in 
 options.failfast, options.modules)
   File "./runtests.py", line 234, in django_tests
 test_labels or get_installed(), extra_tests=extra_tests)
   File "/home/jenkins/workspace/django-pull-
 requests/database/mysql_gis/python/python2.7/django/test/runner.py", line
 151, in run_tests
 old_config = self.setup_databases()
   File "/home/jenkins/workspace/django-pull-
 requests/database/mysql_gis/python/python2.7/django/test/runner.py", line
 113, in setup_databases
 return setup_databases(self.verbosity, self.interactive, self.keepdb,
 **kwargs)
   File "/home/jenkins/workspace/django-pull-
 requests/database/mysql_gis/python/python2.7/django/test/runner.py", line
 304, in setup_databases
 serialize=connection.settings_dict.get("TEST", {}).get("SERIALIZE",
 True),
   File "/home/jenkins/workspace/django-pull-
 requests/database/mysql_gis/python/python2.7/django/db/backends/creation.py",
 line 385, in create_test_db
 test_flush=True,
   File "/home/jenkins/workspace/django-pull-
 
requests/database/mysql_gis/python/python2.7/django/core/management/__init__.py",
 line 118, in call_command
 return command.execute(*args, **defaults)
   File "/home/jenkins/workspace/django-pull-
 requests/database/mysql_gis/python/python2.7/django/core/management/base.py",
 line 419, in execute
 output = self.handle(*args, **options)
   File "/home/jenkins/workspace/django-pull-
 
requests/database/mysql_gis/python/python2.7/django/core/management/commands/migrate.py",
 line 193, in handle
 executor.migrate(targets, plan, fake=options.get("fake", False))
   File "/home/jenkins/workspace/django-pull-
 requests/database/mysql_gis/python/python2.7/django/db/migrations/executor.py",
 line 63, in migrate
 self.apply_migration(migration, fake=fake)
   File "/home/jenkins/workspace/django-pull-
 requests/database/mysql_gis/python/python2.7/django/db/migrations/executor.py",
 line 91, in apply_migration
 if self.detect_soft_applied(migration):
   File "/home/jenkins/workspace/django-pull-
 requests/database/mysql_gis/python/python2.7/django/db/migrations/executor.py",
 line 135, in detect_soft_applied
 apps = project_state.render()
   File "/home/jenkins/workspace/django-pull-
 requests/database/mysql_gis/python/python2.7/django/db/migrations/state.py",
 line 89, in render
 model=lookup_model,
 ValueError: Lookup failed for model referenced by field
 gis_migrations.Household.neighborhood: gis.Neighborhood
 }}}
 http://djangoci.com/job/django-pull-requests/1249/

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.5a756b28132d77826d31170bcc71fcaf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23618: Migrations only work for apps containing models

[Django]

#23618: Migrations only work for apps containing models
-+-
 Reporter:  seddonym |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  1.7
Component:  Migrations   |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 See also #22645 - "GIS tests break without a models.py`. We removed that
 check and then something else broke (I forget what) so it had to be
 reverted.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.7659d3725aa54831bba5273f48a9961b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #23618: Migrations only work for apps containing models

[Django]

#23618: Migrations only work for apps containing models
--+
 Reporter:  seddonym  |  Owner:  nobody
 Type:  Cleanup/optimization  | Status:  new
Component:  Migrations|Version:  1.7
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 Migrations only work for apps containing a `models.py`.  This means that
 if you create a data migration (`./manage.py makemigrations --empty
 `) for an app without a `models.py`, it will fail to execute when
 running `./manage.py migrate`.

 I think it would be better if apps containing migrations would run,
 regardless of having that empty file.

 This is because it can be a nice structure to have a 'main' app
 responsible for general project-wide stuff, which includes running data
 migrations that aren't directly related to models.  An example might be
 assigning some permissions in the database to a particular role, but for a
 third party app.

 Not sure if this is the only place where the check is made, but
 `django.db.migrations.loader.MigrationLoader.load_disk()` uses the
 following test to see whether to include the app:
 {{{
 if app_config.models_module is None:
 continue
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.1d4525884fa0bdce16fa246762421bf3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.