Re: [Django] #23620: Use more specify assertions than assertTrue in tests

[Django]

#23620: Use more specify assertions than assertTrue in tests
-+-
 Reporter:  timgraham|Owner:
 Type:   |  averybigant
  Cleanup/optimization   |   Status:  assigned
Component:  Uncategorized|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by averybigant):

 * owner:  nobody => averybigant
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.69eceff1aa2b2072fdd9fd42f8942ab7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #23620: Use more specify assertions than assertTrue in tests

[Django]

#23620: Use more specify assertions than assertTrue in tests
+
   Reporter:  timgraham |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Uncategorized |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  0 |
+
 We should change things like
 `self.assertTrue(fetched.active_translation.title == 'Otsikko')` to use
 `assertEqual` and things like `self.assertTrue('id' in form.fields)` to
 use `assertIn`. Attaching an initial patch. I used `grep -rI "assertTrue"
 * | grep ==` to find instances that need changing.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.f98d0653f0bfb3e2de8de4a8217f2a5d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.