Re: [Django] #23639: Doc error in RegexValidator.regex

[Django]

#23639: Doc error in RegexValidator.regex
---+---
 Reporter:  claudep|Owner:  doriczapari
 Type:  Bug|   Status:  closed
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+---

Comment (by Baptiste Mispelon ):

 In [changeset:"d2a2af67f7c2c41a831acd33cd8cba5875c216cf"]:
 {{{
 #!CommitTicketReference repository=""
 revision="d2a2af67f7c2c41a831acd33cd8cba5875c216cf"
 [1.7.x] Fixed #23639 -- Fixed doc error in RegexValidator.regex

 Thanks to @claudep for the report and the original patch.

 Backport of c48a29a02a457cfdb1cff11009401459ba24e870 from master.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.b706b9804de98a4303c05a47cb9de726%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23639: Doc error in RegexValidator.regex

[Django]

#23639: Doc error in RegexValidator.regex
---+---
 Reporter:  claudep|Owner:  doriczapari
 Type:  Bug|   Status:  closed
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+---
Changes (by Baptiste Mispelon ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"c48a29a02a457cfdb1cff11009401459ba24e870"]:
 {{{
 #!CommitTicketReference repository=""
 revision="c48a29a02a457cfdb1cff11009401459ba24e870"
 Fixed #23639 -- Fixed doc error in RegexValidator.regex

 Thanks to @claudep for the report and the original patch.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.cad7e697ce6c4dbd191fda97a45bdcc0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23639: Doc error in RegexValidator.regex

[Django]

#23639: Doc error in RegexValidator.regex
---+---
 Reporter:  claudep|Owner:  doriczapari
 Type:  Bug|   Status:  assigned
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+---
Changes (by doriczapari):

 * has_patch:  0 => 1


Comment:

 Here's the pull request: https://github.com/django/django/pull/3346

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.9549860eb369390287717b94c6a618c0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23639: Doc error in RegexValidator.regex

[Django]

#23639: Doc error in RegexValidator.regex
---+---
 Reporter:  claudep|Owner:  doriczapari
 Type:  Bug|   Status:  assigned
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+---
Changes (by doriczapari):

 * status:  new => assigned
 * owner:  nobody => doriczapari


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.6b756f22ea1d7dc8be4392dfc98933ce%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23639: Doc error in RegexValidator.regex

[Django]

#23639: Doc error in RegexValidator.regex
---+
 Reporter:  claudep|Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by claudep):

 Suggested patch:
 {{{
 #!diff
 diff --git a/docs/ref/validators.txt b/docs/ref/validators.txt
 index 260c066..0b66dd2 100644
 --- a/docs/ref/validators.txt
 +++ b/docs/ref/validators.txt
 @@ -81,11 +81,13 @@ to, or in lieu of custom ``field.clean()`` methods.
  .. attribute:: regex

  The regular expression pattern to search for the provided
 ``value``,
 -or a pre-compiled regular expression. Raises a
 +or a pre-compiled regular expression. By default, raises a
  :exc:`~django.core.exceptions.ValidationError` with
 :attr:`message`
 -and :attr:`code` if :attr:`inverse_match` is ``False`` and a
 match is
 -found, or if :attr:`inverse_match` is ``True`` and a match is not
 found.
 -By default, matches any string (including an empty string).
 +and :attr:`code` if a match is not found. That standard behavior
 might
 +be reversed by setting :attr:`inverse_match` to ``True``, meaning
 that
 +the :exc:`~django.core.exceptions.ValidationError` is raised when
 a
 +match **is** found. By default, matches any string (including an
 empty
 +string).

  .. attribute:: message
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.5aea7ce1605f18306b98738dfd525b9e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23639: Doc error in RegexValidator.regex

[Django]

#23639: Doc error in RegexValidator.regex
---+
 Reporter:  claudep|Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by bmispelon):

 * easy:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 Hi,

 You're right (and I also find this sentence really hard to parse, but
 maybe that's just me):

 {{{#!python
 >>> RegexValidator(regex='[a-z]')('1')
 Traceback (most recent call last):
   File "", line 1, in 
   File "/home/tisba/Programming/testbed/boogz/django/core/validators.py",
 line 51, in __call__
 raise ValidationError(self.message, code=self.code)
 django.core.exceptions.ValidationError: ['Enter a valid value.']
 >>> RegexValidator(regex='[a-z]', inverse_match=True)('1')

 }}}

 I wouldn't be opposed to a rewrite of this paragraph since I find it quite
 confusing.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.efa071ceecd782ea0604a22a2420bfae%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #23639: Doc error in RegexValidator.regex

[Django]

#23639: Doc error in RegexValidator.regex
-+
   Reporter:  claudep|  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Documentation  |Version:  master
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 In
 
https://docs.djangoproject.com/fr/1.7/ref/validators/#django.core.validators.RegexValidator.regex,
 I think that the effects of `inverse_match` are reversed. A
 `ValidationError` is raised when `inverse_match=True` and a match **is**
 found. Can someone confirm? Boolean logic, we love you!

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.c6c592fe71ab83441df0dfb3aa5918b8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.