Re: [Django] #26983: Boolean filter "field__isnull=False" not working with ForeignKey with to_field

[Django]

#26983: Boolean filter "field__isnull=False" not working with ForeignKey with
to_field
-+-
 Reporter:  weidwonder   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  queryset | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * status:  new => closed
 * resolution:   => fixed


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.83fa80e3b948cc99440b1618a4c18227%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26983: Boolean filter "field__isnull=False" not working with ForeignKey with to_field

[Django]

#26983: Boolean filter "field__isnull=False" not working with ForeignKey with
to_field
-+-
 Reporter:  weidwonder   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  queryset | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"c24a47b3e6cfba88ee7792be25da5b5333266abe" c24a47b3]:
 {{{
 #!CommitTicketReference repository=""
 revision="c24a47b3e6cfba88ee7792be25da5b5333266abe"
 [1.10.x] Refs #26983 -- Added test for isnull lookup to CharField with
 primary_key=True.

 Backport of 97513269d73520d10722bbd10404be6ac4d48d07 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.79a46dc7acb52a1c21cf66c2442edbf9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26983: Boolean filter "field__isnull=False" not working with ForeignKey with to_field

[Django]

#26983: Boolean filter "field__isnull=False" not working with ForeignKey with
to_field
-+-
 Reporter:  weidwonder   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  queryset | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"97513269d73520d10722bbd10404be6ac4d48d07" 9751326]:
 {{{
 #!CommitTicketReference repository=""
 revision="97513269d73520d10722bbd10404be6ac4d48d07"
 Refs #26983 -- Added test for isnull lookup to CharField with
 primary_key=True.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.c05723233bf84d051af7eaab2fd0ce29%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26983: Boolean filter "field__isnull=False" not working with ForeignKey with to_field

[Django]

#26983: Boolean filter "field__isnull=False" not working with ForeignKey with
to_field
-+-
 Reporter:  weidwonder   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  queryset | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by lamby):

 Replying to [comment:13 timgraham]:
 > Could you send a pull request with those items? You can use "Refs #26983
 --" in the commit message.

 https://github.com/django/django/pull/7104

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.a0b15ad5b0d3141ed40e7d3ab25df33e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26983: Boolean filter "field__isnull=False" not working with ForeignKey with to_field

[Django]

#26983: Boolean filter "field__isnull=False" not working with ForeignKey with
to_field
-+-
 Reporter:  weidwonder   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  queryset | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * has_patch:  1 => 0
 * severity:  Release blocker => Normal
 * stage:  Ready for checkin => Accepted


Comment:

 Could you send a pull request with those items? You can use "Refs #26983
 --" in the commit message.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.72a532f963fc60f50b97384e3ce1dafb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26983: Boolean filter "field__isnull=False" not working with ForeignKey with to_field

[Django]

#26983: Boolean filter "field__isnull=False" not working with ForeignKey with
to_field
-+-
 Reporter:  weidwonder   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:  queryset | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by lamby):

 After writing a testcase (available here:
 https://gist.github.com/lamby/394b712e9e9ff1e868a20e67d4ba482b/raw) "git
 bisect" told me that it was indeed fixed with the above change.
 Investigating more, what happened was that I was applying the patch
 against `RelatedIn`instead of `RelatedLookupMixin`. Apologies for the
 noise there.

 ''However'', I am still correct in that the bug is not strictly `to_field`
 specific as it affects this `primary_key` case. Therefore, I suggest:

  * You update the release documentation, etc. to reflect this
  * You add my test (or similar) to prevent a regression

 In light of this, I am not resolving this ticket so that these action
 items do not get overlooked.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.7ebaf9333921cca0520aed5988b70d1f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26983: Boolean filter "field__isnull=False" not working with ForeignKey with to_field

[Django]

#26983: Boolean filter "field__isnull=False" not working with ForeignKey with
to_field
-+-
 Reporter:  weidwonder   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:  queryset | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by lamby):

 * status:  closed => new
 * resolution:  fixed =>


Comment:

 This also happens for `field_isnull=False` where `field` is a `ForeignKey`
 to a model with a `CharField` that is `primary_key=True`. Again,
 `self.rhs` is converted from `False` to `'False``, ie a `bool` to a `str`.
 Reopening as the pach does not fix this.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.7bb344c79a047d898d2da81b6aeb59ae%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26983: Boolean filter "field__isnull=False" not working with ForeignKey with to_field

[Django]

#26983: Boolean filter "field__isnull=False" not working with ForeignKey with
to_field
-+-
 Reporter:  weidwonder   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  queryset | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Claude Paroz ):

 In [changeset:"6757c94662ef07e35eafcf3ac8bdae07a3d9326a" 6757c946]:
 {{{
 #!CommitTicketReference repository=""
 revision="6757c94662ef07e35eafcf3ac8bdae07a3d9326a"
 [1.10.x] Fixed #26983 -- Fixed isnull filtering on ForeignKey with
 to_field

 Thanks weidwonder for the report.
 Backport of 272eccf7ff0ced609e5a5e3bb6b4a40e773e0e66 from master.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.f2258ae53fb84e13452a053cd1876cb0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26983: Boolean filter "field__isnull=False" not working with ForeignKey with to_field

[Django]

#26983: Boolean filter "field__isnull=False" not working with ForeignKey with
to_field
-+-
 Reporter:  weidwonder   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  queryset | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"272eccf7ff0ced609e5a5e3bb6b4a40e773e0e66" 272eccf7]:
 {{{
 #!CommitTicketReference repository=""
 revision="272eccf7ff0ced609e5a5e3bb6b4a40e773e0e66"
 Fixed #26983 -- Fixed isnull filtering on ForeignKey with to_field

 Thanks weidwonder for the report.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.09d1a475bb4f70677a3f76b7147f966f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26983: Boolean filter "field__isnull=False" not working with ForeignKey with to_field

[Django]

#26983: Boolean filter "field__isnull=False" not working with ForeignKey with
to_field
-+-
 Reporter:  weidwonder   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:  queryset | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by charettes):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.d35bfbb5b7846780541f1a060963b0ab%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26983: Boolean filter "field__isnull=False" not working with ForeignKey with to_field

[Django]

#26983: Boolean filter "field__isnull=False" not working with ForeignKey with
to_field
-+-
 Reporter:  weidwonder   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:  queryset | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by claudep):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/7006 PR] resulting of discussions
 with bmispelon on IRC.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.a4b5b2ee7003b25b2f0ad3e0f66c5cc6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26983: Boolean filter "field__isnull=False" not working with ForeignKey with to_field

[Django]

#26983: Boolean filter "field__isnull=False" not working with ForeignKey with
to_field
-+-
 Reporter:  weidwonder   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:  queryset | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by charettes):

 Replying to [comment:5 MatthewWilkes]:
 > I don't believe that IsNull lookups should be converting their values to
 the type of the parent field, however the RelatedLookupMixin has useful
 looking code for ensuring that MultiColSource is handled correctly.
 >
 > Would the fix for this be as simple as:
 >
 > {{{
 > class RelatedIsNull(RelatedLookupMixin, IsNull):
 > def get_prep_lookup(self):
 > return self.rhs
 > }}}
 > ?

 `return super(RelatedLookupMixin, self).get_prep_lookup()` would be more
 appropriate.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.ba3b74b0ba96115acda3f209d45c0447%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26983: Boolean filter "field__isnull=False" not working with ForeignKey with to_field

[Django]

#26983: Boolean filter "field__isnull=False" not working with ForeignKey with
to_field
-+-
 Reporter:  weidwonder   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:  queryset | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by MatthewWilkes):

 I don't believe that IsNull lookups should be converting their values to
 the type of the parent field, however the RelatedLookupMixin has useful
 looking code for ensuring that MultiColSource is handled correctly.

 Would the fix for this be as simple as:

 {{{
 class RelatedIsNull(RelatedLookupMixin, IsNull):
 def get_prep_lookup(self):
 return self.rhs
 }}}
 ?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.4afe20489af9ec7b1877117b4c87e6d5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26983: Boolean filter "field__isnull=False" not working with ForeignKey with to_field (was: models.Manager query "filter(field__isnull=False)" not working in 1.10)

[Django]

#26983: Boolean filter "field__isnull=False" not working with ForeignKey with
to_field
-+-
 Reporter:  weidwonder   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:  queryset | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.fd19fd1d66e3bbabaaf71584538300d2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.