Re: [Django] #27377: Clarify that prepopulated_fields doesn't work with OneToOneField

[Django]

#27377: Clarify that prepopulated_fields doesn't work with OneToOneField
-+-
 Reporter:  Malik A. Rumi|Owner:  Henry
 Type:   |  Dang
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
  prepopulated_fields, admin.py  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"12c1d6fe8f03f068f6010e3c8e0f441bf2567e7c" 12c1d6f]:
 {{{
 #!CommitTicketReference repository=""
 revision="12c1d6fe8f03f068f6010e3c8e0f441bf2567e7c"
 Refs #27377 -- Fixed reverse query name clash in test model.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.8e4e2cec3eac4e5ab14eab007457%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27377: Clarify that prepopulated_fields doesn't work with OneToOneField

[Django]

#27377: Clarify that prepopulated_fields doesn't work with OneToOneField
-+-
 Reporter:  Malik A. Rumi|Owner:  Henry
 Type:   |  Dang
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
  prepopulated_fields, admin.py  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"6af23a4521fcf80aec7c5ee3988914423c7dfccd" 6af23a4]:
 {{{
 #!CommitTicketReference repository=""
 revision="6af23a4521fcf80aec7c5ee3988914423c7dfccd"
 Fixed #27377 -- Clarified that prepopulated_fields doesn't work with
 OneToOneField.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.37acee4d149705cfbae412da02de9ac7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27377: Clarify that prepopulated_fields doesn't work with OneToOneField

[Django]

#27377: Clarify that prepopulated_fields doesn't work with OneToOneField
-+-
 Reporter:  Malik A. Rumi|Owner:  Henry
 Type:   |  Dang
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  prepopulated_fields, admin.py  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Henry Dang):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/7710 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.18a00ab6e3302d553d9ca5593599b7b0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27377: Clarify that prepopulated_fields doesn't work with OneToOneField

[Django]

#27377: Clarify that prepopulated_fields doesn't work with OneToOneField
-+-
 Reporter:  Malik A. Rumi|Owner:  Henry
 Type:   |  Dang
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  prepopulated_fields, admin.py  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Henry Dang):

 * owner:  (none) => Henry Dang
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.5d7d7a8dc6f9d7f63c31f867e139453d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27377: Clarify that prepopulated_fields doesn't work with OneToOneField

[Django]

#27377: Clarify that prepopulated_fields doesn't work with OneToOneField
-+-
 Reporter:  Malik A. Rumi|Owner:  (none)
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  prepopulated_fields, admin.py  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham):

 * owner:  Sudheesh Singanamalla => (none)
 * status:  assigned => new


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.0bde2abe10b2bd6193cc6753a8047f08%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27377: Clarify that prepopulated_fields doesn't work with OneToOneField

[Django]

#27377: Clarify that prepopulated_fields doesn't work with OneToOneField
-+-
 Reporter:  Malik A. Rumi|Owner:  Sudheesh
 Type:   |  Singanamalla
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  prepopulated_fields, admin.py  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Malik A. Rumi):

 Thanks guys. This will be a big help to all the literal minded people out
 there, like me.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.a86e1b6caa1df05115e4a1241f0687c4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27377: Clarify that prepopulated_fields doesn't work with OneToOneField

[Django]

#27377: Clarify that prepopulated_fields doesn't work with OneToOneField
-+-
 Reporter:  Malik A. Rumi|Owner:  Sudheesh
 Type:   |  Singanamalla
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  prepopulated_fields, admin.py  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham):

 Yes, please keep the comma before "or" in the message. A test could also
 be added.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.b5f4f577574ac61d13fd7b635158e710%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27377: Clarify that prepopulated_fields doesn't work with OneToOneField

[Django]

#27377: Clarify that prepopulated_fields doesn't work with OneToOneField
-+-
 Reporter:  Malik A. Rumi|Owner:  Sudheesh
 Type:   |  Singanamalla
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  prepopulated_fields, admin.py  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Sudheesh Singanamalla):

 * owner:  nobody => Sudheesh Singanamalla
 * status:  new => assigned


Comment:

 As far as what I understand from the discussion so far and the
 description, the fact that `prepopulated_fields` doesn't accept `OneToOne`
 fields needs to be explicitly mentioned in the documentation as well as an
 update to the following line
 
https://github.com/django/django/blob/f734e2d4b2fc4391a4d097b80357724815c1d414/django/contrib/admin/checks.py#L402
 mentioning
 {{{
  else:
 if isinstance(field, (models.DateTimeField, models.ForeignKey,
 models.ManyToManyField)):
 return [
 checks.Error(
 "The value of '%s' refers to '%s', which must not
 be a DateTimeField, "
 "a ForeignKey, a OneToOneField or a
 ManyToManyField." % (label, field_name),
 obj=obj.__class__,
 id='admin.E028',
 )
 ]
 else:
 return []
 }}}

 Would this solve the issue ?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.44fa545ac911f0e34a5e60617e4218a1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27377: Clarify that prepopulated_fields doesn't work with OneToOneField

[Django]

#27377: Clarify that prepopulated_fields doesn't work with OneToOneField
-+-
 Reporter:  Malik A. Rumi|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  prepopulated_fields, admin.py  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Malik A. Rumi):

 Replying to [comment:1 Tim Graham]:
 > `OneToOneField` is a subclass of `ForeignKey`, so as far as I see,
 
[https://github.com/django/django/blob/f734e2d4b2fc4391a4d097b80357724815c1d414/django/contrib/admin/checks.py#L399-L406
 a system check error] will occur. I guess the error message could be
 clarified since it confused you.
 >
 > As far as getting answers to usage questions goes, please
 [wiki:TicketClosingReasons/UseSupportChannels].

 Ok. Thx.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6d6d5a02aded239a4ce5da38812814f5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27377: Clarify that prepopulated_fields doesn't work with OneToOneField (was: Prepopulated Fields in Django Admin)

[Django]

#27377: Clarify that prepopulated_fields doesn't work with OneToOneField
-+-
 Reporter:  Malik A. Rumi|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  prepopulated_fields, admin.py  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * easy:  0 => 1
 * needs_docs:   => 0
 * type:  Bug => Cleanup/optimization
 * stage:  Unreviewed => Accepted


Comment:

 `OneToOneField` is a subclass of `ForeignKey`, so as far as I see,
 
[https://github.com/django/django/blob/f734e2d4b2fc4391a4d097b80357724815c1d414/django/contrib/admin/checks.py#L399-L406
 a system check error] will occur. I guess the error message could be
 clarified since it confused you.

 As far as getting answers to usage questions goes, please
 [wiki:TicketClosingReasons/UseSupportChannels].

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.50ccc9a4f07ad40d6939da0d24d5fc2c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.