Re: [Django] #27423: Test command sys.exit() does unnecessary casting to False always

[Django]

#27423: Test command sys.exit() does unnecessary casting to False always
-+-
 Reporter:  Ana Balica   |Owner:  Ana
 Type:   |  Balica
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:  test | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Ana Balica):

 * owner:  nobody => Ana Balica


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.e568ed54f214882b21aa826dda9c81f7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #27423: Test command sys.exit() does unnecessary casting to False always

[Django]

#27423: Test command sys.exit() does unnecessary casting to False always
+--
   Reporter:  Ana Balica|  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  assigned
  Component:  Testing framework |Version:  1.10
   Severity:  Normal|   Keywords:  test
   Triage Stage:  Unreviewed|  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  0 |
+--
 Currently we have:

 {{{
 if failures:
 sys.exit(bool(failures))
 }}}

 If no failures, the script will exit with 0 success, if any failures, then
 the exit is forced with a `False` value, which will result in a 1.
 Why not be explicit?

 {{{
 if failures:
 sys.exit(1)
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/053.ed4df24ae862bdbd48ab9dc825ce801e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.