Re: [Django] #27654: Propogate alters_data value to subclasses

[Django]

#27654: Propogate alters_data value to subclasses
-+-
 Reporter:  vinay karanam|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Core (Other) |  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"e20c9eb60ab9d1c84b19672def918097c943edd8" e20c9eb]:
 {{{
 #!CommitTicketReference repository=""
 revision="e20c9eb60ab9d1c84b19672def918097c943edd8"
 Fixed #27654 -- Propagated alters_data attribute to callables overridden
 in subclasses.

 Thanks Shai Berger and Adam Johnson for reviews and the implementation
 idea.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018443c5047c-ab0db509-2686-413a-b7a9-4e2016eb41a9-00%40eu-central-1.amazonses.com.

Re: [Django] #27654: Propogate alters_data value to subclasses

[Django]

#27654: Propogate alters_data value to subclasses
-+-
 Reporter:  vinay karanam|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Core (Other) |  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"e20c9eb60ab9d1c84b19672def918097c943edd8" e20c9eb]:
 {{{
 #!CommitTicketReference repository=""
 revision="e20c9eb60ab9d1c84b19672def918097c943edd8"
 Fixed #27654 -- Propagated alters_data attribute to callables overridden
 in subclasses.

 Thanks Shai Berger and Adam Johnson for reviews and the implementation
 idea.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701844248fada-2b330272-ba5d-45cc-bfb4-58471a441b44-00%40eu-central-1.amazonses.com.

Re: [Django] #27654: Propogate alters_data value to subclasses

[Django]

#27654: Propogate alters_data value to subclasses
-+-
 Reporter:  vinay karanam|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Core (Other) |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Shai Berger):

 * stage:  Accepted => Ready for checkin


Comment:

 (in the last review the PR still had a couple of minor issues, but I
 believe it is ready for a merger review)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184162df29a-15dd3c9a-4d38-4930-bd2b-bd027949b007-00%40eu-central-1.amazonses.com.

Re: [Django] #27654: Propogate alters_data value to subclasses

[Django]

#27654: Propogate alters_data value to subclasses
--+
 Reporter:  vinay karanam |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Other)  |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Shai Berger):

 * status:  closed => new
 * resolution:  wontfix =>


Comment:

 Reopening the ticket following a discussion on the security mailing list,
 which led to https://github.com/django/django/pull/16149

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184162c6a1d-54d39bec-78de-4c7a-afb4-a7746567b9fe-00%40eu-central-1.amazonses.com.

Re: [Django] #27654: Propogate alters_data value to subclasses

[Django]

#27654: Propogate alters_data value to subclasses
--+
 Reporter:  vinay karanam |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:  wontfix
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Carlton Gibson):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 After looking at the implementation on the PR, the proposed metaclass
 solution is too much to given the relatively small improvement over the
 current `alters_data` solution.

 The remaining suggestion from #27638 was to use the system checks
 framework to warn users of a problem. That might be worth a go. It would
 be able to capture the most common cases on `Model` classes certainly.
 (Whether we want to add that isn't clear: in lots of cases `save` is
 overridden without setting `alters_data` — to make that an error might be
 more annoying than a benefit, but it could at least be silenced.)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.5a3ddd055ca93949204135d8433ebed9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27654: Propogate alters_data value to subclasses

[Django]

#27654: Propogate alters_data value to subclasses
--+
 Reporter:  vinay karanam |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Asif Saifuddin Auvi):

 * needs_better_patch:  1 => 0
 * version:  1.10 => master


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.36fdf6cdd69de2bfef35b5a82de48672%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27654: Propogate alters_data value to subclasses

[Django]

#27654: Propogate alters_data value to subclasses
--+
 Reporter:  vinay karanam |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Other)  |  Version:  1.10
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1
 * component:  Uncategorized => Core (Other)
 * stage:  Unreviewed => Accepted


Comment:

 [https://github.com/django/django/pull/7759 WIP PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.8c3728a3ad6d930ab3c8b218cfe610e3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #27654: Propogate alters_data value to subclasses

[Django]

#27654: Propogate alters_data value to subclasses
+
   Reporter:  vinay karanam |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Uncategorized |Version:  1.10
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 Current implementation to prevent data changes within templates relies on
 the attribute alters_data = True.

 By default this is set for all Model, QuerySet and ModelForm methods that
 can alter data.

 But if someone overrides these methods, they need to explicitly set this
 attribute again.
 It is common to override save method and not set this attribute.

 Even a lot of popular third-party packages end up making this mistake.

 These classes need to make sure that the attribute value is set for their
 subclasses methods if not explicitly overwritten.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/057.b25547d6450a56182c23191dd60a0d3b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.