Re: [Django] #28201: Make CharField/TextField prohibit null characters

[Django]

#28201: Make CharField/TextField prohibit null characters
-+-
 Reporter:  CM Lubinski  |Owner:  Alejandro
 Type:   |  Zamora Fonseca
  Cleanup/optimization   |   Status:  assigned
Component:  Forms|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Alejandro Zamora Fonseca):

 Maybe only adding the  null char validator to CharField would be enough?
 Because TextField is converted to CharField when Model to Field
 translation occurs.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f0abfa80cac60a92f13669a31d34a182%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28201: Make CharField/TextField prohibit null characters

[Django]

#28201: Make CharField/TextField prohibit null characters
-+-
 Reporter:  CM Lubinski  |Owner:  Alejandro
 Type:   |  Zamora Fonseca
  Cleanup/optimization   |   Status:  assigned
Component:  Forms|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.a9cdde7dbf493efc885e0d34e87377a3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28201: Make CharField/TextField prohibit null characters

[Django]

#28201: Make CharField/TextField prohibit null characters
-+-
 Reporter:  CM Lubinski  |Owner:  Alejandro
 Type:   |  Zamora Fonseca
  Cleanup/optimization   |   Status:  assigned
Component:  Forms|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Alejandro Zamora Fonseca):

 Linked PR against master branch
 [https://github.com/django/django/pull/6870 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.746dccd92374180e5002ade903375699%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28201: Make CharField/TextField prohibit null characters

[Django]

#28201: Make CharField/TextField prohibit null characters
-+-
 Reporter:  CM Lubinski  |Owner:  Alejandro
 Type:   |  Zamora Fonseca
  Cleanup/optimization   |   Status:  assigned
Component:  Forms|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Alejandro Zamora Fonseca):

 Added default null characters validation to CharField and TextField in
 order to avoid raising errors on database layer. Added test for both
 fields. Tested on PostgreSQL, MySQL, and SQLite backends.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.d9bd78b28639289a40b5cd4336c2da3e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28201: Make CharField/TextField prohibit null characters

[Django]

#28201: Make CharField/TextField prohibit null characters
-+-
 Reporter:  CM Lubinski  |Owner:  Alejandro
 Type:   |  Zamora Fonseca
  Cleanup/optimization   |   Status:  assigned
Component:  Forms|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Alejandro Zamora Fonseca):

 * owner:  (none) => Alejandro Zamora Fonseca
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.d74d9f9adfb29823988f57d1d1a44c79%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28201: Make CharField/TextField prohibit null characters

[Django]

#28201: Make CharField/TextField prohibit null characters
--+
 Reporter:  CM Lubinski   |Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  Forms |  Version:  1.11
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Tim Graham):

 That seems reasonable.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.3462374d5cefdb9303d5c577d6292cb7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28201: Make CharField/TextField prohibit null characters

[Django]

#28201: Make CharField/TextField prohibit null characters
--+
 Reporter:  CM Lubinski   |Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  Forms |  Version:  1.11
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Rajesh Veeranki):

 So the way to achieve this is by adding a default validator to `CharField`
 and `TextField` and raise a validation error. Am I right?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6a0078d2d834c98514b93e8d8e801de2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28201: Make CharField/TextField prohibit null characters (was: Saving a Char/TextField with psycopg2 2.7+ raises ValueError: A string literal cannot contain NUL (0x00) characters is unha

[Django]

#28201: Make CharField/TextField prohibit null characters
--+
 Reporter:  CM Lubinski   |Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  Forms |  Version:  1.11
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * type:  Bug => Cleanup/optimization
 * component:  Database layer (models, ORM) => Forms
 * severity:  Release blocker => Normal


Comment:

 The consensus on the mailing list is to make `CharField` and `TextField`
 prohibit null characters.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1628e27fbeaa20c704027f890ed9710e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.