Re: [Django] #29065: Only load Pillow if needed

2018-01-27 Thread Django
#29065: Only load Pillow if needed
--+
 Reporter:  Collin Anderson   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Other)  |  Version:  2.0
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Loic Bistuer):

 * stage:  Unreviewed => Accepted


Comment:

 +1 to making Pillow truly optional.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.01ed58c916ca50362c00801dd04e95ed%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29065: Only load Pillow if needed

2018-01-27 Thread Django
#29065: Only load Pillow if needed
-+-
 Reporter:  Collin Anderson  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Core (Other) |  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Collin Anderson):

 A few advantages:
 If for some reason you can't or have trouble installing pillow, everything
 else will work fine. It makes django a bit more "lightweight" to have the
 dependency be optional.

 Loading Pillow increases memory usage by 5% (2mb) (in my quick testing)
 for a runserver on an empty project:
 37608kb without loading pillow
 39768kb with loading pillow

 Also, doesn't matter quite as much, but running "check" also takes about
 5% longer (25ms) on an empty project for me when including pillow:
 360-400ms without loading pillow
 393-424ms with loading pillow

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.f1dab9710e0ce8774f7ed78212836fa6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29065: Only load Pillow if needed

2018-01-27 Thread Django
#29065: Only load Pillow if needed
-+-
 Reporter:  Collin Anderson  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Core (Other) |  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Akshesh Doshi):

 * cc: Akshesh Doshi (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.37969f1c659b76b0b6619b8e0901ac93%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29065: Only load Pillow if needed

2018-01-26 Thread Django
#29065: Only load Pillow if needed
-+-
 Reporter:  Collin Anderson  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Core (Other) |  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * type:  Uncategorized => Cleanup/optimization
 * component:  File uploads/storage => Core (Other)


Comment:

 I don't see the motivation behind the idea.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.20578865f6fa87200ecabf3a777fe4f3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29065: Only load Pillow if needed (was: Don't load Pillow unless needed)

2018-01-25 Thread Django
#29065: Only load Pillow if needed
-+-
 Reporter:  Collin Anderson  |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  File |  Version:  2.0
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Collin Anderson):

 * cc: Collin Anderson (added)
 * has_patch:  0 => 1


Comment:

 https://github.com/django/django/pull/9619

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.91182e911132767bd709e5ed71c67001%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.