Re: [Django] #29219: Admin Changelist Filters Not Using Parsed Params

[Django]

#29219: Admin Changelist Filters Not Using Parsed Params
---+--
 Reporter:  David Sanders  |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  contrib.admin  |  Version:  2.0
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"47bb3b68ff67a29da308b42e7950ca46df74b52b" 47bb3b68]:
 {{{
 #!CommitTicketReference repository=""
 revision="47bb3b68ff67a29da308b42e7950ca46df74b52b"
 Fixed #29219 -- Made admin filters use processed params rather than
 request.GET.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.47e0ba34ad8532f05b5cc17a60a10fbf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29219: Admin Changelist Filters Not Using Parsed Params

[Django]

#29219: Admin Changelist Filters Not Using Parsed Params
---+--
 Reporter:  David Sanders  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  2.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by Markus Holtermann):

 * easy:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.206f136d55e92239508712ee2280744c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #29219: Admin Changelist Filters Not Using Parsed Params

[Django]

#29219: Admin Changelist Filters Not Using Parsed Params
-+
   Reporter:  David Sanders  |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  contrib.admin  |Version:  2.0
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 Several of the admin changelist filter classes
 
[https://github.com/django/django/blob/master/django/contrib/admin/filters.py#L167
 pull parameters directly from `request.GET`] despite having a dict of
 parsed params passed in. I consider this a bug because it's a bit of a
 split-brain issue, some of the code works with the passed in params, some
 of it works directly with `request.GET`, so there's not one consistent
 place to change behavior regarding params. Specific use case I ran into:
 if you want a filter which 'expands' to providing values for multiple
 other filters, overriding `ChangeList.get_filters_params` would seem like
 the logical place to do the parameter expansion, but doing so yields
 inconsistent results due to the direct use of `request.GET` for pulling
 parameters in some filters but not others (specifically
 `DateFieldListFilter` and `SimpleListFilter` respond as you'd expect,
 other filters do not). Having the filters pull from the provided params
 closes this loop and makes things act consistently.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/053.5ec2509767cf1f964514e1069e09bdb7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.