Re: [Django] #30057: diffsettings leaves out custom default settings

[Django]

#30057: diffsettings leaves out custom default settings
-+-
 Reporter:  orlnub123|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  diffsettings,| Triage Stage:  Accepted
  settings   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"2c0fda7f206f2057df642939e51358944b313483" 2c0fda7f]:
 {{{
 #!CommitTicketReference repository=""
 revision="2c0fda7f206f2057df642939e51358944b313483"
 Refs #30057 -- Added more diffsettings tests.

 The test in 573f44d62fe1e87e2c20a74eba5e20ca9ff0ed85 doesn't act as a
 regression test.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.39b1bdbaef18ac43972040108aaaeade%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30057: diffsettings leaves out custom default settings

[Django]

#30057: diffsettings leaves out custom default settings
-+-
 Reporter:  orlnub123|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  diffsettings,| Triage Stage:  Accepted
  settings   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 The PR seems to be about additional test coverage which can be added
 without an open ticket.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7e510cf5aa783d1d8a5a1e26834e24d5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30057: diffsettings leaves out custom default settings

[Django]

#30057: diffsettings leaves out custom default settings
-+-
 Reporter:  orlnub123|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:  diffsettings,| Triage Stage:  Accepted
  settings   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by orlnub123):

 * status:  closed => new
 * resolution:  fixed =>


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.69599d2bdcc2c220a6cd11c582ae701f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30057: diffsettings leaves out custom default settings

[Django]

#30057: diffsettings leaves out custom default settings
-+-
 Reporter:  orlnub123|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  diffsettings,| Triage Stage:  Accepted
  settings   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"573f44d62fe1e87e2c20a74eba5e20ca9ff0ed85" 573f44d6]:
 {{{
 #!CommitTicketReference repository=""
 revision="573f44d62fe1e87e2c20a74eba5e20ca9ff0ed85"
 Fixed #30057 -- Fixed diffsettings ignoring custom configured settings.

 Regression in 49b679371fe9beddcd23a93b5fdbadea914f37f8.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e642c43b3f5522f8777ec9d20ee6badd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30057: diffsettings leaves out custom default settings

[Django]

#30057: diffsettings leaves out custom default settings
-+-
 Reporter:  orlnub123|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:  diffsettings,| Triage Stage:  Accepted
  settings   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * cc: Hasan Ramezani (added)
 * severity:  Normal => Release blocker


Comment:

 Marking as `master` release blocker since it's a regression introduced by
 49b679371fe9beddcd23a93b5fdbadea914f37f8 (#29236).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ce207ebb73ffbd90f0bef812c02d0a46%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30057: diffsettings leaves out custom default settings

[Django]

#30057: diffsettings leaves out custom default settings
-+-
 Reporter:  orlnub123|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:  diffsettings,| Triage Stage:  Accepted
  settings   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.64a0858d7e346db198dd7d05649c4eec%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30057: diffsettings leaves out custom default settings

[Django]

#30057: diffsettings leaves out custom default settings
-+-
   Reporter:  orlnub123  |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Core   |Version:  master
  (Management commands)  |   Keywords:  diffsettings,
   Severity:  Normal |  settings
   Triage Stage: |  Has patch:  1
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 If you've manually configured the settings with default settings that
 differ from the default they won't show up if you run the diffsettings
 command. This is only observable on master as before 49b6793 the settings
 were forcefully setup, replacing the manually configured settings.

 The reason this happens is because `module_to_dict` reads the settings
 from the `__dict__`. If you haven't manually configured your settings this
 is fine because the default wrapped settings object preassigns all
 settings to the `__dict__`. Since `UserSettingsHolder`, the class that
 wraps manually configured settings, relies on the `__dir__` +
 `__getattr__` pattern which allows the underlying default settings object
 to be dynamic it doesn't store settings from the default settings in its
 `__dict__`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.b893cca58cbf40a8e872b5a818c38bf0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.