Re: [Django] #30413: admin_views.test_multidb fails with persistent test SQLite database.

[Django]

#30413: admin_views.test_multidb fails with persistent test SQLite database.
-+-
 Reporter:  Daniel Hahler|Owner:  Farhaan
 |  Bukhsh
 Type:  Bug  |   Status:  closed
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"664c98f1f8c63a932a9c767a7364a6a1826799bb" 664c98f1]:
 {{{
 #!CommitTicketReference repository=""
 revision="664c98f1f8c63a932a9c767a7364a6a1826799bb"
 Fixed #30413 -- Fixed test database signature on SQLite when test database
 name is provided.

 Previously, the same signature was created for multiple in-memory
 databases on SQLite when they had tests databases names
 DATABASES['TEST']['NAME'].
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.88b77e602d28e97b4abfaf51cb2ecec3%40djangoproject.com.

Re: [Django] #30413: admin_views.test_multidb fails with persistent test SQLite database.

[Django]

#30413: admin_views.test_multidb fails with persistent test SQLite database.
-+-
 Reporter:  Daniel Hahler|Owner:  Farhaan
 |  Bukhsh
 Type:  Bug  |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.c0dbb841399f7a15c7ceaced5f632f09%40djangoproject.com.

Re: [Django] #30413: admin_views.test_multidb fails with persistent test SQLite database.

[Django]

#30413: admin_views.test_multidb fails with persistent test SQLite database.
-+-
 Reporter:  Daniel Hahler|Owner:  Farhaan
 |  Bukhsh
 Type:  Bug  |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by felixxm):

 I think we should add `tests/backends/sqlite/test_creation.py` with
 regressions tests for `test_db_signature()`, you can take a look at
 `tests/backends/base/test_creation.py` with similar tests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.bc7aa01198941f3ea934589767cbb4e2%40djangoproject.com.

Re: [Django] #30413: admin_views.test_multidb fails with persistent test SQLite database.

[Django]

#30413: admin_views.test_multidb fails with persistent test SQLite database.
-+-
 Reporter:  Daniel Hahler|Owner:  Farhaan
 |  Bukhsh
 Type:  Bug  |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Farhaan Bukhsh):

 Hey, I am able to replicate this bug and was able to fix it as well with
 the help of https://github.com/django/django/pull/11678, but the point I
 am stuck at is how to test it,
 I am not able to manipulate the `cls` variable so the next option that is
 left is create a file like `test_sqlite` and pass it as a parameter in
 `runtests`, should I be doing that?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.4d88967f7402b62687e4a82fa2a7d33f%40djangoproject.com.

Re: [Django] #30413: admin_views.test_multidb fails with persistent test SQLite database.

[Django]

#30413: admin_views.test_multidb fails with persistent test SQLite database.
-+-
 Reporter:  Daniel Hahler|Owner:  Farhaan
 |  Bukhsh
 Type:  Bug  |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Farhaan Bukhsh):

 * owner:  Ngalim Siregar => Farhaan Bukhsh


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.0e2f14699762ea54257bc98a696e6393%40djangoproject.com.

Re: [Django] #30413: admin_views.test_multidb fails with persistent test SQLite database.

[Django]

#30413: admin_views.test_multidb fails with persistent test SQLite database.
-+-
 Reporter:  Daniel Hahler|Owner:  Ngalim
 |  Siregar
 Type:  Bug  |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.106eb09084c217d4455043589251378f%40djangoproject.com.

Re: [Django] #30413: admin_views.test_multidb fails with persistent test SQLite database.

[Django]

#30413: admin_views.test_multidb fails with persistent test SQLite database.
-+-
 Reporter:  Daniel Hahler|Owner:  Ngalim
 |  Siregar
 Type:  Bug  |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by felixxm:

Old description:

> I've tried using persistent SQLite databases for the tests (to make use
> of
> `--keepdb`), but at least some
> tsbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
> + export PATHest fails with:
>
> > sqlite3.OperationalError: database is locked
>
> This is not an issue when only using `TEST["NAME"]` with "default" (which
> is good enough in terms of performance).
>
> {{{
> diff --git i/tests/test_sqlite.py w/tests/test_sqlite.py
> index f1b65f7d01..9ce4e32e14 100644
> --- i/tests/test_sqlite.py
> +++ w/tests/test_sqlite.py
> @@ -15,9 +15,15 @@
>  DATABASES = {
>  'default': {
>  'ENGINE': 'django.db.backends.sqlite3',
> +'TEST': {
> +'NAME': 'test_default.sqlite3'
> +},
>  },
>  'other': {
>  'ENGINE': 'django.db.backends.sqlite3',
> +'TEST': {
> +'NAME': 'test_other.sqlite3'
> +},
>  }
>  }
> }}}
>
> {{{
> % tests/runtests.py admin_views.test_multidb -v 3 --keepdb --parallel 1
> …
> Operations to perform:
>   Synchronize unmigrated apps: admin_views, auth, contenttypes, messages,
> sessions, staticfiles
>   Apply all migrations: admin, sites
> Running pre-migrate handlers for application contenttypes
> Running pre-migrate handlers for application auth
> Running pre-migrate handlers for application sites
> Running pre-migrate handlers for application sessions
> Running pre-migrate handlers for application admin
> Running pre-migrate handlers for application admin_views
> Synchronizing apps without migrations:
>   Creating tables...
> Running deferred SQL...
> Running migrations:
>   No migrations to apply.
> Running post-migrate handlers for application contenttypes
> Running post-migrate handlers for application auth
> Running post-migrate handlers for application sites
> Running post-migrate handlers for application sessions
> Running post-migrate handlers for application admin
> Running post-migrate handlers for application admin_views
> System check identified no issues (0 silenced).
> ERROR
>
> ==
> ERROR: setUpClass (admin_views.test_multidb.MultiDatabaseTests)
> --
> Traceback (most recent call last):
>   File "…/Vcs/django/django/db/backends/utils.py", line 84, in _execute
> return self.cursor.execute(sql, params)
>   File "…/Vcs/django/django/db/backends/sqlite3/base.py", line 391, in
> execute
> return Database.Cursor.execute(self, query, params)
> sqlite3.OperationalError: database is locked
>
> The above exception was the direct cause of the following exception:
>
> Traceback (most recent call last):
>   File "…/Vcs/django/django/test/testcases.py", line 1137, in setUpClass
> cls.setUpTestData()
>   File "…/Vcs/django/tests/admin_views/test_multidb.py", line 40, in
> setUpTestData
> username='admin', password='something', email='t...@test.org',
>   File "…/Vcs/django/django/contrib/auth/models.py", line 158, in
> create_superuser
> return self._create_user(username, email, password, **extra_fields)
>   File "…/Vcs/django/django/contrib/auth/models.py", line 141, in
> _create_user
> user.save(using=self._db)
>   File "…/Vcs/django/django/contrib/auth/base_user.py", line 66, in save
> super().save(*args, **kwargs)
>   File "…/Vcs/django/django/db/models/base.py", line 741, in save
> force_update=force_update, update_fields=update_fields)
>   File "…/Vcs/django/django/db/models/base.py", line 779, in save_base
> force_update, using, update_fields,
>   File "…/Vcs/django/django/db/models/base.py", line 870, in _save_table
> result = self._do_insert(cls._base_manager, using, fields, update_pk,
> raw)
>   File "…/Vcs/django/django/db/models/base.py", line 908, in _do_insert
> using=using, raw=raw)
>   File "…/Vcs/django/django/db/models/manager.py", line 82, in
> manager_method
> return getattr(self.get_queryset(), name)(*args, **kwargs)
>   File "…/Vcs/django/django/db/models/query.py", line 1175, in _insert
> return query.get_compiler(using=us

Re: [Django] #30413: admin_views.test_multidb fails with persistent test SQLite database.

[Django]

#30413: admin_views.test_multidb fails with persistent test SQLite database.
-+-
 Reporter:  Daniel Hahler|Owner:  Ngalim
 |  Siregar
 Type:  Bug  |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ngalim Siregar):

 * has_patch:  0 => 1


Old description:

> I've tried using persistent SQLite databases for the tests (to make use
> of
> `--keepdb`), but at least some test fails with:
>
> > sqlite3.OperationalError: database is locked
>
> This is not an issue when only using `TEST["NAME"]` with "default" (which
> is good enough in terms of performance).
>
> {{{
> diff --git i/tests/test_sqlite.py w/tests/test_sqlite.py
> index f1b65f7d01..9ce4e32e14 100644
> --- i/tests/test_sqlite.py
> +++ w/tests/test_sqlite.py
> @@ -15,9 +15,15 @@
>  DATABASES = {
>  'default': {
>  'ENGINE': 'django.db.backends.sqlite3',
> +'TEST': {
> +'NAME': 'test_default.sqlite3'
> +},
>  },
>  'other': {
>  'ENGINE': 'django.db.backends.sqlite3',
> +'TEST': {
> +'NAME': 'test_other.sqlite3'
> +},
>  }
>  }
> }}}
>
> {{{
> % tests/runtests.py admin_views.test_multidb -v 3 --keepdb --parallel 1
> …
> Operations to perform:
>   Synchronize unmigrated apps: admin_views, auth, contenttypes, messages,
> sessions, staticfiles
>   Apply all migrations: admin, sites
> Running pre-migrate handlers for application contenttypes
> Running pre-migrate handlers for application auth
> Running pre-migrate handlers for application sites
> Running pre-migrate handlers for application sessions
> Running pre-migrate handlers for application admin
> Running pre-migrate handlers for application admin_views
> Synchronizing apps without migrations:
>   Creating tables...
> Running deferred SQL...
> Running migrations:
>   No migrations to apply.
> Running post-migrate handlers for application contenttypes
> Running post-migrate handlers for application auth
> Running post-migrate handlers for application sites
> Running post-migrate handlers for application sessions
> Running post-migrate handlers for application admin
> Running post-migrate handlers for application admin_views
> System check identified no issues (0 silenced).
> ERROR
>
> ==
> ERROR: setUpClass (admin_views.test_multidb.MultiDatabaseTests)
> --
> Traceback (most recent call last):
>   File "…/Vcs/django/django/db/backends/utils.py", line 84, in _execute
> return self.cursor.execute(sql, params)
>   File "…/Vcs/django/django/db/backends/sqlite3/base.py", line 391, in
> execute
> return Database.Cursor.execute(self, query, params)
> sqlite3.OperationalError: database is locked
>
> The above exception was the direct cause of the following exception:
>
> Traceback (most recent call last):
>   File "…/Vcs/django/django/test/testcases.py", line 1137, in setUpClass
> cls.setUpTestData()
>   File "…/Vcs/django/tests/admin_views/test_multidb.py", line 40, in
> setUpTestData
> username='admin', password='something', email='t...@test.org',
>   File "…/Vcs/django/django/contrib/auth/models.py", line 158, in
> create_superuser
> return self._create_user(username, email, password, **extra_fields)
>   File "…/Vcs/django/django/contrib/auth/models.py", line 141, in
> _create_user
> user.save(using=self._db)
>   File "…/Vcs/django/django/contrib/auth/base_user.py", line 66, in save
> super().save(*args, **kwargs)
>   File "…/Vcs/django/django/db/models/base.py", line 741, in save
> force_update=force_update, update_fields=update_fields)
>   File "…/Vcs/django/django/db/models/base.py", line 779, in save_base
> force_update, using, update_fields,
>   File "…/Vcs/django/django/db/models/base.py", line 870, in _save_table
> result = self._do_insert(cls._base_manager, using, fields, update_pk,
> raw)
>   File "…/Vcs/django/django/db/models/base.py", line 908, in _do_insert
> using=using, raw=raw)
>   File "…/Vcs/django/django/db/models/manager.py", line 82, in
> manager_method
> return getattr(self.get_queryset(), name)(*args, **kwargs)
>   File "…/Vcs/django/django/db/models/query.py", line 1175, in _insert
> return query.get_compiler(using=using).execute_sql(return_id)
>   File "…/Vcs/djang

Re: [Django] #30413: admin_views.test_multidb fails with persistent test SQLite database.

[Django]

#30413: admin_views.test_multidb fails with persistent test SQLite database.
-+-
 Reporter:  Daniel Hahler|Owner:  Ngalim
 |  Siregar
 Type:  Bug  |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ngalim Siregar):

 * owner:  nobody => Ngalim Siregar
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.f0a3ce3c2a64557ebb3c69cd796355f1%40djangoproject.com.

Re: [Django] #30413: admin_views.test_multidb fails with persistent test SQLite database. (was: tests: admin_views.test_multidb fails with persistent sqlite: OperationalError: database is locked)

[Django]

#30413: admin_views.test_multidb fails with persistent test SQLite database.
---+
 Reporter:  Daniel Hahler  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by felixxm):

 * version:  2.2 => master
 * stage:  Unreviewed => Accepted


Comment:

 Reproduced at 0dd2308cf6f559a4f4b50edd7c005c7cf025d1aa.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.6669d3af84790bb163cc80b08b47fd1d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.