Re: [Django] #30505: Ordering of Field.choices is significant for makemigrations

[Django]

#30505: Ordering of Field.choices is significant for makemigrations
-+-
 Reporter:  Marnanel Thurman |Owner:  Caio
 Type:   |  Ariede
  Cleanup/optimization   |   Status:  closed
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"d6d65c1e87d0da52e43d6359290a7b3f77367576" d6d65c1]:
 {{{
 #!CommitTicketReference repository=""
 revision="d6d65c1e87d0da52e43d6359290a7b3f77367576"
 [2.2.x] Fixed #30505 -- Doc'd how changes in the order of Field.choices
 affect migrations.

 Backport of 5248abe9b0425c1fc989c60a55860cdb4d135bcf from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.5e3f3eaf45ebf6f5050b46f55d134be3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30505: Ordering of Field.choices is significant for makemigrations

[Django]

#30505: Ordering of Field.choices is significant for makemigrations
-+-
 Reporter:  Marnanel Thurman |Owner:  Caio
 Type:   |  Ariede
  Cleanup/optimization   |   Status:  closed
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"5248abe9b0425c1fc989c60a55860cdb4d135bcf" 5248abe9]:
 {{{
 #!CommitTicketReference repository=""
 revision="5248abe9b0425c1fc989c60a55860cdb4d135bcf"
 Fixed #30505 -- Doc'd how changes in the order of Field.choices affect
 migrations.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.9e0c380e3062db45c44d2745ef2eaedd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30505: Ordering of Field.choices is significant for makemigrations

[Django]

#30505: Ordering of Field.choices is significant for makemigrations
-+-
 Reporter:  Marnanel Thurman |Owner:  Caio
 Type:   |  Ariede
  Cleanup/optimization   |   Status:  assigned
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Caio Ariede):

 * has_patch:  0 => 1


Comment:

 new [https://github.com/django/django/pull/11429 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.cf1f50f96ea3afce5442f7aa95711c0e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30505: Ordering of Field.choices is significant for makemigrations

[Django]

#30505: Ordering of Field.choices is significant for makemigrations
-+-
 Reporter:  Marnanel Thurman |Owner:  Caio
 Type:   |  Ariede
  Cleanup/optimization   |   Status:  assigned
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * has_patch:  1 => 0
 * type:  Bug => Cleanup/optimization


Comment:

 This should be clarified in documentation, maybe "{{{A
 :term:`sequence`}}}" instead of "{{{An iterable ...}}}" or a note about
 ordering.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.a1bdc7f6d4efcbacbfcfdac405785bef%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30505: Ordering of Field.choices is significant for makemigrations

[Django]

#30505: Ordering of Field.choices is significant for makemigrations
--+---
 Reporter:  Marnanel Thurman  |Owner:  Caio Ariede
 Type:  Bug   |   Status:  assigned
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+---
Changes (by Caio Ariede):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/11421 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.53400765c56ca324159c6d86c2848ca3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30505: Ordering of Field.choices is significant for makemigrations

[Django]

#30505: Ordering of Field.choices is significant for makemigrations
--+---
 Reporter:  Marnanel Thurman  |Owner:  Caio Ariede
 Type:  Bug   |   Status:  assigned
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+---
Changes (by Caio Ariede):

 * status:  new => assigned
 * owner:  nobody => Caio Ariede


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4310b4a307109b7b96009931e30b4f66%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30505: Ordering of Field.choices is significant for makemigrations

[Django]

#30505: Ordering of Field.choices is significant for makemigrations
--+
 Reporter:  Marnanel Thurman  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Marnanel Thurman):

 * Attachment "ticket30505.tar.bz2" added.

 Test case. Running makemigrations will create new migrations indefinitely

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.010371ec6931ce1db34ad409ba2a0466%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30505: Ordering of Field.choices is significant for makemigrations

[Django]

#30505: Ordering of Field.choices is significant for makemigrations
--+
 Reporter:  Marnanel Thurman  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Carlton Gibson):

 * cc: Carlton Gibson (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.c6b4092ec1f0231d054e1bb6e564647e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30505: Ordering of Field.choices is significant for makemigrations

[Django]

#30505: Ordering of Field.choices is significant for makemigrations
--+
 Reporter:  Marnanel Thurman  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Carlton Gibson):

 * type:  Uncategorized => Bug
 * stage:  Unreviewed => Accepted


Comment:

 > I can put a test case together if you like.

 Yes, please. Or a sample project that we can just run to play with.
 (Pending that I'll assume it reproduces. )

 I need to look deeper to see exactly what's going on here, but there's at
 least a documentation issue:

 > An iterable (e.g., a list or tuple) ...

 If it's **required** to be ordered it should say `sequence` or similar.

 I'd suspect it's just been assumed that a list or tuple would be used.
 Maybe we can relax that. If not we'll have to change the docs.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.40c532fa329145029a83bc09c27d463a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30505: Ordering of Field.choices is significant for makemigrations

[Django]

#30505: Ordering of Field.choices is significant for makemigrations
+
   Reporter:  Marnanel Thurman  |  Owner:  nobody
   Type:  Uncategorized | Status:  new
  Component:  Migrations|Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 makemigrations regards the ordering of Field.choices as significant. The
 docs require Field.choices to be an iterable, but not to be well-ordered.
 If Field.choices is not well-ordered, then almost every run of
 makemigrations will treat the model as changed, even without changes to
 the code.

 The ordering of Field.choices is not significant anywhere else, except as
 a cosmetic detail in the admin.

 This bug even occurs in
 {{{
 ACTIVITY_TYPES = set(['Create', 'Update', 'Delete'])

 []
 f_type = models.CharField(
 max_length=255,
 choices=[(x,x) for x in ACTIVITY_TYPES],
 )
 }}}

 I would have expected the value of Field.choices here to be well-ordered
 (and sorted) but makemigrations still flags this as changed every time.

 I can put a test case together if you like.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.1605e1eaa3f8626552e220bc5ef7debb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.