Re: [Django] #30677: Improve Exception Message In Test Client when a None Value is provided to a POST.

[Django]

#30677: Improve Exception Message In Test Client when a None Value is provided 
to a
POST.
-+-
 Reporter:  Keith Gray   |Owner:  Swatantra
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  test client post | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by felixxm):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/11638 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.5caaf1e607b435cc10d0c007b8e8eba2%40djangoproject.com.

Re: [Django] #30677: Improve Exception Message In Test Client when a None Value is provided to a POST.

[Django]

#30677: Improve Exception Message In Test Client when a None Value is provided 
to a
POST.
-+-
 Reporter:  Keith Gray   |Owner:  Swatantra
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  test client post | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Swatantra):

 * status:  new => assigned
 * owner:  nobody => Swatantra


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.a8fd3b45d21a3537dd42c0bfb28b7a50%40djangoproject.com.

Re: [Django] #30677: Improve Exception Message In Test Client when a None Value is provided to a POST.

[Django]

#30677: Improve Exception Message In Test Client when a None Value is provided 
to a
POST.
--+
 Reporter:  Keith Gray|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  test client post  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by felixxm):

 * easy:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.047451cafb893a84c1bcea7c5da3a4d9%40djangoproject.com.

Re: [Django] #30677: Improve Exception Message In Test Client when a None Value is provided to a POST.

[Django]

#30677: Improve Exception Message In Test Client when a None Value is provided 
to a
POST.
--+
 Reporter:  Keith Gray|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  test client post  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by felixxm):

 Django 3.0 supports Python 3.6+, nevertheless please don't use f-strings
 (see #29988).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.4b5bc76e837b5bd4b5048d8d88c6d466%40djangoproject.com.

Re: [Django] #30677: Improve Exception Message In Test Client when a None Value is provided to a POST.

[Django]

#30677: Improve Exception Message In Test Client when a None Value is provided 
to a
POST.
--+
 Reporter:  Keith Gray|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  test client post  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Keith Gray):

 I will change the wording and create a PR. I have one more question, can I
 use f-strings since this is going into master? I cloned the repo and tried
 to run the tests in a Python 3.5 environment but it wouldn't let me.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1de293783ef1b647d1afd4f60d0b19f3%40djangoproject.com.

Re: [Django] #30677: Improve Exception Message In Test Client when a None Value is provided to a POST. (was: Improve Exception Message In Test Client when a None Value is provided to a POST)

[Django]

#30677: Improve Exception Message In Test Client when a None Value is provided 
to a
POST.
--+
 Reporter:  Keith Gray|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  test client post  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by felixxm):

 * has_patch:  1 => 0
 * version:  2.2 => master


Comment:

 I agree with Markus' suggestion. Can you create PR via GitHub?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.bf98def0f8ac286b7b36835b80d57824%40djangoproject.com.

Re: [Django] #30677: Improve Exception Message In Test Client when a None Value is provided to a POST

[Django]

#30677: Improve Exception Message In Test Client when a None Value is provided 
to a
POST
--+
 Reporter:  Keith Gray|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  2.2
 Severity:  Normal|   Resolution:
 Keywords:  test client post  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Markus Holtermann):

 * stage:  Unreviewed => Accepted


Comment:

 I like your suggestion. I would suggest a slightly different wording:
 {{{#!python
 raise TypeError(
 "Cannot encode None for key '%s' as POST data. Did you
 mean "
 "to pass an empty string or omit the value?" % key
 )
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.58240b11367bcfcde4f510a8d1ac19b2%40djangoproject.com.

Re: [Django] #30677: Improve Exception Message In Test Client when a None Value is provided to a POST

[Django]

#30677: Improve Exception Message In Test Client when a None Value is provided 
to a
POST
-+-
 Reporter:  idahogray|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Testing framework|  Version:  2.2
 Severity:  Normal   |   Resolution:
 Keywords:  test client post | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by idahogray):

 * has_patch:  0 => 1


Old description:

> I am upgrading to 2.2.1 from 2.0.5 and my tests are failing due to a
> change in the test client:
> https://docs.djangoproject.com/en/2.2/releases/2.2/#miscellaneous. It now
> throws an exception if a None value is provided in data given to a POST.
> I would like to propose an improvement to the message to display the
> offending Key and Value that generate the exception.

New description:

 I am upgrading to 2.2.1 from 2.0.5 and my tests are failing due to a
 change in the test client:
 https://docs.djangoproject.com/en/2.2/releases/2.2/#miscellaneous. It now
 throws an exception if a None value is provided in data given to a POST. I
 would like to propose an improvement to the message to display the
 offending Key and Value that generate the exception.

 I have a proposed change in my fork on github:
 https://github.com/idahogray/django/tree/ticket_30677

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.881da481321c2c0b4f97e3ee436d2e26%40djangoproject.com.

[Django] #30677: Improve Exception Message In Test Client when a None Value is provided to a POST

[Django]

#30677: Improve Exception Message In Test Client when a None Value is provided 
to a
POST
-+-
   Reporter:  idahogray  |  Owner:  nobody
   Type: | Status:  new
  Cleanup/optimization   |
  Component:  Testing|Version:  2.2
  framework  |
   Severity:  Normal |   Keywords:  test client post
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 I am upgrading to 2.2.1 from 2.0.5 and my tests are failing due to a
 change in the test client:
 https://docs.djangoproject.com/en/2.2/releases/2.2/#miscellaneous. It now
 throws an exception if a None value is provided in data given to a POST. I
 would like to propose an improvement to the message to display the
 offending Key and Value that generate the exception.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.61c15af61e229fec42475077d3865164%40djangoproject.com.