Re: [Django] #35192: Support injecting custom context into widget templates

[Django]

#35192: Support injecting custom context into widget templates
-+-
 Reporter:  Oxan van Leeuwen |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Forms|  Version:  5.0
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Christophe Henry):

 * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107019006d77690-a3db392e-d730-4f85-ac32-12254004d62d-00%40eu-central-1.amazonses.com.

Re: [Django] #35192: Support injecting custom context into widget templates

[Django]

#35192: Support injecting custom context into widget templates
-+-
 Reporter:  Oxan van Leeuwen |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Forms|  Version:  5.0
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Christophe Henry):

 Why was this ticket closed? I think allowing to use a custom `BoundField`
 would be a nice enhancement.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107019006d2e4b1-2f38edd7-8c40-4383-b3be-ceba515f0a79-00%40eu-central-1.amazonses.com.

Re: [Django] #35192: Support injecting custom context into widget templates

[Django]

#35192: Support injecting custom context into widget templates
-+-
 Reporter:  Oxan van Leeuwen |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Forms|  Version:  5.0
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Oxan van Leeuwen):

 I think a custom `BoundField` could also work indeed. I'm by no means
 married to my proposal, it was just the most sensible thing I could come
 up with :)

 I agree that it could be valuable to have a wider discussion about the
 design here, but unfortunately I don't have the bandwidth at the moment to
 drive such a discussion.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc57c9f5d-1ad65513-f477-4a9a-b05f-690f727f3320-00%40eu-central-1.amazonses.com.

Re: [Django] #35192: Support injecting custom context into widget templates

[Django]

#35192: Support injecting custom context into widget templates
-+-
 Reporter:  Oxan van Leeuwen |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Forms|  Version:  5.0
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by David Smith):

 * status:  new => closed
 * resolution:   => needsinfo

Comment:

 >it's currently almost impossible to add an invalid CSS class to widgets
 that have errors.

 I agree that it is currently tricky to add invalid CSS to widgets
 (``) and would like to see this eased with Django itself. That was
 one of my conclusions when I attempted to write a tailwind styled form
 using just Django itself. See
 [https://smithdc.uk/blog/2023/bootstrap_form_in_vanilla_django/ blog
 post].

 I think there's a few different design options here, in addition to your
 suggestion above I see a couple of additional options.

 - A template filter/tag. This is the approach used by both django-widget-
 tweaks and django-crispy-forms.
 - Easing use of a custom `BoundField`. Currently you need to override each
 field's `get_bound_field()` to achieve this. Maybe this could also be set
 on the form renderer? This would also allow folk to make other
 customisations such as #35191 without adding a long list of options to the
 renderer.

 It's probably worth starting a discussion on the django forum to gain
 wider views from the community. I'm happy to help with this discussion. As
 I think we need a wider discussion on the design I'll mark as 'needsinfo'
 for now.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dabe81c0f-26a6238e-45b9-451e-8d0a-24a626cfcfd6-00%40eu-central-1.amazonses.com.

Re: [Django] #35192: Support injecting custom context into widget templates

[Django]

#35192: Support injecting custom context into widget templates
-+-
 Reporter:  Oxan van Leeuwen |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Forms|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * cc: David Smith (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018da7655c44-2bb1ad05-8295-4ba1-bb70-78b70c0b2ced-00%40eu-central-1.amazonses.com.

[Django] #35192: Support injecting custom context into widget templates

[Django]

#35192: Support injecting custom context into widget templates
+
   Reporter:  oxan  |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Forms |Version:  5.0
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 The context available to widget templates is currently very rigid and does
 not allow any customization. For example, it's currently almost impossible
 to add an `invalid` CSS class to widgets that have errors.

 I think my preferred solution would be to insert a call to a form renderer
 method in the callchain between `BoundField.as_widget()` and
 `Widget.render()`, which can be overridden by a custom renderer. It should
 receive the `BoundField` itself as an argument so that it has access to
 the current state. Something like the following sketch:

 {{{#!python
 class BoundField:
 def as_widget(self, widget=None, attrs=None, only_initial=False):
 ... # leave current code as-is, except for last call to
 widget.render()
 return self.form.renderer.render_widget(
 field=self,
 widget=widget,
 name=self.html_initial_name if only_initial else
 self.html_name,
 value=value,
 attrs=attrs,
 )

 class BaseRenderer:
 def render_widget(self, field, widget, name, value, attrs=None):
 # this can be overridden to add/change/remove `attrs`, or to
 render the widget in an entirely different way
 return widget.render(name, value, attrs)
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018da3321a32-1f56b4f8-6da1-471c-9e7e-a6aa7866e9df-00%40eu-central-1.amazonses.com.