Re: [Django] #8851: Add a default option to list_filter in the admin interface

[Django]

#8851: Add a default option to list_filter in the admin interface
-+-
 Reporter:  Riskable |Owner:  Andrew
 |  Aikman
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  admin, list_filter,  | Triage Stage:  Accepted
  default|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Will Emmerson):

 I recently had a similar requirement to set a default `list_filter` and
 was surprised how difficult it was and that the solutions aren't that
 great.
 The solutions are basically:

 a) write a custom `ListFilter` which defaults to filtering something: but
 this means the get params aren't in the url when you initial go to that
 changelist, it's a pain having to make a custom ListFilter, and it can
 mess with the 'All' option.
 b) Override `ModelAdmin.changelist_view` and mess with the GET params
 there in an ugly way using request.META, and maybe do a redirect: but then
 you're introducing another unnecessary request.

 It seems the correct, RESTful way to do this is to include the query
 params in the model link itself. I managed to do this using
 `AdminSite.get_app_list` but it's far from perfect:


 {{{
 class MyAdminSite(admin.AdminSite):
 def get_app_list(self, request, app_label=None):
 app_list = super().get_app_list(request, app_label)
 for app_dict in app_list:
 for model_dict in app_dict["models"]:
 model = model_dict["model"]
 model_admin = self._registry[model]
 if default_filters := getattr(model_admin,
 "default_list_filters", None):
 model_dict["admin_url"] += "?" +
 urlencode(default_filters)

 return app_list
 }}}

 This just picks up `ModelAdmin.default_list_filters` if it exists and adds
 them to the url. But unfortunately it breaks the yellow highlighting of
 the current model because it's not expecting there to be query params
 there (`contrib/templates/admin/app_list.html`):

 {{{
 {% for model in app.models %}
   
 {% if model.admin_url %}
   {{ model.name }}
 {% else %}
   {{ model.name }}
 {% endif %}
 }}}

 `if model.admin_url in request.path|urlencode` returns false when on the
 right page, but it would work if `request.get_full_path` was used instead.

 Obviously it'd be a lot better if this functionality was built in, is it
 worth me creating a PR to do this or is adding GET params to the admin
 urls a terrible idea? Will it break other things?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701889fa8ee4e-5af77430-6649-408f-b09e-214f693cb527-00%40eu-central-1.amazonses.com.

Re: [Django] #8851: Add a default option to list_filter in the admin interface

[Django]

#8851: Add a default option to list_filter in the admin interface
-+-
 Reporter:  Riskable |Owner:  Andrew
 |  Aikman
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  admin, list_filter,  | Triage Stage:  Accepted
  default|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Doug Harris):

 * cc: Doug Harris (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701838b605039-1fa29226-d8c9-4866-8303-bf12114d180c-00%40eu-central-1.amazonses.com.

Re: [Django] #8851: Add a default option to list_filter in the admin interface

[Django]

#8851: Add a default option to list_filter in the admin interface
-+-
 Reporter:  Riskable |Owner:  Andrew
 |  Aikman
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  admin, list_filter,  | Triage Stage:  Accepted
  default|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Andrew Aikman):

 * owner:  (none) => Andrew Aikman
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701836f2114a9-c4a2a63c-a3ad-442e-881f-0a8bcb356f92-00%40eu-central-1.amazonses.com.

Re: [Django] #8851: Add a default option to list_filter in the admin interface

[Django]

#8851: Add a default option to list_filter in the admin interface
-+-
 Reporter:  Riskable |Owner:  (none)
 |
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  admin, list_filter,  | Triage Stage:  Accepted
  default|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Aman Pandey):

 * owner:  Aman Pandey => (none)
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070183418e8d78-e967cbf0-7ee9-451d-b577-d15b43909d7f-00%40eu-central-1.amazonses.com.

Re: [Django] #8851: Add a default option to list_filter in the admin interface

[Django]

#8851: Add a default option to list_filter in the admin interface
-+-
 Reporter:  Riskable |Owner:  Aman
 |  Pandey
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  admin, list_filter,  | Triage Stage:  Accepted
  default|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Aman Pandey):

 * owner:  (none) => Aman Pandey
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018337bb6588-9fcfd0c6-8cdb-409b-8b79-bb5550c73d14-00%40eu-central-1.amazonses.com.

Re: [Django] #8851: Add a default option to list_filter in the admin interface

[Django]

#8851: Add a default option to list_filter in the admin interface
-+-
 Reporter:  Riskable |Owner:  (none)
 |
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  admin, list_filter,  | Triage Stage:  Accepted
  default|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181ae67da97-b87bed64-7400-4532-b70b-6552a775b97b-00%40eu-central-1.amazonses.com.

Re: [Django] #8851: Add a default option to list_filter in the admin interface

[Django]

#8851: Add a default option to list_filter in the admin interface
-+-
 Reporter:  Riskable |Owner:  (none)
 |
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  admin, list_filter,  | Triage Stage:  Accepted
  default|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  Harro => (none)
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181ae67c50b-dfb4bf9c-5df3-405e-a5b0-5d16adb8a17d-00%40eu-central-1.amazonses.com.

Re: [Django] #8851: Add a default option to list_filter in the admin interface

[Django]

#8851: Add a default option to list_filter in the admin interface
-+-
 Reporter:  Riskable |Owner:  Harro
 |
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin, list_filter,  | Triage Stage:  Accepted
  default|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Narbonne):

 * cc: Narbonne (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/093.ad7f180336b7743e0dd152397136a1b8%40djangoproject.com.

Re: [Django] #8851: Add a default option to list_filter in the admin interface

[Django]

#8851: Add a default option to list_filter in the admin interface
-+-
 Reporter:  Riskable |Owner:  Harro
 |
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin, list_filter,  | Triage Stage:  Accepted
  default|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Aymeric Augustin):

 Furthermore, while `SimpleListFilter` is a public API, `FieldListFilter`
 isn't. The docs note:

 > The `FieldListFilter` API is considered internal and might be changed.

 There's no way to make a good list filter for handling soft-deletes with
 `SimpleListFilter` because it defaults to showing everything, which is the
 main behavior that needs changing.

 Here's how I did it with `FieldListFilter`:

 {{{
 class DeactivableListFilter(admin.ListFilter):

 title = _("active")
 parameter_name = 'active'

 def __init__(self, request, params, model, model_admin):
 super().__init__(request, params, model, model_admin)
 if self.parameter_name in params:
 value = params.pop(self.parameter_name)
 self.used_parameters[self.parameter_name] = value

 def show_all(self):
 return self.used_parameters.get(self.parameter_name) == '__all__'

 def has_output(self):
 return True

 def choices(self, changelist):
 return [
 {
 'selected': self.show_all(),
 'query_string':
 changelist.get_query_string({self.parameter_name: '__all__'}),
 'display': "Tout",
 },
 {
 'selected': not self.show_all(),
 'query_string':
 changelist.get_query_string(remove=[self.parameter_name]),
 'display': "Actif",
 },
 ]

 def queryset(self, request, queryset):
 if not self.show_all():
 return queryset.filter(active=True)

 def expected_parameters(self):
 return [self.parameter_name]
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/093.1a52573ae41e2029546d02b88e914c93%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #8851: Add a default option to list_filter in the admin interface

[Django]

#8851: Add a default option to list_filter in the admin interface
-+-
 Reporter:  Riskable |Owner:  Harro
 |
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin, list_filter,  | Triage Stage:  Accepted
  default|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Aymeric Augustin):

 * status:  closed => new
 * resolution:  wontfix =>


Comment:

 Sorry for the close / reopen ping-pong... I think this is a worthwhile
 feature request. For example, when using soft-delete, by default, you
 don't want soft-deleted objects to show up in the admin. The API proposed
 in https://github.com/django/django/pull/5579 is interesting.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/093.a5dfbd86892282534b6a8da8dff0977d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #8851: Add a default option to list_filter in the admin interface

[Django]

#8851: Add a default option to list_filter in the admin interface
-+-
 Reporter:  Riskable |Owner:  Harro
     |
 Type:  New feature  |   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:  admin, list_filter,  | Triage Stage:  Accepted
  default|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Jonas Haag):

 That's a lot of code to copy and paste, and it's probably going to break
 when changes to the admin are being made.

 I'd say reopen this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/093.7f150042c38c8e9b085a4a0c58d33726%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #8851: Add a default option to list_filter in the admin interface

[Django]

#8851: Add a default option to list_filter in the admin interface
-+-
 Reporter:  Riskable |Owner:  Harro
     |
 Type:  New feature  |   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:  admin, list_filter,  | Triage Stage:  Accepted
  default|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Harro):

 * status:  assigned => closed
 * resolution:   => wontfix


Comment:

 As said, there is a way to do this with a documented feature, so nothing
 to fix.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/093.5348cabb062b8b897dde3be2d183c84c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #8851: Add a default option to list_filter in the admin interface

[Django]

#8851: Add a default option to list_filter in the admin interface
-+-
 Reporter:  Riskable |Owner:  Harro
     |
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin, list_filter,  | Triage Stage:  Accepted
  default|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Harro):

 Ok, I found a much nicer solution for this whole thing, no need to do
 changes to urls at all.

 Say you have an is_archived flag on a model and you want to default filter
 the list to hide archived items:

 {{{
 class ArchivedListFilter(admin.SimpleListFilter):

 title = _('Archived')
 parameter_name = 'show_archived'

 def lookups(self, request, model_admin):
 return (
 ('all', _('Show all')),
 ('archived', _('Show archived only')),
 )

 def queryset(self, request, queryset):
 show_archived = request.GET.get('show_archived')
 if (show_archived == 'all'):
 return queryset.all()
 elif (show_archived == 'archived'):
 return queryset.filter(is_archived=True)
 return queryset.filter(is_archived=False)

 def choices(self, cl):
 yield {
 'selected': self.value() is None,
 'query_string': cl.get_query_string({},
 [self.parameter_name]),
 'display': _('Hide archived'),  # Changed All to Hide
 archived.
 }
 for lookup, title in self.lookup_choices:
 yield {
 'selected': self.value() == force_text(lookup),
 'query_string': cl.get_query_string({
 self.parameter_name: lookup,
 }, []),
 'display': title,
 }
 }}}

 Simply add this filter and by default it will filter and on filter values
 it will either show all items or only the archived items.

 Now it would be nice to be able to change the label in for "All" in the
 choices method without the need to override whole method, so maybe the
 only fix would be to move the label to a propery on SimpleListFilter so
 you can quickly override it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/093.25d6560721a085f823d08fe8124354eb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #8851: Add a default option to list_filter in the admin interface

[Django]

#8851: Add a default option to list_filter in the admin interface
-+-
 Reporter:  Riskable |Owner:  Harro
     |
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin, list_filter,  | Triage Stage:  Accepted
  default|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Harro):

 * has_patch:  1 => 0


Comment:

 Also see:
 https://github.com/django/django/pull/5579#issuecomment-360387527

 I think the solution to change the url linking to the list view is a much
 better one that what I've implemented, I'm closing my pull request and
 will do some research into the other solution.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/093.80434d7c5549a478c0d696172b23fe42%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #8851: Add a default option to list_filter in the admin interface

[Django]

#8851: Add a default option to list_filter in the admin interface
-+-
 Reporter:  Riskable |Owner:  Harro
     |
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin, list_filter,  | Triage Stage:  Accepted
  default|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Lightfoot):

 * cc: simon@… (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/093.5ca362b89fe4e9ec7b28bb2bef54432a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #8851: Add a default option to list_filter in the admin interface

[Django]

#8851: Add a default option to list_filter in the admin interface
-+-
 Reporter:  Riskable |Owner:  Harro
     |
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin, list_filter,  | Triage Stage:  Accepted
  default|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Andreas Pelme):

 * cc: andreas@… (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/093.02c0cb0021302bb06d66a1f35abd17ea%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #8851: Add a default option to list_filter in the admin interface

[Django]

#8851: Add a default option to list_filter in the admin interface
-+-
 Reporter:  Riskable |Owner:  Harro
     |
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin, list_filter,  | Triage Stage:  Accepted
  default|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Ready for checkin => Accepted


Comment:

 Asif set the "Ready for Checkin" flag without reviewing the patch.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/093.ce3563b4279f389a362554c8297f299b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #8851: Add a default option to list_filter in the admin interface

[Django]

#8851: Add a default option to list_filter in the admin interface
-+-
 Reporter:  Riskable |Owner:  Harro
     |
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin, list_filter,  | Triage Stage:  Ready for
  default|  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Asif Saifuddin Auvi):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/093.42e49a410877d75d672dda2e6153c5fa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #8851: Add a default option to list_filter in the admin interface (was: Please add a default option to list_filter in the admin interface)

[Django]

#8851: Add a default option to list_filter in the admin interface
-+-
 Reporter:  Riskable |Owner:  hvdklauw
     |
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin, list_filter,  | Triage Stage:  Accepted
  default|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:  0 => 1


Comment:

 Left some comments on the pull request. Not sure if the current approach
 is ideal with regard to reusing the choice logic from list filter classes.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/093.5e6831b54813fe01a317c0d0f07bd0b5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.