Re: [Django] #23628: AlterModelOptions should check for changes

[Django]

#23628: AlterModelOptions should check for changes
+--
 Reporter:  Naddiseo|Owner:  nobody
 Type:  Bug |   Status:  closed
Component:  Migrations  |  Version:  1.7
 Severity:  Normal  |   Resolution:  wontfix
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by timgraham):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 I don't think there's a good reason to say the ordering of permissions
 isn't important. For example, you might have a migration that indexes the
 permissions tuple to get a particular permission. Using `sorted()` as
 Baptiste suggested seems like the best solution to me.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.bbf0d58373278c33a794d7c689d698a9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23628: AlterModelOptions should check for changes

[Django]

#23628: AlterModelOptions should check for changes
+--
 Reporter:  Naddiseo|Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  1.7
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--

Comment (by Naddiseo):

 I don't think there's that much extra complexity: one possible solution:
 https://github.com/django/django/pull/3356

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.956499e8c761c852ebf61391ea64ac00%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23628: AlterModelOptions should check for changes

[Django]

#23628: AlterModelOptions should check for changes
+--
 Reporter:  Naddiseo|Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  1.7
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by bmispelon):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Hi,

 This actually depends on your Python version.
 On Python 3.3 and later, the order of dictionaries will change between
 different runs (that feature is called "hash randomization" if you want to
 look deeper).

 On earlier versions of Python though, that order is consistent so the
 autodetector doesn't see any changes and no new migrations are created.

 I'm not sure if this warrants the additional code complexity.
 If you need a consistent order here you could use an `OrderedDict` or user
 `permissions = sorted(PERM_DEFS.keys())`.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.257937b40cec65a1c55ad3dedd822fcf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.