Re: [Django] #26114: Removing Meta.db_table generates migration with wrong rename in comment (None)

[Django]

#26114: Removing Meta.db_table generates migration with wrong rename in comment
(None)
+
 Reporter:  dvinegla|Owner:  PREM1980
 Type:  Bug |   Status:  closed
Component:  Migrations  |  Version:  1.9
 Severity:  Normal  |   Resolution:  fixed
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"5da7e3f7fd24381195e557d807118130ddbc5152" 5da7e3f]:
 {{{
 #!CommitTicketReference repository=""
 revision="5da7e3f7fd24381195e557d807118130ddbc5152"
 Fixed #26114 -- Fixed AlterModelTable.describe() if db_table is None.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.921e7e39c8e6e300c36cdd867a0ed3a9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26114: Removing Meta.db_table generates migration with wrong rename in comment (None)

[Django]

#26114: Removing Meta.db_table generates migration with wrong rename in comment
(None)
+
 Reporter:  dvinegla|Owner:  PREM1980
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  1.9
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by timgraham):

 * has_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.eb5de6d50c732f3122f4a38b2f6dad85%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26114: Removing Meta.db_table generates migration with wrong rename in comment (None)

[Django]

#26114: Removing Meta.db_table generates migration with wrong rename in comment
(None)
+
 Reporter:  dvinegla|Owner:  PREM1980
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  1.9
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by PREM1980):

 The changes are made and here is the Github link.

 https://github.com/PREM1980/django

 Branch -  ticket_26114

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.14ed9f179cd29afb0b3d11d6c2e0836a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26114: Removing Meta.db_table generates migration with wrong rename in comment (None)

[Django]

#26114: Removing Meta.db_table generates migration with wrong rename in comment
(None)
+
 Reporter:  dvinegla|Owner:  PREM1980
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  1.9
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by timgraham):

 The change I proposed in comment 1 is about modifying
 `AlterModelTable.describe()`. The autodetector shouldn't be changed like
 that because then a migration changing the table name back to the default
 wouldn't be created.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.48137f3c52ec4bea92ffc60a5a9e159c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26114: Removing Meta.db_table generates migration with wrong rename in comment (None)

[Django]

#26114: Removing Meta.db_table generates migration with wrong rename in comment
(None)
+
 Reporter:  dvinegla|Owner:  PREM1980
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  1.9
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by PREM1980):

 I'm thinking the following, please review and provide your comments.


 When someone provides "None" as the new table name, we won't detect that
 as a change and just ignore it.

 
https://github.com/django/django/blob/fb4272f0e6bbdaa3e19ed5fde59fdb5ab5a33baf/django/db/migrations/autodetector.py#L962

 This is the new change that works.

 if old_db_table_name != new_db_table_name and new_db_table_name != None:
 self.add_operation(
 app_label,
 operations.AlterModelTable(
 name=model_name,
 table=new_db_table_name,
 )
 )

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.e45705355e92f20f57db2a1ac08bb789%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26114: Removing Meta.db_table generates migration with wrong rename in comment (None)

[Django]

#26114: Removing Meta.db_table generates migration with wrong rename in comment
(None)
+
 Reporter:  dvinegla|Owner:  PREM1980
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  1.9
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by PREM1980):

 * owner:  nobody => PREM1980
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.a13811d4b0cef504c0cc49947bf40e34%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26114: Removing Meta.db_table generates migration with wrong rename in comment (None) (was: Removing Meta.db_table generates migration with wrong rename (None))

[Django]

#26114: Removing Meta.db_table generates migration with wrong rename in comment
(None)
+
 Reporter:  dvinegla|Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  1.9
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by timgraham):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 I think we
 
[https://github.com/django/django/blob/fb4272f0e6bbdaa3e19ed5fde59fdb5ab5a33baf/django/db/migrations/operations/models.py#L316-L317
 don't have the needed information to put the actual name] in the comment,
 but perhaps we could replace `None` with something like `(default)`.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4e0689a9a10a9bec3a1b1ea08b45ad86%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.