Re: [Django] #26423: Make EmailValidator use HTML5 validation rather than more complicated regular expressions

[Django]

#26423: Make EmailValidator use HTML5 validation rather than more complicated
regular expressions
--+
 Reporter:  Tim Graham|Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Other)  |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Ülgen Sarıkavak):

 * cc: Ülgen Sarıkavak (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e505dde81-a0b77411-42f9-4f48-b443-dfcc19bcd707-00%40eu-central-1.amazonses.com.

Re: [Django] #26423: Make EmailValidator use HTML5 validation rather than more complicated regular expressions

[Django]

#26423: Make EmailValidator use HTML5 validation rather than more complicated
regular expressions
--+
 Reporter:  Tim Graham|Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Haris Ibrahim K. V.):

 * status:  assigned => new
 * owner:  Haris Ibrahim K. V. => (none)


Comment:

 Not maintaining the PR any more. Please do feel free to fork and submit a
 new PR.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6b38360421bb7988fd7b9390065f28f8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26423: Make EmailValidator use HTML5 validation rather than more complicated regular expressions

[Django]

#26423: Make EmailValidator use HTML5 validation rather than more complicated
regular expressions
-+-
 Reporter:  Tim Graham   |Owner:  Haris
 Type:   |  Ibrahim K. V.
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Other) |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Max Nordlund):

 I came across this today and realized that the current regexp, in 1.10.5,
 contains a type. At least I think it does, since the opening bracket of
 the second range in `user_regex` is escaped, but it shouldn't be.

 Anyway, I threw together a small PR to fix that, and I hope it can be
 merge to stable until this lands. I also added a bunch of new examples,
 and at the very least those should get slurped into the PR from Haris.

 See https://github.com/django/django/pull/8187

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.0823e7360d9f1db6f3b7408f34d77c62%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26423: Make EmailValidator use HTML5 validation rather than more complicated regular expressions

[Django]

#26423: Make EmailValidator use HTML5 validation rather than more complicated
regular expressions
-+-
 Reporter:  Tim Graham   |Owner:  Haris
 Type:   |  Ibrahim K. V.
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Other) |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by MisRob):

 #27932 was closed as a duplicate

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6d006ecf58df0331edfaabcba2cbc641%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26423: Make EmailValidator use HTML5 validation rather than more complicated regular expressions

[Django]

#26423: Make EmailValidator use HTML5 validation rather than more complicated
regular expressions
-+-
 Reporter:  Tim Graham   |Owner:  Haris
 Type:   |  Ibrahim K. V.
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Other) |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Haris Ibrahim K. V.):

 * owner:  (none) => Haris Ibrahim K. V.
 * status:  new => assigned


Comment:

 I've added some documentation that I think will help keep the user
 expectations clear after digging into the conversation / discussion
 history of this ticket.

 https://github.com/django/django/pull/8081

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.910548c0e6fc5594659fa9469d57dacc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26423: Make EmailValidator use HTML5 validation rather than more complicated regular expressions

[Django]

#26423: Make EmailValidator use HTML5 validation rather than more complicated
regular expressions
--+
 Reporter:  Tim Graham|Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * needs_docs:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.34e57d0af90aa1545dba17f319fb1fb1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26423: Make EmailValidator use HTML5 validation rather than more complicated regular expressions

[Django]

#26423: Make EmailValidator use HTML5 validation rather than more complicated
regular expressions
--+
 Reporter:  Tim Graham|Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/7742 PR] from Collin Anderson.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f7281ad64d7f7cdc7ffae23cceabcebb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26423: Make EmailValidator use HTML5 validation rather than more complicated regular expressions

[Django]

#26423: Make EmailValidator use HTML5 validation rather than more complicated
regular expressions
--+
 Reporter:  Tim Graham|Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * status:  assigned => new
 * owner:  Chris Butler => (none)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.c43f4a1012acc49e9ee2c835dedcd883%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26423: Make EmailValidator use HTML5 validation rather than more complicated regular expressions

[Django]

#26423: Make EmailValidator use HTML5 validation rather than more complicated
regular expressions
--+
 Reporter:  timgraham |Owner:  cjbcross
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by claudep):

 I suggest that Unicode validation be discussed separately in #27029.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.47dcf482f3f35a9c9ce9d1e1732db4c9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26423: Make EmailValidator use HTML5 validation rather than more complicated regular expressions

[Django]

#26423: Make EmailValidator use HTML5 validation rather than more complicated
regular expressions
--+
 Reporter:  timgraham |Owner:  cjbcross
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by deltaskelta):

 Replying to [ticket:26423 timgraham]:
 > As discussed on the [https://groups.google.com/d/topic/django-
 developers/ASBJ0ge2KYo/discussion django-developers mailing list], the
 regular expressions for validating email addresses are complicated for
 questionable benefit. We should simplify it to use HTML5 type="email"
 validation ([http://blog.gerv.net/2011/05/html5_email_address_regexp/
 possible candidate]). A deprecation may be needed to give time for
 projects to add back more complex validation that they might required.

 I've found another possible fix here
 https://html.spec.whatwg.org/multipage/forms.html#valid-e-mail-address,
 but I have tried this regex and it does not match much out of the ASCII
 range. What does "HTML5" like browsers match that this regex does not?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.5ea175a053803eded346f386a1524f54%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26423: Make EmailValidator use HTML5 validation rather than more complicated regular expressions

[Django]

#26423: Make EmailValidator use HTML5 validation rather than more complicated
regular expressions
--+
 Reporter:  timgraham |Owner:  cjbcross
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by claudep):

 * has_patch:  1 => 0


Comment:

 My patch was moved to #27029.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.982f4a13844da1d363f97a05b7b9fd81%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26423: Make EmailValidator use HTML5 validation rather than more complicated regular expressions

[Django]

#26423: Make EmailValidator use HTML5 validation rather than more complicated
regular expressions
--+
 Reporter:  timgraham |Owner:  cjbcross
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by claudep):

 * has_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f0434479d2669acedd2cc5f3fecc15ee%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26423: Make EmailValidator use HTML5 validation rather than more complicated regular expressions

[Django]

#26423: Make EmailValidator use HTML5 validation rather than more complicated
regular expressions
--+
 Reporter:  timgraham |Owner:  cjbcross
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by claudep):

 This [https://github.com/django/django/pull/7039 PR] only marginally
 simplifies the regex, but all current tests are still passing, in addition
 of the non-ASCII local part.
 I'm not sure it solves all concerns of this report, to be
 discussed/confirmed.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.95c44f74fd8b22f97443d44a5bd9675f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26423: Make EmailValidator use HTML5 validation rather than more complicated regular expressions

[Django]

#26423: Make EmailValidator use HTML5 validation rather than more complicated
regular expressions
--+
 Reporter:  timgraham |Owner:  cjbcross
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by claudep):

 #27029 was closed as a duplicate.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e5aba3b6046d980374d3bec3fd9485b1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26423: Make EmailValidator use HTML5 validation rather than more complicated regular expressions

[Django]

#26423: Make EmailValidator use HTML5 validation rather than more complicated
regular expressions
--+
 Reporter:  timgraham |Owner:  cjbcross
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by claudep):

 It would have been nice to know the "consensus direction" mentioned in the
 comment above!

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.36d557c3c008e82859e9a99528afb363%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26423: Make EmailValidator use HTML5 validation rather than more complicated regular expressions

[Django]

#26423: Make EmailValidator use HTML5 validation rather than more complicated
regular expressions
--+
 Reporter:  timgraham |Owner:  cjbcross
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by cjbcross):

 Taking ownership on this at PyCon2016 Sprint.  Discussed with Markus and
 have background on consensus direction a solution should take.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.2f225936f514006fa354b644e76a0d03%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26423: Make EmailValidator use HTML5 validation rather than more complicated regular expressions

[Django]

#26423: Make EmailValidator use HTML5 validation rather than more complicated
regular expressions
--+
 Reporter:  timgraham |Owner:  cjbcross
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by cjbcross):

 * owner:  nobody => cjbcross
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.4cac75c5e83e4b13308588ead6d2c89d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26423: Make EmailValidator use HTML5 validation rather than more complicated regular expressions

[Django]

#26423: Make EmailValidator use HTML5 validation rather than more complicated
regular expressions
--+
 Reporter:  timgraham |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by sergei-maertens):

 We should also assert that non-ascii characters are allowed in the local
 part of the e-mail address, see #25986 for background on this issue.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.9612d545e8a50efc553b28f0fd4e4026%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.