Re: [Django] #26424: Allow URLValidator to skip schemes validation

[Django]

#26424: Allow URLValidator to skip schemes validation
-+-
 Reporter:  Tim Graham   |Owner:  Baptiste
 |  Mispelon
 Type:  New feature  |   Status:  closed
Component:  Core (Other) |  Version:  master
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * status:  assigned => closed
 * resolution:   => wontfix


Comment:

 Agreed, I don't see a wide usage of `__all__`. In most of cases you want
 to add some schemas which is
 
[https://docs.djangoproject.com/en/3.0/ref/validators/#django.core.validators.URLValidator.schemes
 already possible]. I believe solving #25594 would be a real solution for
 easy customizing the list of schemes.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.222775db0960ac22f9da7b1318fe83a8%40djangoproject.com.

Re: [Django] #26424: Allow URLValidator to skip schemes validation

[Django]

#26424: Allow URLValidator to skip schemes validation
-+-
 Reporter:  Tim Graham   |Owner:  Baptiste
 |  Mispelon
 Type:  New feature  |   Status:  assigned
Component:  Core (Other) |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson):

 As I commented on the PR, I'm not 100% convinced we shouldn't be saying
 that folks should create a custom validator for the known set of schemes
 that they want to accept, rather than adding an `'__all__'`. What do
 others think?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1fd8c5a0a0cab38082deec335a4f%40djangoproject.com.

Re: [Django] #26424: Allow URLValidator to skip schemes validation

[Django]

#26424: Allow URLValidator to skip schemes validation
-+-
 Reporter:  Tim Graham   |Owner:  Baptiste
 |  Mispelon
 Type:  New feature  |   Status:  assigned
Component:  Core (Other) |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Baptiste Mispelon):

 * owner:  Burhan Khalid => Baptiste Mispelon
 * needs_better_patch:  1 => 0


Comment:

 I took Burhan Khalid's pull request and updated it to target the 3.1
 release.

 I also tweaked the regexp for the accepted schemes to better match the RFC
 (I think).
 As suggested by Tim in the previous pull request, I added a test to make
 sure all currently assigned schemes [1] are validated by the regexp.

 [https://github.com/django/django/pull/12171 PR here]

 [1] https://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.73edf8c27adac0c90aec9c3dce022476%40djangoproject.com.

Re: [Django] #26424: Allow URLValidator to skip schemes validation

[Django]

#26424: Allow URLValidator to skip schemes validation
--+
 Reporter:  timgraham |Owner:  burhan
 Type:  New feature   |   Status:  assigned
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.d5627059ced51ec555c74f91ca830a24%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26424: Allow URLValidator to skip schemes validation

[Django]

#26424: Allow URLValidator to skip schemes validation
--+
 Reporter:  timgraham |Owner:  burhan
 Type:  New feature   |   Status:  assigned
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1efd58086e97cf4499a767fe44553f7d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26424: Allow URLValidator to skip schemes validation

[Django]

#26424: Allow URLValidator to skip schemes validation
--+
 Reporter:  timgraham |Owner:  burhan
 Type:  New feature   |   Status:  assigned
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.3b601dfc492ab9ef5f6b7dc580c5f32a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26424: Allow URLValidator to skip schemes validation

[Django]

#26424: Allow URLValidator to skip schemes validation
--+
 Reporter:  timgraham |Owner:  burhan
 Type:  New feature   |   Status:  assigned
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by burhan):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.469f9a0d6b9bb9c5d8e106e44aeb8108%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26424: Allow URLValidator to skip schemes validation

[Django]

#26424: Allow URLValidator to skip schemes validation
--+
 Reporter:  timgraham |Owner:  burhan
 Type:  New feature   |   Status:  assigned
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/6388 PR] with some comments for
 improvement.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.712ba863b692c1c75a42a5b7cda9e76b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26424: Allow URLValidator to skip schemes validation

[Django]

#26424: Allow URLValidator to skip schemes validation
--+
 Reporter:  timgraham |Owner:  burhan
 Type:  New feature   |   Status:  assigned
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by burhan):

 * owner:  nobody => burhan
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7d7be3f50648819e49d7aae3e910f402%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26424: Allow URLValidator to skip schemes validation

[Django]

#26424: Allow URLValidator to skip schemes validation
--+
 Reporter:  timgraham |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by claudep):

 It's not exactly about skipping scheme validation, but a minimal
 validation (e.g. all ascii letters and maximal length).

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ac98b4f4f8627d365a2f8a66a35f3426%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.