Re: [Django] #27211: Include HTTP-caching headers to "304 Not Modified" responses

[Django]

#27211: Include HTTP-caching headers to "304 Not Modified" responses
-+-
 Reporter:  renskiy  |Owner:  renskiy
 Type:  Bug  |   Status:  closed
Component:  HTTP handling|  Version:  1.10
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"f9702977b72003c17db87d6e4fdaa36415f13a38" f9702977]:
 {{{
 #!CommitTicketReference repository=""
 revision="f9702977b72003c17db87d6e4fdaa36415f13a38"
 Fixed #27211 -- Made UpdateCacheMiddleware include caching headers for
 "304 Not Modified" responses.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.4993079a0d188d9c6adb04f7476599c1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27211: Include HTTP-caching headers to "304 Not Modified" responses

[Django]

#27211: Include HTTP-caching headers to "304 Not Modified" responses
-+-
 Reporter:  renskiy  |Owner:  renskiy
 Type:  Bug  |   Status:  assigned
Component:  HTTP handling|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.6e7e34a849833ae804f14b69413482ec%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27211: Include HTTP-caching headers to "304 Not Modified" responses

[Django]

#27211: Include HTTP-caching headers to "304 Not Modified" responses
---+
 Reporter:  renskiy|Owner:  renskiy
 Type:  Bug|   Status:  assigned
Component:  HTTP handling  |  Version:  1.10
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by timgraham):

 * has_patch:  0 => 1
 * type:  New feature => Bug
 * stage:  Unreviewed => Accepted


Old description:

> Most browsers can cache responses with 304 HTTP code. So why not to
> include such headers to response if necessary.
>
> '''UPDATE''':
> According to the [https://tools.ietf.org/html/rfc7232 RFC7232] all "304
> Not Modified" responses must include "Cache-Control" and "Expires"
> headers that would have been sent in a corresponding "200 OK" response.
>
> See [https://tools.ietf.org/html/rfc7232#section-4.1 Section 4.1 of
> RFC7232]

New description:

 According to [https://tools.ietf.org/html/rfc7232#section-4.1 RFC7232] all
 "304 Not Modified" responses must include "Cache-Control" and "Expires"
 headers that would have been sent in a corresponding "200 OK" response.

--

Comment:

 [https://github.com/django/django/pull/7236 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.bea7be36df452a749355948236711c30%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27211: Include HTTP-caching headers to "304 Not Modified" responses

[Django]

#27211: Include HTTP-caching headers to "304 Not Modified" responses
---+--
 Reporter:  renskiy|Owner:  renskiy
 Type:  New feature|   Status:  assigned
Component:  HTTP handling  |  Version:  1.10
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Description changed by renskiy:

Old description:

> Most browsers can cache responses with 304 HTTP code. So why not to
> include such headers to response if necessary.

New description:

 Most browsers can cache responses with 304 HTTP code. So why not to
 include such headers to response if necessary.

 '''UPDATE''':
 According to the [https://tools.ietf.org/html/rfc7232 RFC7232] all "304
 Not Modified" responses must include "Cache-Control" and "Expires" headers
 that would have been sent in a corresponding "200 OK" response.

 See [https://tools.ietf.org/html/rfc7232#section-4.1 Section 4.1 of
 RFC7232]

--

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.4ee3e023eed3c5ff5b8ca175525bf973%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27211: Include HTTP-caching headers to "304 Not Modified" responses

[Django]

#27211: Include HTTP-caching headers to "304 Not Modified" responses
---+--
 Reporter:  renskiy|Owner:  renskiy
 Type:  New feature|   Status:  assigned
Component:  HTTP handling  |  Version:  1.10
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by renskiy):

 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.cce96db06f5c46c6f3ffe1fe00cb1a7a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27211: Include HTTP-caching headers to "304 Not Modified" responses

[Django]

#27211: Include HTTP-caching headers to "304 Not Modified" responses
---+--
 Reporter:  renskiy|Owner:  renskiy
 Type:  New feature|   Status:  new
Component:  HTTP handling  |  Version:  1.10
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by renskiy):

 The server generating a 304 response MUST generate any of the
following header fields that would have been sent in a 200 (OK)
response to the same request: Cache-Control, Content-Location, Date,
ETag, Expires, and Vary.
 Taken from RFC7232: [https://tools.ietf.org/html/rfc7232#section-4.1].

 Usually responses with 200 code will include such headers (e.g. from views
 decorated with cache_page), so according to the RFC responses with 304
 code must also include them.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.89aebfbdcfeffe888443e26fca52550c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27211: Include HTTP-caching headers to "304 Not Modified" responses

[Django]

#27211: Include HTTP-caching headers to "304 Not Modified" responses
---+--
 Reporter:  renskiy|Owner:  renskiy
 Type:  New feature|   Status:  new
Component:  HTTP handling  |  Version:  1.10
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by timgraham):

 * needs_better_patch:   => 0
 * component:  Core (Cache system) => HTTP handling
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 I didn't spot a reason for the behavior in the original ticket (#580). Can
 you motivate this change with an example? You say "most browsers can cache
 responses with 304 HTTP code" -- any idea why all browsers don't?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.3de1764321cfb7384f60465c66fba0b2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.