Re: [Django] #27755: add ModelAdmin.get_inlines() hook to allow set inlines based on the request or model instance.

[Django]

#27755: add ModelAdmin.get_inlines() hook to allow set inlines based on the 
request
or model instance.
-+-
 Reporter:  WeizhongTu   |Owner:  Hasan
 |  Ramezani
 Type:  New feature  |   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
  django,admin,inlines   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"917fd9d03fdd21538864af4b412ac30b36d99268" 917fd9d0]:
 {{{
 #!CommitTicketReference repository=""
 revision="917fd9d03fdd21538864af4b412ac30b36d99268"
 Fixed #27755 -- Added ModelAdmin.get_inlines() hook.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.b21acc6ae8fbbe72cc9976365a7c97bf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27755: add ModelAdmin.get_inlines() hook to allow set inlines based on the request or model instance.

[Django]

#27755: add ModelAdmin.get_inlines() hook to allow set inlines based on the 
request
or model instance.
-+-
 Reporter:  WeizhongTu   |Owner:  Hasan
 |  Ramezani
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
  django,admin,inlines   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.54d10ac46072a3d800cec893e36a5985%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27755: add ModelAdmin.get_inlines() hook to allow set inlines based on the request or model instance.

[Django]

#27755: add ModelAdmin.get_inlines() hook to allow set inlines based on the 
request
or model instance.
-+-
 Reporter:  WeizhongTu   |Owner:  Hasan
 |  Ramezani
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  django,admin,inlines   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Hasan Ramezani):

 * owner:  Hidde Bultsma => Hasan Ramezani
 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.f5f803d70edde3109adfe5cc6dd69453%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27755: add ModelAdmin.get_inlines() hook to allow set inlines based on the request or model instance.

[Django]

#27755: add ModelAdmin.get_inlines() hook to allow set inlines based on the 
request
or model instance.
-+-
 Reporter:  WeizhongTu   |Owner:  Hidde
 |  Bultsma
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  django,admin,inlines   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Hidde Bultsma):

 * owner:  nobody => Hidde Bultsma
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.0d6f5b0c7ae00a6be9311925428cb681%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27755: add ModelAdmin.get_inlines() hook to allow set inlines based on the request or model instance.

[Django]

#27755: add ModelAdmin.get_inlines() hook to allow set inlines based on the 
request
or model instance.
--+
 Reporter:  WeizhongTu|Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  django,admin,inlines  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 I guess it's useful. The patch needs some improvement (tests, some doc
 fixes such as release notes) as per the PatchReviewChecklist.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.866e0965eb7f22f93864beb0bc3264bb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27755: add ModelAdmin.get_inlines() hook to allow set inlines based on the request or model instance.

[Django]

#27755: add ModelAdmin.get_inlines() hook to allow set inlines based on the 
request
or model instance.
-+-
 Reporter:  WeizhongTu   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
  django,admin,inlines   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by WeizhongTu):

 I've already created a new pull request here:
 https://github.com/django/django/pull/7920

 Replying to [comment:1 Tim Graham]:
 > Are you going to offer a patch to show exactly what you have in mind?
 I'm not immediately convinced that another hook is needed since the cost
 of duplicating a for loop is not that great.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.7b502f0d813da0b2bd9969d0c068de78%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27755: add ModelAdmin.get_inlines() hook to allow set inlines based on the request or model instance.

[Django]

#27755: add ModelAdmin.get_inlines() hook to allow set inlines based on the 
request
or model instance.
-+-
 Reporter:  WeizhongTu   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
  django,admin,inlines   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by WeizhongTu):

 If I want to realize a dynamic inlines based on the request or model
 instance. I need to override `get_inline_instances` to do it.
 What I want to do is just set `self.inlines` to dynamic values according
 to different person or object. not `inline instances`, so I advise to add
 a new hook  `get_inlines(request, obj=None)` to finish such a thing.

 Replying to [comment:1 Tim Graham]:
 > Are you going to offer a patch to show exactly what you have in mind?
 I'm not immediately convinced that another hook is needed since the cost
 of duplicating a for loop is not that great.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.4f6cac1146b7270afbd61361929bed89%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27755: add ModelAdmin.get_inlines() hook to allow set inlines based on the request or model instance.

[Django]

#27755: add ModelAdmin.get_inlines() hook to allow set inlines based on the 
request
or model instance.
-+-
 Reporter:  WeizhongTu   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
  django,admin,inlines   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 Are you going to offer a patch to show exactly what you have in mind? I'm
 not immediately convinced that another hook is needed since the cost of
 duplicating a for loop is not that great.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.65ed350eab4ca7d95a92dbc411854d09%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.