Re: [Django] #29270: KeyError if using 'password' as readonly_fields in UserAdmin

[Django]

#29270: KeyError if using 'password' as readonly_fields in UserAdmin
--+---
 Reporter:  Malte Gerth   |Owner:  Malte Gerth
 Type:  Bug   |   Status:  closed
Component:  contrib.auth  |  Version:  2.0
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+---
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"874977d388decdd59022bf6b7f4d50caf2052155" 874977d3]:
 {{{
 #!CommitTicketReference repository=""
 revision="874977d388decdd59022bf6b7f4d50caf2052155"
 Fixed #29270 -- Fixed UserChangeForm crash if password field is excluded.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.662d64324551d3552e699391913249e2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29270: KeyError if using 'password' as readonly_fields in UserAdmin

[Django]

#29270: KeyError if using 'password' as readonly_fields in UserAdmin
--+---
 Reporter:  Malte Gerth   |Owner:  Malte Gerth
 Type:  Bug   |   Status:  assigned
Component:  contrib.auth  |  Version:  2.0
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+---

Comment (by Malte Gerth):

 Ok, I tried to make a pull request
 https://github.com/django/django/pull/9833

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.572ad1c1fd893fc9a7d359d10792154e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29270: KeyError if using 'password' as readonly_fields in UserAdmin

[Django]

#29270: KeyError if using 'password' as readonly_fields in UserAdmin
--+---
 Reporter:  Malte Gerth   |Owner:  Malte Gerth
 Type:  Bug   |   Status:  assigned
Component:  contrib.auth  |  Version:  2.0
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+---
Changes (by Malte Gerth):

 * status:  new => assigned
 * owner:  nobody => Malte Gerth
 * easy:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.0a3df985a66eafc26229c6f711eddd67%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29270: KeyError if using 'password' as readonly_fields in UserAdmin

[Django]

#29270: KeyError if using 'password' as readonly_fields in UserAdmin
--+
 Reporter:  Malte Gerth   |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.auth  |  Version:  2.0
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


Comment:

 `.keys()` isn't needed, otherwise the fix looks reasonable. A test goes in
 `tests/auth_tests/test_forms.py` -- can you offer a pull request?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.de77d2586a4cb68a9b1a7fd4bf096a5c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29270: KeyError if using 'password' as readonly_fields in UserAdmin

[Django]

#29270: KeyError if using 'password' as readonly_fields in UserAdmin
--+--
 Reporter:  Malte Gerth   |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.auth  |  Version:  2.0
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--

Comment (by Malte Gerth):

 This should fix the issue for now:
 {{{
 class UserChangeForm(forms.ModelForm):
 # ...
 def __init__(self, *args, **kwargs):
 super().__init__(*args, **kwargs)
 if 'password' in self.fields.keys():
 self.fields['password'].help_text =
 self.fields['password'].help_text.format('../password/')
 # ...
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.1f1438b38c1539ac811b5db43780fa20%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.