Re: [Django] #30408: CheckConstraint with lookup using LIKE & % crash on PostgreSQL.

2019-04-29 Thread Django
#30408: CheckConstraint with lookup using LIKE & % crash on PostgreSQL.
-+-
 Reporter:  David Sanders|Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  2.2
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * has_patch:  0 => 1


Comment:

 I continued efforts to get the `Index` and `Constraint`'s `sql` methods
 return `(sql, params)` tuples but I'm having a hard time
 [https://github.com/django/django/compare/master...charettes:constraint-
 index-sql making the changes backward compatible].

 It looks like we'll have to keep playing the whac-a-mole game in 2.2 by
 extending backends schema editor's `quote_value` support for more input.
 One good side effect of these changes is that it will extend `sqlmigrate`
 coverage which also relies on appropriate output from this method.

 Here's [https://github.com/django/django/pull/11306 a PR] that performs
 the `%` escaping in `quote_value` and should address the immediate issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.8de68a21cdfe1e81496d80865d7d9dde%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #30408: CheckConstraint with lookup using LIKE & % crash on PostgreSQL.

2019-04-26 Thread Django
#30408: CheckConstraint with lookup using LIKE & % crash on PostgreSQL.
-+-
 Reporter:  David Sanders|Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  2.2
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * status:  new => assigned
 * owner:  nobody => Simon Charette


Comment:

 FWIW it's the same class of issue as #30258 which will probably better be
 fixed by making `create_sql`/`constraint_sql` methods return `(sql,
 params)` tuples. See https://code.djangoproject.com/ticket/30258#comment:3
 and [https://github.com/django/django/compare/master...charettes
 :constraint-index-sql ungoing work to make this happen].

 I'll tentatively assign to myself to try to polish the solution suggested
 above.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.65192972586700cf5ad30eeff2afc296%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #30408: CheckConstraint with lookup using LIKE & % crash on PostgreSQL.

2019-04-26 Thread Django
#30408: CheckConstraint with lookup using LIKE & % crash on PostgreSQL.
-+-
 Reporter:  David Sanders|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.2
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * Attachment "30408.diff" added.


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.48b17d47cb08ecffedf36368f5848a79%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #30408: CheckConstraint with lookup using LIKE & % crash on PostgreSQL. (was: CheckConstraint with lookup using LIKE & % and PostgreSQL results in exception)

2019-04-26 Thread Django
#30408: CheckConstraint with lookup using LIKE & % crash on PostgreSQL.
-+-
 Reporter:  David Sanders|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.2
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * cc: Ian Foote (added)
 * version:  master => 2.2
 * severity:  Normal => Release blocker
 * stage:  Unreviewed => Accepted


Comment:

 Reproduced at efeceba589974b95b35b2e25df86498c96315518.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.e9539be3a218ea453d7ec36bc8f93774%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.