Re: [Django] #33309: DISTINCT ON fails with mixed-case field aliases

[Django]

#33309: DISTINCT ON fails with mixed-case field aliases
-+-
 Reporter:  Christophe Thiery|Owner:  Arsalan
 |  Ghassemi
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  3.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Christophe Thiery):

 Thank you!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.bfe2cb624b3b8b98ef99ba6943cd8dcc%40djangoproject.com.

Re: [Django] #33309: DISTINCT ON fails with mixed-case field aliases

[Django]

#33309: DISTINCT ON fails with mixed-case field aliases
-+-
 Reporter:  Christophe Thiery|Owner:  Arsalan
 |  Ghassemi
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  3.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"bdcda1ca9ba254743269e482384c2711ac34b1f1" bdcda1ca]:
 {{{
 #!CommitTicketReference repository=""
 revision="bdcda1ca9ba254743269e482384c2711ac34b1f1"
 Fixed #33309 -- Fixed QuerySet.distinct() crash on mixed case annotation.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.b5b008f996714139c56efec89f4936b4%40djangoproject.com.

Re: [Django] #33309: DISTINCT ON fails with mixed-case field aliases

[Django]

#33309: DISTINCT ON fails with mixed-case field aliases
-+-
 Reporter:  Christophe Thiery|Owner:  Arsalan
 |  Ghassemi
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  3.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.5103090f81a27fab15ee91325a9ea721%40djangoproject.com.

Re: [Django] #33309: DISTINCT ON fails with mixed-case field aliases

[Django]

#33309: DISTINCT ON fails with mixed-case field aliases
-+-
 Reporter:  Christophe Thiery|Owner:  Arsalan
 |  Ghassemi
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  3.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Arsalan Ghassemi):

 New PR (changed target to main branch) :
 https://github.com/django/django/pull/15119

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.437d60f35ca98035b7400cd18810ebe9%40djangoproject.com.

Re: [Django] #33309: DISTINCT ON fails with mixed-case field aliases

[Django]

#33309: DISTINCT ON fails with mixed-case field aliases
-+-
 Reporter:  Christophe Thiery|Owner:  Arsalan
 |  Ghassemi
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  3.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Arsalan Ghassemi):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.a7af8b7392ebd1772d6bc01da5f1f239%40djangoproject.com.

Re: [Django] #33309: DISTINCT ON fails with mixed-case field aliases

[Django]

#33309: DISTINCT ON fails with mixed-case field aliases
-+-
 Reporter:  Christophe Thiery|Owner:  Arsalan
 |  Ghassemi
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  3.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Arsalan Ghassemi):

 Sorry it's my first contribution to an open-source project and I forgot to
 mention the topic branch :
 https://github.com/ArsaCode/django/tree/ticket_33309

 I opened a PR with the changes :
 https://github.com/django/django/pull/15118

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.612610594730a7d6a8efaa2033420598%40djangoproject.com.

Re: [Django] #33309: DISTINCT ON fails with mixed-case field aliases

[Django]

#33309: DISTINCT ON fails with mixed-case field aliases
-+-
 Reporter:  Christophe Thiery|Owner:  Arsalan
 |  Ghassemi
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  3.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Arsalan Ghassemi):

 I was able to reproduce the bug in my environment and added the regression
 test.

 I'm currently working on the fix and will open a PR soon.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.1392e56d45fba55d1789a7e00c3ca5a2%40djangoproject.com.

Re: [Django] #33309: DISTINCT ON fails with mixed-case field aliases

[Django]

#33309: DISTINCT ON fails with mixed-case field aliases
-+-
 Reporter:  Christophe Thiery|Owner:  Arsalan
 |  Ghassemi
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  3.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Egor R):

 * cc: Egor R (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.4d33e00c3c7e36fa12c93b3aeeef26ab%40djangoproject.com.

Re: [Django] #33309: DISTINCT ON fails with mixed-case field aliases

[Django]

#33309: DISTINCT ON fails with mixed-case field aliases
-+-
 Reporter:  Christophe Thiery|Owner:  Arsalan
 |  Ghassemi
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  3.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Arsalan Ghassemi):

 * owner:  nobody => Arsalan Ghassemi
 * status:  new => assigned


Comment:

 Hello,

 I'm working on a patch for this issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.b0689c4aa4c098dcc0f6f869ac9828e4%40djangoproject.com.

Re: [Django] #33309: DISTINCT ON fails with mixed-case field aliases

[Django]

#33309: DISTINCT ON fails with mixed-case field aliases
-+-
 Reporter:  Christophe Thiery|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  3.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ad Timmering):

 * cc: Ad Timmering (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.6c8248d62a6cc077f721f67ead220570%40djangoproject.com.

Re: [Django] #33309: DISTINCT ON fails with mixed-case field aliases

[Django]

#33309: DISTINCT ON fails with mixed-case field aliases
-+-
 Reporter:  Christophe Thiery|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  3.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 This should be quite easy to fix:
 {{{
 diff --git a/django/db/models/sql/compiler.py
 b/django/db/models/sql/compiler.py
 index 73cf2c5f62..69a2d9298f 100644
 --- a/django/db/models/sql/compiler.py
 +++ b/django/db/models/sql/compiler.py
 @@ -754,7 +754,7 @@ class SQLCompiler:
  targets, alias, _ = self.query.trim_joins(targets, joins,
 path)
  for target in targets:
  if name in self.query.annotation_select:
 -result.append(name)
 +result.append(self.connection.ops.quote_name(name))
  else:
  r, p = self.compile(transform_function(target,
 alias))
  result.append(r)
 }}}
 Would you like to prepare a patch? (a regression test in
 `tests/distinct_on_fields/tests.py` is required).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.bb720b907d9037c5c0a22a7c6d6c5c46%40djangoproject.com.

Re: [Django] #33309: DISTINCT ON fails with mixed-case field aliases

[Django]

#33309: DISTINCT ON fails with mixed-case field aliases
-+-
 Reporter:  Christophe Thiery|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  3.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * type:  Uncategorized => Bug
 * stage:  Unreviewed => Accepted


Comment:

 Thanks for the report.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.cac807ca04c7094fbde9d94583f96a2d%40djangoproject.com.