Re: [Django] #33952: Too aggressive pk control in create_reverse_many_to_one_manager

[Django]

#33952: Too aggressive pk control in create_reverse_many_to_one_manager
-+-
 Reporter:  Claude Paroz |Owner:  David
 |  Wobrock
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  4.1
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 Replying to [comment:11 Andrey Ferriyan]:
 > Any news on this?.
 >
 > Several codes broke due to the migration to the stable LTS version 4.2.
 At least we have like temporary solution if it is possible.

 I'm not sure what kind of news do you expect. This change was made in
 Django 4.1 (which is already in extended support). Nobody started a
 discussion as I [https://code.djangoproject.com/ticket/19580#comment:57
 requested] 20 months ago, so there is nothing new here that could change a
 previous decision. Also, please don't spread comments across multiple
 tickets. If you have something to add, leave a comment in #19580.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018b272ae035-42c7d857-b57e-443d-b14b-132e30b41ab7-00%40eu-central-1.amazonses.com.

Re: [Django] #33952: Too aggressive pk control in create_reverse_many_to_one_manager

[Django]

#33952: Too aggressive pk control in create_reverse_many_to_one_manager
-+-
 Reporter:  Claude Paroz |Owner:  David
 |  Wobrock
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  4.1
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Andrey Ferriyan):

 Any news on this?.

 Several codes broke due to the migration to the stable LTS version 4.2. At
 least we have like temporary solution if it is possible.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018b26dc2260-b72e6b8d-8345-4163-90a3-6d9a7c4e0f09-00%40eu-central-1.amazonses.com.

Re: [Django] #33952: Too aggressive pk control in create_reverse_many_to_one_manager

[Django]

#33952: Too aggressive pk control in create_reverse_many_to_one_manager
-+-
 Reporter:  Claude Paroz |Owner:  David
 |  Wobrock
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  4.1
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Alex Matos):

 I already made a [https://code.djangoproject.com/ticket/19580#comment:58
 comment] on #19580, but since this ticket is related, I'm gonna comment
 here as well. I believe the changes on these two tickets should be fully
 reverted. I'm upgrading a large Django codebase from version 3.2 to 4.2
 and a lot of code broke due to these changes, where code that was once
 returning an empty queryset, now raises a `ValueError`. In the name of
 Django's stability, I think changing user code behavior without a
 deprecation warning should be avoided at all costs.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018b14f0d419-5b2411eb-1a22-454a-bd8d-806602a0db9c-00%40eu-central-1.amazonses.com.

Re: [Django] #33952: Too aggressive pk control in create_reverse_many_to_one_manager

[Django]

#33952: Too aggressive pk control in create_reverse_many_to_one_manager
-+-
 Reporter:  Claude Paroz |Owner:  David
 |  Wobrock
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  4.1
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Steven Mapes):

 Replying to [comment:8 Claude Paroz]:
 > Many thanks David for the fix!

 Are we sure this is fixed as I still get these errors in all 4.1 versions?
 I posted an example on another ticket, #33984,  which I thought was more
 related to the issue. you can find that report
 [https://code.djangoproject.com/ticket/33984#comment:18 here]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070183c6824ca3-734c9110-c2ba-4bcc-81e1-8461617f8667-00%40eu-central-1.amazonses.com.

Re: [Django] #33952: Too aggressive pk control in create_reverse_many_to_one_manager

[Django]

#33952: Too aggressive pk control in create_reverse_many_to_one_manager
-+-
 Reporter:  Claude Paroz |Owner:  David
 |  Wobrock
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  4.1
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Claude Paroz):

 Many thanks David for the fix!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070182dff556c9-5364aa11-4460-49d1-97f8-46bf02d3e2c9-00%40eu-central-1.amazonses.com.

Re: [Django] #33952: Too aggressive pk control in create_reverse_many_to_one_manager

[Django]

#33952: Too aggressive pk control in create_reverse_many_to_one_manager
-+-
 Reporter:  Claude Paroz |Owner:  David
 |  Wobrock
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  4.1
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"fca055315e9bb6cb1212953478dbe971b0bb47fb" fca05531]:
 {{{
 #!CommitTicketReference repository=""
 revision="fca055315e9bb6cb1212953478dbe971b0bb47fb"
 [4.1.x] Fixed #33952 -- Reallowed creating reverse foreign key managers on
 unsaved instances.

 Thanks Claude Paroz for the report.

 Regression in 7ba6ebe9149ae38257d70100e8bfbfd0da189862.

 Backport of 806e9e2d0dcf8f58e376fb7e2a8b9771e2a9ce16 from main
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070182df84e2a4-239bccb7-a24e-4e46-8709-6ddf81f0ac4c-00%40eu-central-1.amazonses.com.

Re: [Django] #33952: Too aggressive pk control in create_reverse_many_to_one_manager

[Django]

#33952: Too aggressive pk control in create_reverse_many_to_one_manager
-+-
 Reporter:  Claude Paroz |Owner:  David
 |  Wobrock
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  4.1
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"806e9e2d0dcf8f58e376fb7e2a8b9771e2a9ce16" 806e9e2d]:
 {{{
 #!CommitTicketReference repository=""
 revision="806e9e2d0dcf8f58e376fb7e2a8b9771e2a9ce16"
 Fixed #33952 -- Reallowed creating reverse foreign key managers on unsaved
 instances.

 Thanks Claude Paroz for the report.

 Regression in 7ba6ebe9149ae38257d70100e8bfbfd0da189862.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070182df844c2d-c7c79ac2-78cd-4aa7-b238-a7bdf7d851dc-00%40eu-central-1.amazonses.com.

Re: [Django] #33952: Too aggressive pk control in create_reverse_many_to_one_manager

[Django]

#33952: Too aggressive pk control in create_reverse_many_to_one_manager
-+-
 Reporter:  Claude Paroz |Owner:  David
 |  Wobrock
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  4.1
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070182df689003-78b94e4f-2201-413c-911c-176f12d77739-00%40eu-central-1.amazonses.com.

Re: [Django] #33952: Too aggressive pk control in create_reverse_many_to_one_manager

[Django]

#33952: Too aggressive pk control in create_reverse_many_to_one_manager
-+-
 Reporter:  Claude Paroz |Owner:  David
 |  Wobrock
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  4.1
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * severity:  Normal => Release blocker


Comment:

 Regression in 7ba6ebe9149ae38257d70100e8bfbfd0da189862.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070182d39690b3-7dcca0ba-0a33-4570-8441-e115cc7df05b-00%40eu-central-1.amazonses.com.

Re: [Django] #33952: Too aggressive pk control in create_reverse_many_to_one_manager

[Django]

#33952: Too aggressive pk control in create_reverse_many_to_one_manager
-+-
 Reporter:  Claude Paroz |Owner:  David
 |  Wobrock
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  4.1
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by David Wobrock):

 * cc: David Wobrock (added)
 * owner:  nobody => David Wobrock
 * has_patch:  0 => 1
 * status:  new => assigned


Comment:

 I provided a small [https://github.com/django/django/pull/15995 PR] with
 the changes discussed by Simon.
 There a few behaviour changes, tell me what you think! :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070182d158a8d5-ed230810-2ea2-446c-82b1-42b036ec8b9d-00%40eu-central-1.amazonses.com.

Re: [Django] #33952: Too aggressive pk control in create_reverse_many_to_one_manager

[Django]

#33952: Too aggressive pk control in create_reverse_many_to_one_manager
-+-
 Reporter:  Claude Paroz |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  4.1
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Claude Paroz):

 Replying to [comment:1 Simon Charette]:
 ...
 > In the mean time I think you should be able to use
 `MyModel._meta.get_field("related_set")` for your introspection needs.

 Thanks for the tip! I just needed to remove the `_set` as it's not part of
 the `ManyToOneRel` field name in `_meta`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070182cec123fc-8d38eedc-62bf-4c45-b3ca-13cdb2a61dd1-00%40eu-central-1.amazonses.com.

Re: [Django] #33952: Too aggressive pk control in create_reverse_many_to_one_manager

[Django]

#33952: Too aggressive pk control in create_reverse_many_to_one_manager
-+-
 Reporter:  Claude Paroz |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  4.1
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * stage:  Unreviewed => Accepted


Comment:

 I think this worth doing, having `get_queryset` perform
 `self._check_fk_val()` should catch the currently tested `.all()` case as
 well.

 In the mean time I think you should be able to use
 `MyModel._meta.get_field("related_set)` for your introspection needs.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070182ce606937-6755e7b4-b444-4e97-9098-1d550f0c1683-00%40eu-central-1.amazonses.com.