Re: [Django] #4492: Provide tests for mixed-case column names

[Django]

#4492: Provide tests for mixed-case column names
-+-
 Reporter:  John Shaffer |Owner:  nobody
     |   Status:  closed
 Type:   |  Version:  master
  Cleanup/optimization   |   Resolution:  fixed
Component:  Database layer   | Triage Stage:  Accepted
  (models, ORM)  |  Needs documentation:  0
 Severity:  Normal   |  Patch needs improvement:  1
 Keywords:  postgresql psycopg   |UI/UX:  0
Has patch:  1|
  Needs tests:  0|
Easy pickings:  1|
-+-
Changes (by timo):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 On further investigation, I think we have tests to cover this. In
 particular, if I comment out the fix from [6507], I get a failure in
 `test_generic_relation (backends.tests.SequenceResetTest)`, and here are
 some models with mixed case column names:

 {{{
 aggregation_regress/models.py:Entry = models.CharField(unique=True,
 max_length=50)
 aggregation_regress/models.py:Clue = models.CharField(max_length=150)
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.a19e804f753dc54e874d4aaa9c04d98a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #4492: Provide tests for mixed-case column names

[Django]

#4492: Provide tests for mixed-case column names
-+-
 Reporter:  John Shaffer |Owner:  nobody
     |   Status:  new
 Type:   |  Version:  master
  Cleanup/optimization   |   Resolution:
Component:  Database layer   | Triage Stage:  Accepted
  (models, ORM)  |  Needs documentation:  0
 Severity:  Normal   |  Patch needs improvement:  1
 Keywords:  postgresql psycopg   |UI/UX:  0
Has patch:  1|
  Needs tests:  0|
Easy pickings:  1|
-+-

Comment (by velis):

 https://github.com/django/django/pull/1667

 Please review

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.55d926236a94c08971193dc27f280b97%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #4492: Provide tests for mixed-case column names

[Django]

#4492: Provide tests for mixed-case column names
-+-
 Reporter:  John Shaffer |Owner:  nobody
     |   Status:  new
 Type:   |  Version:  master
  Cleanup/optimization   |   Resolution:
Component:  Database layer   | Triage Stage:  Accepted
  (models, ORM)  |  Needs documentation:  0
 Severity:  Normal   |  Patch needs improvement:  1
 Keywords:  postgresql psycopg   |UI/UX:  0
Has patch:  1|
  Needs tests:  0|
Easy pickings:  1|
-+-

Comment (by velis):

 I just want to clarify: it says tests are needed, but the appropriate
 checkbox is not ticked. So, is it the tests that are needed or is there
 something more to this ticket?
 p.s.: I'm sprinting django on PyCon UK and I'm looking at this ticket
 because I have dealt with this problem before. So I know what the issue
 was, I can write the appropriate tests, but I also want to make it right
 so that my first contribution wouldn't end up a failure :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.3a615ab3da14a048fc3295791da0a59e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #4492: Provide tests for mixed-case column names

[Django]

#4492: Provide tests for mixed-case column names
-+-
 Reporter:  John Shaffer |Owner:  nobody
     |   Status:  new
 Type:   |  Version:  master
  Cleanup/optimization   |   Resolution:
Component:  Database layer   | Triage Stage:  Accepted
  (models, ORM)  |  Needs documentation:  0
 Severity:  Normal   |  Patch needs improvement:  1
 Keywords:  postgresql psycopg   |UI/UX:  0
Has patch:  1|
  Needs tests:  0|
Easy pickings:  1|
-+-
Changes (by timo):

 * easy:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.3b636ba340a349d73213a453133566ff%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #4492: Provide tests for mixed-case column names

[Django]

#4492: Provide tests for mixed-case column names
+---
  Reporter:  John Shaffer   | Owner:  
nobody
Status:  new| Milestone:

 Component:  Database layer (models, ORM)   |   Version:  
SVN   
Resolution: |  Keywords:  
postgresql psycopg
 Stage:  Accepted   | Has_patch:  1 

Needs_docs:  0  |   Needs_tests:  0 

Needs_better_patch:  1  |  
+---
Changes (by adamnelson):

  * needs_better_patch:  0 => 1

Comment:

 Patch needs to be updated again.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.