Re: properly passing form post data to get_context_data() in detailview

[Greg Maruszeczka]

I believe I've found my own solution and it seems more straightforward than 
I originally thought. I'm posting it here in the chance it saves someone 
else some time. When django told me there was no attribute 'object' it set 
me to look at where this attribute was supposed to be assigned and I found 
it in the inherited class' methods.

Anyway, after some refactoring, trial-and-error and reading code I've 
revised the view to this:

class PostDetailView(DetailView):
template_name = 'blog_detail.html'
context_object_name = 'post'
form_class = CommentForm

def get_object(self):
post = Post.objects.get(published=True, slug=self.kwargs['slug'])
return post

def get_context_data(self, **kwargs):
context = super(PostDetailView, self).get_context_data(**kwargs)
context['comments'] = 
Comment.objects.filter(published=True).filter(post_id=context['post'].id)
return context

def get(self, request, *args, **kwargs):
## important ##
super(PostDetailView, self).get(self, request, *args, **kwargs)
form = self.form_class
return self.render_to_response(self.get_context_data(form=form))

def post(self, request, *args, **kwargs):
## important ##
self.object = self.get_object()
form = self.form_class(request.POST)
if form.is_valid():
f = form.save(commit=False)
f.post_id = self.object.id
f.ip_address = self.get_client_ip(self.request)
f.save()
form.send_email(self.object)
messages.add_message(self.request, messages.SUCCESS, 'Comment 
submitted and will be published pending administrator approval. Thanks!')
return redirect(self.object)
else:
messages.add_message(self.request, messages.ERROR, 'There was a 
problem with your submission. Please check the form below for errors and 
try again.')
return self.render_to_response(self.get_context_data(form=form))

def get_client_ip(self, request):
x_forwarded_for = request.META.get('HTTP_X_FORWARDED_FOR')
if x_forwarded_for:
ip = x_forwarded_for.split(',')[0]
else:
ip = request.META.get('REMOTE_ADDR')
return ip

The super() call in PostDetailView.get() and the self.object = 
self.get_object() call in PostDetailView.post() ensures there's a 
self.object and I no longer get the 'attribute error'. As well empty fields 
in the submission form are now properly flagged by validation errors. It 
appears to work as intended and now I can review again in light of best 
practices. If anyone has suggestions on that I would appreciate it

Thanks,
GM



On Tuesday, 4 June 2013 17:51:24 UTC-7, Greg Maruszeczka wrote:
>
> Hi,
>
> I'm trying to process a form through a detailview that adds a comment to a 
> blog post. Here's my view code:
>
> class PostDetailView(DetailView):
> model = Post
> template_name = 'blog_detail.html'
> queryset = Post.objects.filter(published=True)
> form_class = CommentForm
>   
> def get_context_data(self, **kwargs):
> context = super(PostDetailView, self).get_context_data(**kwargs)
> post = self.get_object()
> context['comments'] = 
> Comment.objects.filter(published=True).filter(post_id=post.id)
> context['form'] = CommentForm
> return context
> 
> def post(self, request, *args, **kwargs):
> post = self.get_object()
> form = CommentForm(request.POST)
> if form.is_valid():
> f = form.save(commit=False)
> f.post_id = post.id
> f.ip_address = self.get_client_ip(self.request)
> f.save()
> form.send_email()
> messages.add_message(self.request, messages.SUCCESS, 'Comment 
> submitted. Thanks!')
> return HttpResponseRedirect(request.META.get('HTTP_REFERER', 
> None))
> else:
> # this fails with attribute error: 'PostDetailView' object 
> has no attribute 'object'
> return 
> self.render_to_response(self.get_context_data(form=form))
> 
> def get_client_ip(self, request):
> x_forwarded_for = request.META.get('HTTP_X_FORWARDED_FOR')
> if x_forwarded_for:
> ip = x_forwarded_for.split(',')[0]
> else:
> ip = request.META.get('REMOTE_ADDR')
> return ip
>
>
> And here's the relevant form code:
>
> class CommentForm(ModelForm):
> class Meta:
> model = Comment
> exclude = ('post', 'published')
> 
> def send_email(self):
> text = self.cleaned_data['text']
> name = self.cleaned_data['name']
> send_mail(
> 'comment submission',
>

properly passing form post data to get_context_data() in detailview

[Greg Maruszeczka]

Hi,

I'm trying to process a form through a detailview that adds a comment to a 
blog post. Here's my view code:

class PostDetailView(DetailView):
model = Post
template_name = 'blog_detail.html'
queryset = Post.objects.filter(published=True)
form_class = CommentForm
  
def get_context_data(self, **kwargs):
context = super(PostDetailView, self).get_context_data(**kwargs)
post = self.get_object()
context['comments'] = 
Comment.objects.filter(published=True).filter(post_id=post.id)
context['form'] = CommentForm
return context

def post(self, request, *args, **kwargs):
post = self.get_object()
form = CommentForm(request.POST)
if form.is_valid():
f = form.save(commit=False)
f.post_id = post.id
f.ip_address = self.get_client_ip(self.request)
f.save()
form.send_email()
messages.add_message(self.request, messages.SUCCESS, 'Comment 
submitted. Thanks!')
return HttpResponseRedirect(request.META.get('HTTP_REFERER', 
None))
else:
# this fails with attribute error: 'PostDetailView' object has 
no attribute 'object'
return self.render_to_response(self.get_context_data(form=form))

def get_client_ip(self, request):
x_forwarded_for = request.META.get('HTTP_X_FORWARDED_FOR')
if x_forwarded_for:
ip = x_forwarded_for.split(',')[0]
else:
ip = request.META.get('REMOTE_ADDR')
return ip


And here's the relevant form code:

class CommentForm(ModelForm):
class Meta:
model = Comment
exclude = ('post', 'published')

def send_email(self):
text = self.cleaned_data['text']
name = self.cleaned_data['name']
send_mail(
'comment submission',
name + ' wrote:\n' + text,
[from_email_address],
([to_email_address])
)

Form processing appears to work as expected when the form fields are 
actually filled and the form is valid but fails with an "Attribute Error: 
'PostDetailView' object has no attribute 'object'" when the fields are 
blank (i.e. form is not valid). As a relative newbie to python and django 
I'm at a complete loss as to what I'm doing wrong here. 

Thanks in advance for any pointers.

-- 
You received this message because you are subscribed to the Google Groups 
"Django users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-users+unsubscr...@googlegroups.com.
To post to this group, send email to django-users@googlegroups.com.
Visit this group at http://groups.google.com/group/django-users?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Helping someone move from Joomla to Django

[Greg Maruszeczka]

On Thu, 6 Oct 2011 06:12:21 -0700 (PDT)
graeme  wrote:

> Joomla may have those shortcomings, but its not the only alternative.
> If someone likee PHP, already knows PHP or has to use PHP, there are
>  a lot of PHP fraeworks: from light ones, to ones feature comparable
> to
> Django (although I do not know of any framework that can match
> Django Admin).
> 
> The best answer to the original question may be to persuade him to try
> a better PHP CMS or framework. I am looking at some myself at the
> moment.
> 

+1

Joomla sucks IMHO and not a great example of PHP-based framework/CMS.

FWIW I think Symfony is a pretty good PHP framework. Uses OOP,
alternative ORMs and a pretty good admin interface right out of the box.
I found moving from it to Django relatively easy...

-- 
You received this message because you are subscribed to the Google Groups 
"Django users" group.
To post to this group, send email to django-users@googlegroups.com.
To unsubscribe from this group, send email to 
django-users+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-users?hl=en.

Re: Django Development environment

[Greg Maruszeczka]

On Mon, 22 Aug 2011 15:07:24 -0700 (PDT)
Stephen Jackson  wrote:

> I am new to the world of Django. I would like to hear from other
> django developers describe their dev environment (tools, os, editors,
> etc.).
> 

fedora, eclipse (pydev), mercurial, virtualenv, postgres, apache (wsgi)

-- 
You received this message because you are subscribed to the Google Groups 
"Django users" group.
To post to this group, send email to django-users@googlegroups.com.
To unsubscribe from this group, send email to 
django-users+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-users?hl=en.