Re: [dm-devel] [PATCH] multipathd: uxsock_timeout should be assigned by conf->uxsock_timeout

[Christophe Varoqui]

Good,
Merged.

On Tue, Oct 11, 2016 at 8:42 AM,  wrote:

> Please have a review for this patch, any comment will be highly
> appreciated.
>
>
>
>
> 发件人: tang.jun...@zte.com.cn
> 收件人: christophe varoqui ,
> 抄送:zhang.ka...@zte.com.cn, dm-devel@redhat.com, "tang.junhui" <
> tang.jun...@zte.com.cn>
> 日期:     2016/09/13 18:17
> 主题:    [dm-devel] [PATCH] multipathd: uxsock_timeout should be
> assigned byconf->uxsock_timeout
> 发件人:dm-devel-boun...@redhat.com
> --
>
>
>
> From: "tang.junhui" 
>
> uxsock_timeout should be assigned by conf->uxsock_timeout
> before using it in uxclnt() as a CLI client timeout value,
> otherwise its default value is 0, and the CLI client timeout
> value is 0 + 100(ms), so the CLI client will be timeout very
> quickly.
>
> Signed-off-by: tang.junhui 
> ---
> multipathd/main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/multipathd/main.c b/multipathd/main.c
> index 96ef01f..a08f1a5 100644
> --- a/multipathd/main.c
> +++ b/multipathd/main.c
> @@ -2549,6 +2549,7 @@ main (int argc, char *argv[])
>
> exit(1);
>if (verbosity)
>
> conf->verbosity = verbosity;
> +   uxsock_timeout =
> conf->uxsock_timeout;
>uxclnt(optarg,
> uxsock_timeout + 100);
>exit(0);
>   case 'B':
> @@ -2573,6 +2574,7 @@ main (int argc, char *argv[])
>exit(1);
>   if (verbosity)
>conf->verbosity =
> verbosity;
> +  uxsock_timeout = conf->uxsock_timeout;
>   memset(cmd, 0x0, CMDSIZE);
>   while (optind < argc) {
>if
> (strchr(argv[optind], ' '))
> --
> 2.8.1.windows.1
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
>
>
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] multipathd: uxsock_timeout should be assigned by conf->uxsock_timeout

[tang . junhui]

Please have a review for this patch, any comment will be highly 
appreciated.




发件人: tang.jun...@zte.com.cn
收件人: christophe varoqui , 
抄送:   zhang.ka...@zte.com.cn, dm-devel@redhat.com, "tang.junhui" 

日期:   2016/09/13 18:17
主题:   [dm-devel] [PATCH] multipathd: uxsock_timeout should be assigned 
by  conf->uxsock_timeout
发件人: dm-devel-boun...@redhat.com



From: "tang.junhui" 

uxsock_timeout should be assigned by conf->uxsock_timeout
before using it in uxclnt() as a CLI client timeout value,
otherwise its default value is 0, and the CLI client timeout
value is 0 + 100(ms), so the CLI client will be timeout very
quickly.

Signed-off-by: tang.junhui 
---
 multipathd/main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/multipathd/main.c b/multipathd/main.c
index 96ef01f..a08f1a5 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -2549,6 +2549,7 @@ main (int argc, char *argv[])
 exit(1);
 if (verbosity)
 conf->verbosity = verbosity;
+uxsock_timeout = 
conf->uxsock_timeout;
 uxclnt(optarg, 
uxsock_timeout + 100);
 exit(0);
 case 'B':
@@ -2573,6 +2574,7 @@ main (int argc, char *argv[])
 exit(1);
 if (verbosity)
 conf->verbosity = 
verbosity;
+uxsock_timeout = conf->uxsock_timeout;
 memset(cmd, 0x0, CMDSIZE);
 while (optind < argc) {
 if (strchr(argv[optind], 
' '))
-- 
2.8.1.windows.1

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel


--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipathd: uxsock_timeout should be assigned by conf->uxsock_timeout

[tang . junhui]

From: "tang.junhui" 

uxsock_timeout should be assigned by conf->uxsock_timeout
before using it in uxclnt() as a CLI client timeout value,
otherwise its default value is 0, and the CLI client timeout
value is 0 + 100(ms), so the CLI client will be timeout very
quickly.

Signed-off-by: tang.junhui 
---
 multipathd/main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/multipathd/main.c b/multipathd/main.c
index 96ef01f..a08f1a5 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -2549,6 +2549,7 @@ main (int argc, char *argv[])
exit(1);
if (verbosity)
conf->verbosity = verbosity;
+   uxsock_timeout = conf->uxsock_timeout;
uxclnt(optarg, uxsock_timeout + 100);
exit(0);
case 'B':
@@ -2573,6 +2574,7 @@ main (int argc, char *argv[])
exit(1);
if (verbosity)
conf->verbosity = verbosity;
+   uxsock_timeout = conf->uxsock_timeout;
memset(cmd, 0x0, CMDSIZE);
while (optind < argc) {
if (strchr(argv[optind], ' '))
-- 
2.8.1.windows.1

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel