Re: [dm-devel] [PATCH v4 05/11] dm: cleanup device_area_is_invalid()

2021-05-26 Thread Himanshu Madhani 




On 5/24/21 9:25 PM, Damien Le Moal wrote:

In device_area_is_invalid(), use bdev_is_zoned() instead of open
coding the test on the zoned model returned by bdev_zoned_model().

Signed-off-by: Damien Le Moal 
Reviewed-by: Johannes Thumshirn 
Reviewed-by: Hannes Reinecke 
---
  drivers/md/dm-table.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index ee47a332b462..21fd9cd4da32 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -249,7 +249,7 @@ static int device_area_is_invalid(struct dm_target *ti, 
struct dm_dev *dev,
 * If the target is mapped to zoned block device(s), check
 * that the zones are not partially mapped.
 */
-   if (bdev_zoned_model(bdev) != BLK_ZONED_NONE) {
+   if (bdev_is_zoned(bdev)) {
unsigned int zone_sectors = bdev_zone_sectors(bdev);
  
  		if (start & (zone_sectors - 1)) {




Reviewed-by: Himanshu Madhani 

--
Himanshu MadhaniOracle Linux Engineering

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v4 05/11] dm: cleanup device_area_is_invalid()

2021-05-25 Thread Christoph Hellwig 
On Tue, May 25, 2021 at 11:25:33AM +0900, Damien Le Moal wrote:
> In device_area_is_invalid(), use bdev_is_zoned() instead of open
> coding the test on the zoned model returned by bdev_zoned_model().
> 
> Signed-off-by: Damien Le Moal 
> Reviewed-by: Johannes Thumshirn 
> Reviewed-by: Hannes Reinecke 

Looks good,

Reviewed-by: Christoph Hellwig 

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH v4 05/11] dm: cleanup device_area_is_invalid()

2021-05-24 Thread Damien Le Moal 
In device_area_is_invalid(), use bdev_is_zoned() instead of open
coding the test on the zoned model returned by bdev_zoned_model().

Signed-off-by: Damien Le Moal 
Reviewed-by: Johannes Thumshirn 
Reviewed-by: Hannes Reinecke 
---
 drivers/md/dm-table.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index ee47a332b462..21fd9cd4da32 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -249,7 +249,7 @@ static int device_area_is_invalid(struct dm_target *ti, 
struct dm_dev *dev,
 * If the target is mapped to zoned block device(s), check
 * that the zones are not partially mapped.
 */
-   if (bdev_zoned_model(bdev) != BLK_ZONED_NONE) {
+   if (bdev_is_zoned(bdev)) {
unsigned int zone_sectors = bdev_zone_sectors(bdev);
 
if (start & (zone_sectors - 1)) {
-- 
2.31.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel