Re: [dm-devel] [PATCH 06/11] block: Introduce BLKGETZONESZ ioctl

[Bart Van Assche]

On Wed, 2018-10-10 at 10:52 +0900, Damien Le Moal wrote:
>  #define BLKREPORTZONE_IOWR(0x12, 130, struct blk_zone_report)
>  #define BLKRESETZONE _IOW(0x12, 131, struct blk_zone_range)
> +#define BLKGETZONESZ _IOW(0x12, 132, unsigned int)

>From Documentation/ioctl/botching-up-ioctls.txt, a collection of lessons 
>learned
the hard way about ioctls:

 * Only use fixed sized integers. To avoid conflicts with typedefs in userspace
   the kernel has special types like __u32, __s64. Use them.

Please follow that advice.

Thanks,

Bart.

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 06/11] block: Introduce BLKGETZONESZ ioctl

[Christoph Hellwig]

On Wed, Oct 10, 2018 at 10:52:34AM +0900, Damien Le Moal wrote:
> Get a zoned block device zone size in number of 512 B sectors.
> The zone size is always 0 for regular block devices.

Looks good,

Reviewed-by: Christoph Hellwig 

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel