Re: [Dolibarr-dev] Patch dolibarr 9.0.2 - allow accounts in "0"

2019-06-17 Par sujet Eric Seigne 
Ok,

sorry i've just re-activate an old account for that ... :-)

-> https://github.com/Dolibarr/dolibarr/pull/11354

Éric

Le 11/06/2019 à 18:10, Laurent Destailleur (aka Eldy) a écrit :
> We never tried this but it may be a good case to test this
>
> Le lun. 20 mai 2019 à 12:40, Eric Seigne  > a écrit :
>
> Hello all,
>
> i'm sorry but i don't want to have and use a github account :-)
>
> 
> https://help.github.com/en/articles/github-terms-of-service#d-user-generated-content
>
> 
> https://help.github.com/en/articles/github-terms-of-service#f-copyright-infringement-and-dmca-policy
>
> so i will do the job on something like
> https://framagit.org/public/projects for a next release ... i hope
> we can make PR from a gitlab instance to github ?
>
> Éric
>
> Le 14/05/2019 à 12:39, Laurent Destailleur (aka Eldy) a écrit :
>> If you want to avoid using git, you can still edit online the
>> files with your modifications from your fork done on github and
>> send the PR that github can generate for you.
>>
>> Le mar. 23 avr. 2019 à 11:06, Eric Seigne > > a écrit :
>>
>> Hello all,
>>
>> here is a patch for dolibarr 9.0.2 wich replace "empty" by
>> "!= '' tests
>> againts fournisseurs accounts because i use "0" as prefix for
>> theses
>> accounts.
>>
>> i don't know if it could be used in official dolibarr sources
>> ? if yes i
>> can make a pull request for that.
>>
>> Éric
>>
>> -- 
>> Éric Seigne             | CAP-REL*
>> eric.sei...@cap-rel.fr   | +33
>> (0)6 987 444 01
>> https://cap-rel.fr      | *Réseau Expertise Linux
>>
>> ___
>> Dolibarr-dev mailing list
>> Dolibarr-dev@nongnu.org 
>> https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
>>
>>
>>
>> -- 
>> EMail: e...@destailleur.fr 
>> Web: http://www.destailleur.fr
>> 
>> 
>> Google+: https://plus.google.com/+LaurentDestailleur-Open-Source-Expert/
>> Facebook: https://www.facebook.com/Destailleur.Laurent
>> Twitter: http://www.twitter.com/eldy10
>> 
>> 
>> * Dolibarr (Project leader): https://www.dolibarr.org (make a
>> donation for Dolibarr project via Paypal: cont...@destailleur.fr
>> )
>> * AWStats (Author) : http://awstats.sourceforge.net (make a
>> donation for AWStats project via Paypal: cont...@destailleur.fr
>> )
>> * AWBot (Author) : http://awbot.sourceforge.net
>> * CVSChangeLogBuilder (Author) : http://cvschangelogb.sourceforge.net
>>
>>
>>
>> ___
>> Dolibarr-dev mailing list
>> Dolibarr-dev@nongnu.org 
>> https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
>
> -- 
> Éric Seigne | CAP-REL*
> eric.sei...@cap-rel.fr   | +33 (0)6 987 
> 444 01
> https://cap-rel.fr  | *Réseau Expertise Linux
>
> ___
> Dolibarr-dev mailing list
> Dolibarr-dev@nongnu.org 
> https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
>
>
>
> -- 
> EMail: e...@destailleur.fr 
> Web: http://www.destailleur.fr
> 
> Google+: https://plus.google.com/+LaurentDestailleur-Open-Source-Expert/
> Facebook: https://www.facebook.com/Destailleur.Laurent
> Twitter: http://www.twitter.com/eldy10
> 
> * Dolibarr (Project leader): https://www.dolibarr.org (make a donation
> for Dolibarr project via Paypal: cont...@destailleur.fr
> )
> * AWStats (Author) : http://awstats.sourceforge.net (make a donation
> for AWStats project via Paypal: cont...@destailleur.fr
> )
> * AWBot (Author) : http://awbot.sourceforge.net
> * CVSChangeLogBuilder (Author) : http://cvschangelogb.sourceforge.net
>
>
>
> ___
> Dolibarr-dev mailing list
> Dolibarr-dev@nongnu.org
> https://lists.nongnu.org/mailman/listinfo/dolibarr-dev

-- 
Éric Seigne | CAP-REL*
eric.sei...@cap-rel.fr  | +33 (0)6 987 444 01
https://cap-rel.fr  | *Réseau Expertise Linux

___
Dolibarr-dev mailing list
Dolibarr-dev@nongnu.org

Re: [Dolibarr-dev] Patch dolibarr 9.0.2 - allow accounts in "0"

2019-06-11 Par sujet Sasa Ostrouska 
Excuse me if I fall into this, but isnt it possible to do PR and apply
a simple patch simply with git ?
git diff should be enough to submit a patch to the ML for review and
then it is easy to apply if all is ok.

Just my 2 cents, why migrate everything to a gitlab or other portal ???

Rgds
Saxa

On Tue, Jun 11, 2019 at 6:57 PM Laurent Destailleur (aka Eldy)
 wrote:
>
> We never tried this but it may be a good case to test this
>
> Le lun. 20 mai 2019 à 12:40, Eric Seigne  a écrit :
>>
>> Hello all,
>>
>> i'm sorry but i don't want to have and use a github account :-)
>>
>> https://help.github.com/en/articles/github-terms-of-service#d-user-generated-content
>>
>> https://help.github.com/en/articles/github-terms-of-service#f-copyright-infringement-and-dmca-policy
>>
>> so i will do the job on something like https://framagit.org/public/projects 
>> for a next release ... i hope we can make PR from a gitlab instance to 
>> github ?
>>
>> Éric
>>
>> Le 14/05/2019 à 12:39, Laurent Destailleur (aka Eldy) a écrit :
>>
>> If you want to avoid using git, you can still edit online the files with 
>> your modifications from your fork done on github and send the PR that github 
>> can generate for you.
>>
>> Le mar. 23 avr. 2019 à 11:06, Eric Seigne  a écrit :
>>>
>>> Hello all,
>>>
>>> here is a patch for dolibarr 9.0.2 wich replace "empty" by "!= '' tests
>>> againts fournisseurs accounts because i use "0" as prefix for theses
>>> accounts.
>>>
>>> i don't know if it could be used in official dolibarr sources ? if yes i
>>> can make a pull request for that.
>>>
>>> Éric
>>>
>>> --
>>> Éric Seigne | CAP-REL*
>>> eric.sei...@cap-rel.fr  | +33 (0)6 987 444 01
>>> https://cap-rel.fr  | *Réseau Expertise Linux
>>>
>>> ___
>>> Dolibarr-dev mailing list
>>> Dolibarr-dev@nongnu.org
>>> https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
>>
>>
>>
>> --
>> EMail: e...@destailleur.fr
>> Web: http://www.destailleur.fr
>> 
>> Google+: https://plus.google.com/+LaurentDestailleur-Open-Source-Expert/
>> Facebook: https://www.facebook.com/Destailleur.Laurent
>> Twitter: http://www.twitter.com/eldy10
>> 
>> * Dolibarr (Project leader): https://www.dolibarr.org (make a donation for 
>> Dolibarr project via Paypal: cont...@destailleur.fr)
>> * AWStats (Author) : http://awstats.sourceforge.net (make a donation for 
>> AWStats project via Paypal: cont...@destailleur.fr)
>> * AWBot (Author) : http://awbot.sourceforge.net
>> * CVSChangeLogBuilder (Author) : http://cvschangelogb.sourceforge.net
>>
>>
>>
>> ___
>> Dolibarr-dev mailing list
>> Dolibarr-dev@nongnu.org
>> https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
>>
>> --
>> Éric Seigne | CAP-REL*
>> eric.sei...@cap-rel.fr  | +33 (0)6 987 444 01
>> https://cap-rel.fr  | *Réseau Expertise Linux
>>
>> ___
>> Dolibarr-dev mailing list
>> Dolibarr-dev@nongnu.org
>> https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
>
>
>
> --
> EMail: e...@destailleur.fr
> Web: http://www.destailleur.fr
> 
> Google+: https://plus.google.com/+LaurentDestailleur-Open-Source-Expert/
> Facebook: https://www.facebook.com/Destailleur.Laurent
> Twitter: http://www.twitter.com/eldy10
> 
> * Dolibarr (Project leader): https://www.dolibarr.org (make a donation for 
> Dolibarr project via Paypal: cont...@destailleur.fr)
> * AWStats (Author) : http://awstats.sourceforge.net (make a donation for 
> AWStats project via Paypal: cont...@destailleur.fr)
> * AWBot (Author) : http://awbot.sourceforge.net
> * CVSChangeLogBuilder (Author) : http://cvschangelogb.sourceforge.net
>
>
> ___
> Dolibarr-dev mailing list
> Dolibarr-dev@nongnu.org
> https://lists.nongnu.org/mailman/listinfo/dolibarr-dev

___
Dolibarr-dev mailing list
Dolibarr-dev@nongnu.org
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev

Re: [Dolibarr-dev] Patch dolibarr 9.0.2 - allow accounts in "0"

2019-06-11 Par sujet Laurent Destailleur (aka Eldy) 
We never tried this but it may be a good case to test this

Le lun. 20 mai 2019 à 12:40, Eric Seigne  a écrit :

> Hello all,
>
> i'm sorry but i don't want to have and use a github account :-)
>
>
> https://help.github.com/en/articles/github-terms-of-service#d-user-generated-content
>
>
> https://help.github.com/en/articles/github-terms-of-service#f-copyright-infringement-and-dmca-policy
>
> so i will do the job on something like
> https://framagit.org/public/projects for a next release ... i hope we can
> make PR from a gitlab instance to github ?
>
> Éric
> Le 14/05/2019 à 12:39, Laurent Destailleur (aka Eldy) a écrit :
>
> If you want to avoid using git, you can still edit online the files with
> your modifications from your fork done on github and send the PR that
> github can generate for you.
>
> Le mar. 23 avr. 2019 à 11:06, Eric Seigne  a
> écrit :
>
>> Hello all,
>>
>> here is a patch for dolibarr 9.0.2 wich replace "empty" by "!= '' tests
>> againts fournisseurs accounts because i use "0" as prefix for theses
>> accounts.
>>
>> i don't know if it could be used in official dolibarr sources ? if yes i
>> can make a pull request for that.
>>
>> Éric
>>
>> --
>> Éric Seigne | CAP-REL*
>> eric.sei...@cap-rel.fr  | +33 (0)6 987 444 01
>> https://cap-rel.fr  | *Réseau Expertise Linux
>>
>> ___
>> Dolibarr-dev mailing list
>> Dolibarr-dev@nongnu.org
>> https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
>>
>
>
> --
> EMail: e...@destailleur.fr
> Web: http://www.destailleur.fr
>
> 
> Google+: https://plus.google.com/+LaurentDestailleur-Open-Source-Expert/
> Facebook: https://www.facebook.com/Destailleur.Laurent
> Twitter: http://www.twitter.com/eldy10
>
> 
> * Dolibarr (Project leader): https://www.dolibarr.org (make a donation
> for Dolibarr project via Paypal: cont...@destailleur.fr)
> * AWStats (Author) : http://awstats.sourceforge.net (make a donation for
> AWStats project via Paypal: cont...@destailleur.fr)
> * AWBot (Author) : http://awbot.sourceforge.net
> * CVSChangeLogBuilder (Author) : http://cvschangelogb.sourceforge.net
>
>
>
> ___
> Dolibarr-dev mailing 
> listDolibarr-dev@nongnu.orghttps://lists.nongnu.org/mailman/listinfo/dolibarr-dev
>
> --
> Éric Seigne | CAP-REL*eric.sei...@cap-rel.fr  | +33 (0)6 987 444 
> 01https://cap-rel.fr  | *Réseau Expertise Linux
>
> ___
> Dolibarr-dev mailing list
> Dolibarr-dev@nongnu.org
> https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
>


-- 
EMail: e...@destailleur.fr
Web: http://www.destailleur.fr

Google+: https://plus.google.com/+LaurentDestailleur-Open-Source-Expert/
Facebook: https://www.facebook.com/Destailleur.Laurent
Twitter: http://www.twitter.com/eldy10

* Dolibarr (Project leader): https://www.dolibarr.org (make a donation for
Dolibarr project via Paypal: cont...@destailleur.fr)
* AWStats (Author) : http://awstats.sourceforge.net (make a donation for
AWStats project via Paypal: cont...@destailleur.fr)
* AWBot (Author) : http://awbot.sourceforge.net
* CVSChangeLogBuilder (Author) : http://cvschangelogb.sourceforge.net
___
Dolibarr-dev mailing list
Dolibarr-dev@nongnu.org
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev

Re: [Dolibarr-dev] Patch dolibarr 9.0.2 - allow accounts in "0"

2019-05-20 Par sujet Eric Seigne 
Hello all,

i'm sorry but i don't want to have and use a github account :-)

https://help.github.com/en/articles/github-terms-of-service#d-user-generated-content

https://help.github.com/en/articles/github-terms-of-service#f-copyright-infringement-and-dmca-policy

so i will do the job on something like
https://framagit.org/public/projects for a next release ... i hope we
can make PR from a gitlab instance to github ?

Éric

Le 14/05/2019 à 12:39, Laurent Destailleur (aka Eldy) a écrit :
> If you want to avoid using git, you can still edit online the files
> with your modifications from your fork done on github and send the PR
> that github can generate for you.
>
> Le mar. 23 avr. 2019 à 11:06, Eric Seigne  > a écrit :
>
> Hello all,
>
> here is a patch for dolibarr 9.0.2 wich replace "empty" by "!= ''
> tests
> againts fournisseurs accounts because i use "0" as prefix for theses
> accounts.
>
> i don't know if it could be used in official dolibarr sources ? if
> yes i
> can make a pull request for that.
>
> Éric
>
> -- 
> Éric Seigne             | CAP-REL*
> eric.sei...@cap-rel.fr   | +33 (0)6
> 987 444 01
> https://cap-rel.fr      | *Réseau Expertise Linux
>
> ___
> Dolibarr-dev mailing list
> Dolibarr-dev@nongnu.org 
> https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
>
>
>
> -- 
> EMail: e...@destailleur.fr 
> Web: http://www.destailleur.fr
> 
> Google+: https://plus.google.com/+LaurentDestailleur-Open-Source-Expert/
> Facebook: https://www.facebook.com/Destailleur.Laurent
> Twitter: http://www.twitter.com/eldy10
> 
> * Dolibarr (Project leader): https://www.dolibarr.org (make a donation
> for Dolibarr project via Paypal: cont...@destailleur.fr
> )
> * AWStats (Author) : http://awstats.sourceforge.net (make a donation
> for AWStats project via Paypal: cont...@destailleur.fr
> )
> * AWBot (Author) : http://awbot.sourceforge.net
> * CVSChangeLogBuilder (Author) : http://cvschangelogb.sourceforge.net
>
>
>
> ___
> Dolibarr-dev mailing list
> Dolibarr-dev@nongnu.org
> https://lists.nongnu.org/mailman/listinfo/dolibarr-dev

-- 
Éric Seigne | CAP-REL*
eric.sei...@cap-rel.fr  | +33 (0)6 987 444 01
https://cap-rel.fr  | *Réseau Expertise Linux

___
Dolibarr-dev mailing list
Dolibarr-dev@nongnu.org
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev

Re: [Dolibarr-dev] Patch dolibarr 9.0.2 - allow accounts in "0"

2019-05-14 Par sujet Laurent Destailleur (aka Eldy) 
If you want to avoid using git, you can still edit online the files with
your modifications from your fork done on github and send the PR that
github can generate for you.

Le mar. 23 avr. 2019 à 11:06, Eric Seigne  a écrit :

> Hello all,
>
> here is a patch for dolibarr 9.0.2 wich replace "empty" by "!= '' tests
> againts fournisseurs accounts because i use "0" as prefix for theses
> accounts.
>
> i don't know if it could be used in official dolibarr sources ? if yes i
> can make a pull request for that.
>
> Éric
>
> --
> Éric Seigne | CAP-REL*
> eric.sei...@cap-rel.fr  | +33 (0)6 987 444 01
> https://cap-rel.fr  | *Réseau Expertise Linux
>
> ___
> Dolibarr-dev mailing list
> Dolibarr-dev@nongnu.org
> https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
>


-- 
EMail: e...@destailleur.fr
Web: http://www.destailleur.fr

Google+: https://plus.google.com/+LaurentDestailleur-Open-Source-Expert/
Facebook: https://www.facebook.com/Destailleur.Laurent
Twitter: http://www.twitter.com/eldy10

* Dolibarr (Project leader): https://www.dolibarr.org (make a donation for
Dolibarr project via Paypal: cont...@destailleur.fr)
* AWStats (Author) : http://awstats.sourceforge.net (make a donation for
AWStats project via Paypal: cont...@destailleur.fr)
* AWBot (Author) : http://awbot.sourceforge.net
* CVSChangeLogBuilder (Author) : http://cvschangelogb.sourceforge.net
___
Dolibarr-dev mailing list
Dolibarr-dev@nongnu.org
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev

[Dolibarr-dev] Patch dolibarr 9.0.2 - allow accounts in "0"

2019-04-23 Par sujet Eric Seigne 
Hello all,

here is a patch for dolibarr 9.0.2 wich replace "empty" by "!= '' tests
againts fournisseurs accounts because i use "0" as prefix for theses
accounts.

i don't know if it could be used in official dolibarr sources ? if yes i
can make a pull request for that.

Éric

-- 
Éric Seigne | CAP-REL*
eric.sei...@cap-rel.fr  | +33 (0)6 987 444 01
https://cap-rel.fr  | *Réseau Expertise Linux

diff -ru dolibarr-9.0.2/htdocs/accountancy/bookkeeping/listbyaccount.php dolibarr-9.0.2-patched/htdocs/accountancy/bookkeeping/listbyaccount.php
--- dolibarr-9.0.2/htdocs/accountancy/bookkeeping/listbyaccount.php	2018-11-05 20:20:32.0 +0100
+++ dolibarr-9.0.2-patched/htdocs/accountancy/bookkeeping/listbyaccount.php	2019-04-23 09:43:02.287851117 +0200
@@ -350,7 +350,7 @@
 		$colspan = 9;
 		print "";
 		print '';
-		if (! empty($line->numero_compte) && $line->numero_compte != '-1') print length_accountg($line->numero_compte) . ' : ' . $object->get_compte_desc($line->numero_compte);
+		if ($line->numero_compte != "" && $line->numero_compte != '-1') print length_accountg($line->numero_compte) . ' : ' . $object->get_compte_desc($line->numero_compte);
 		else print ''.$langs->trans("Unknown").'';
 		print '';
 		print '';
diff -ru dolibarr-9.0.2/htdocs/accountancy/class/bookkeeping.class.php dolibarr-9.0.2-patched/htdocs/accountancy/class/bookkeeping.class.php
--- dolibarr-9.0.2/htdocs/accountancy/class/bookkeeping.class.php	2019-02-12 13:36:31.0 +0100
+++ dolibarr-9.0.2-patched/htdocs/accountancy/class/bookkeeping.class.php	2019-04-23 09:39:04.966776412 +0200
@@ -221,7 +221,7 @@
 		if (empty($this->credit)) $this->credit = 0;
 
 		// Check parameters
-		if (empty($this->numero_compte) || $this->numero_compte == '-1' || $this->numero_compte == 'NotDefined')
+		if (($this->numero_compte == "") || $this->numero_compte == '-1' || $this->numero_compte == 'NotDefined')
 		{
 			$langs->loadLangs(array("errors"));
 			if (in_array($this->doc_type, array('bank', 'expense_report')))
diff -ru dolibarr-9.0.2/htdocs/accountancy/class/lettering.class.php dolibarr-9.0.2-patched/htdocs/accountancy/class/lettering.class.php
--- dolibarr-9.0.2/htdocs/accountancy/class/lettering.class.php	2018-12-04 11:58:12.0 +0100
+++ dolibarr-9.0.2-patched/htdocs/accountancy/class/lettering.class.php	2019-04-23 09:50:56.829785389 +0200
@@ -67,11 +67,11 @@
 		$sql .= " FROM " . MAIN_DB_PREFIX . "accounting_bookkeeping as bk";
 		$sql .= " LEFT JOIN  " . MAIN_DB_PREFIX . "bank_url as bu ON(bk.fk_doc = bu.fk_bank AND bu.type IN ('payment', 'payment_supplier') ) ";
 		$sql .= " WHERE   ( ";
-		if (! empty($object->code_compta))
+		if ($object->code_compta != "")
 			$sql .= "  bk.subledger_account = '" . $object->code_compta . "'  ";
-		if (! empty($object->code_compta) && ! empty($object->code_compta_fournisseur))
+		if ($object->code_compta != "" && $object->code_compta_fournisseur != "")
 			$sql .= "  OR  ";
-		if (! empty($object->code_compta_fournisseur))
+		if (! $object->code_compta_fournisseur != "")
 			$sql .= "   bk.subledger_account = '" . $object->code_compta_fournisseur . "' ";
 
 		$sql .= " ) AND (bk.date_lettering ='' OR bk.date_lettering IS NULL) ";
@@ -99,13 +99,13 @@
 	$sql .= " AND facf.entity = ".$conf->entity;
 	$sql .= " AND code_journal IN (SELECT code FROM " . MAIN_DB_PREFIX . "accounting_journal WHERE nature=4 AND entity=".$conf->entity.") ";
 	$sql .= " AND ( ";
-	if (! empty($object->code_compta)) {
+	if ($object->code_compta != "") {
 		$sql .= "  bk.subledger_account = '" . $object->code_compta . "'  ";
 	}
-	if (! empty($object->code_compta) && ! empty($object->code_compta_fournisseur)) {
+	if ($object->code_compta != "" && $object->code_compta_fournisseur != "") {
 		$sql .= "  OR  ";
 	}
-	if (! empty($object->code_compta_fournisseur)) {
+	if (! $object->code_compta_fournisseur != "") {
 		$sql .= "   bk.subledger_account = '" . $object->code_compta_fournisseur . "' ";
 	}
 	$sql .= " )  ";
@@ -127,13 +127,13 @@
 		$sql .= " WHERE bk.code_journal IN (SELECT code FROM " . MAIN_DB_PREFIX . "accounting_journal WHERE nature=3 AND entity=".$conf->entity.") ";
 		$sql .= " AND facf.entity = ".$conf->entity;
 		$sql .= " AND ( ";
-		if (! empty($object->code_compta)) {
+		if ($object->code_compta != "") {
 			$sql .= "  bk.subledger_account = '" . $object->code_compta . "'  ";
 		}
-		if (! empty($object->code_compta) && ! empty($object->code_compta_fournisseur)) {
+		if ($object->code_compta != "" && $object->code_compta_fournisseur != "") {
 			$sql .= "  OR  ";
 		}
-		if (! empty($object->code_compta_fournisseur)) {
+		if ($object->code_compta_fournisseur != "") {
 			$sql .= "   bk.subledger_account = '" . $object->code_compta_fournisseur . "' ";
 		}
 		$sql .= " )  ";
@@ -159,13 +159,13 @@
 	$sql .= " AND bk.code_journal IN (SELECT code FROM " .