Re: [Dovecot] expire-tool fails if mail_location contains %h

2008-11-21 Thread Timo Sirainen
On Tue, 2008-11-04 at 17:36 +0100, Thorsten Vollmer wrote:
 Hi Timo,
 
 not long ago you fixed a bug regarding the expansion of ~/ in
 mail_location that prevented expire-tool from working correctly. A
 similar problem exists if mail_location contains %h: expire-tool will
 use the wrong path to access the mailbox. After replacing %h with ~,
 expire-tool works as expected.
 
 Why are there two variables for the home directory? Maybe the use of %h
 could be discouraged, sparing you some problems.

In earlier versions ~/ expansion didn't work everywhere so %h is used in
examples because of that. But nowadays ~/ expansion does work
everywhere, so %h is a bit pointless in most places. Also the %h (just
like all %variable) expansion happens early in the configuration
parsing, so expire-tool can't really be fixed to handle %h.

Well, I added a note now to http://wiki.dovecot.org/Variables and
removed %h from http://wiki.dovecot.org/MailLocation. I don't really
have better ideas how to discourage it.



signature.asc
Description: This is a digitally signed message part


Re: [Dovecot] expire-tool fails if mail_location contains %h

2008-11-21 Thread Thorsten Vollmer
On Fri, 2008-11-21 at 22:26 +0200, Timo Sirainen wrote:
 On Tue, 2008-11-04 at 17:36 +0100, Thorsten Vollmer wrote:
  not long ago you fixed a bug regarding the expansion of ~/ in
  mail_location that prevented expire-tool from working correctly. A
  similar problem exists if mail_location contains %h: expire-tool will
  use the wrong path to access the mailbox. After replacing %h with ~,
  expire-tool works as expected.
  
  Why are there two variables for the home directory? Maybe the use of %h
  could be discouraged, sparing you some problems.
 
 In earlier versions ~/ expansion didn't work everywhere so %h is used in
 examples because of that. But nowadays ~/ expansion does work
 everywhere, so %h is a bit pointless in most places. Also the %h (just
 like all %variable) expansion happens early in the configuration
 parsing, so expire-tool can't really be fixed to handle %h.
 
 Well, I added a note now to http://wiki.dovecot.org/Variables and
 removed %h from http://wiki.dovecot.org/MailLocation. I don't really
 have better ideas how to discourage it.

I think this is sufficient.

Thanks for the explanation.

Thorsten



signature.asc
Description: This is a digitally signed message part