[RFC] Re: [PATCH 0/1] drm-set-default-noedid-res.patch
Dave, >> Some monitors and, more often, kvm switches do not provide working >> EDID data. KMS based X configurations in recent server versions no >> longer allow to override the screen resolution which makes it >> impossible to correctly adapt the screen resolution to the monitor >> in use. This patch allows to define the fallback screen resolution >> to something else than the default 1024x768. > Does video=800x600 not work for you? I did a lot more tests; apparently, things are even more difficult than expected. These are my observations (all with Radeon X1950 and radeon driver): - On the monitor side: In addition to the known quirks, the EDID data may not be accessible or erroneous. The original patch only solved the situation of unavailable EDID data. A frequent reason of erroneous or unavailable EDID data is the use of suboptimally designed KVM switches that are unable to probe the connected monitor and send no or fantasy EDID data. - On the Xorg side: Older radeon drivers recognize the options "IgnoreEDID" and "NoDDC". Using this trick, Xorg can be forced to disregard any EDID data and use the resolution as specified in xorg.conf. Less old radeon drivers still recognize the option "IgnoreEDID", but this does not work any longer, since the option "NoDDC" has been abandoned. Such drivers rely on correct EDID data. Current radeon drivers should have the option "CustomEDID" to override the probed EDID data (at least this is what the manual says), but I couldn't get it working. The log file insists on saying that the option "CustomEDID" is not used. These drivers also rely on correct EDID data. My conclusion is, that the right place to solve the situation is in the kernel. The attached patch makes the sysfs edid entry writable. If the name of an existing binary EDID data file in /lib/firmware is supplied such as cd /sys/devices/pci:00/:00:07.0/:05:00.0/drm/card0 echo dvi_0.bin >card0-DVI-I-1/edid the related connector will be set to these EDID data. Any probing is then disabled. To restore the previous behavior and to re-enable monitor probing, an empty string or a single line delimiter must be sent: echo >card0-DVI-I-1/edid I have tested the patch successfully in a number of different configurations. When userspace setup tools such as gnome-display-properties are used, the name and resolution data of the provided (fake) EDID data are correctly decoded. When compared to the various X hacks I tried, I find this solution better, since it solves the problem at a place where it belongs. This is in line with the observation that EDID related functionality appears to fade out of X drivers. Does this make sense? Carsten. -- next part -- A non-text attachment was scrubbed... Name: drivers-gpu-drm-allow-to-load-edid-firmware.patch Type: text/x-patch Size: 4333 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20100524/8cf772c1/attachment.bin>
[PATCH resent twice 2/3] vgaarb: use MIT license
Signed-off-by: Tiago Vignatti Cc: Henry Zhao --- Jesse and Dave, that was send two times already and no one said anything. Please, pull it. Oracle's Henry Zhao is already employing it in Solaris and, after all authors agreed, we haven't changed yet the license. drivers/gpu/vga/vgaarb.c | 26 +++--- include/linux/vgaarb.h | 21 + 2 files changed, 44 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c index 290b0cc..b87569e 100644 --- a/drivers/gpu/vga/vgaarb.c +++ b/drivers/gpu/vga/vgaarb.c @@ -1,12 +1,32 @@ /* - * vgaarb.c + * vgaarb.c: Implements the VGA arbitration. For details refer to + * Documentation/vgaarbiter.txt + * * * (C) Copyright 2005 Benjamin Herrenschmidt * (C) Copyright 2007 Paulo R. Zanoni * (C) Copyright 2007, 2009 Tiago Vignatti * - * Implements the VGA arbitration. For details refer to - * Documentation/vgaarbiter.txt + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the "Software"), + * to deal in the Software without restriction, including without limitation + * the rights to use, copy, modify, merge, publish, distribute, sublicense, + * and/or sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice (including the next + * paragraph) shall be included in all copies or substantial portions of the + * Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS + * IN THE SOFTWARE. + * */ #include diff --git a/include/linux/vgaarb.h b/include/linux/vgaarb.h index 2dfaa29..c9a9759 100644 --- a/include/linux/vgaarb.h +++ b/include/linux/vgaarb.h @@ -5,6 +5,27 @@ * (C) Copyright 2005 Benjamin Herrenschmidt * (C) Copyright 2007 Paulo R. Zanoni * (C) Copyright 2007, 2009 Tiago Vignatti + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the "Software"), + * to deal in the Software without restriction, including without limitation + * the rights to use, copy, modify, merge, publish, distribute, sublicense, + * and/or sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice (including the next + * paragraph) shall be included in all copies or substantial portions of the + * Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS + * IN THE SOFTWARE. + * */ #ifndef LINUX_VGA_H -- 1.6.0.4
[PATCH 1/3] vgaarb: convert pr_devel() to pr_debug()
We want to be able to use CONFIG_DYNAMIC_DEBUG in arbiter code, switch
the few existing pr_devel() calls to pr_debug().
Also, add one more debug information regarding decoding count.
Signed-off-by: Tiago Vignatti
---
drivers/gpu/vga/vgaarb.c | 35 ++-
1 files changed, 18 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c
index 441e38c..290b0cc 100644
--- a/drivers/gpu/vga/vgaarb.c
+++ b/drivers/gpu/vga/vgaarb.c
@@ -155,8 +155,8 @@ static struct vga_device *__vga_tryget(struct vga_device
*vgadev,
(vgadev->decodes & VGA_RSRC_LEGACY_MEM))
rsrc |= VGA_RSRC_LEGACY_MEM;
- pr_devel("%s: %d\n", __func__, rsrc);
- pr_devel("%s: owns: %d\n", __func__, vgadev->owns);
+ pr_debug("%s: %d\n", __func__, rsrc);
+ pr_debug("%s: owns: %d\n", __func__, vgadev->owns);
/* Check what resources we need to acquire */
wants = rsrc & ~vgadev->owns;
@@ -268,7 +268,7 @@ static void __vga_put(struct vga_device *vgadev, unsigned
int rsrc)
{
unsigned int old_locks = vgadev->locks;
- pr_devel("%s\n", __func__);
+ pr_debug("%s\n", __func__);
/* Update our counters, and account for equivalent legacy resources
* if we decode them
@@ -575,6 +575,7 @@ static inline void vga_update_device_decodes(struct
vga_device *vgadev,
else
vga_decode_count--;
}
+ pr_debug("vgaarb: decoding count now is: %d\n", vga_decode_count);
}
void __vga_set_legacy_decoding(struct pci_dev *pdev, unsigned int decodes,
bool userspace)
@@ -831,7 +832,7 @@ static ssize_t vga_arb_write(struct file *file, const char
__user * buf,
curr_pos += 5;
remaining -= 5;
- pr_devel("client 0x%p called 'lock'\n", priv);
+ pr_debug("client 0x%p called 'lock'\n", priv);
if (!vga_str_to_iostate(curr_pos, remaining, _state)) {
ret_val = -EPROTO;
@@ -867,7 +868,7 @@ static ssize_t vga_arb_write(struct file *file, const char
__user * buf,
curr_pos += 7;
remaining -= 7;
- pr_devel("client 0x%p called 'unlock'\n", priv);
+ pr_debug("client 0x%p called 'unlock'\n", priv);
if (strncmp(curr_pos, "all", 3) == 0)
io_state = VGA_RSRC_LEGACY_IO | VGA_RSRC_LEGACY_MEM;
@@ -917,7 +918,7 @@ static ssize_t vga_arb_write(struct file *file, const char
__user * buf,
curr_pos += 8;
remaining -= 8;
- pr_devel("client 0x%p called 'trylock'\n", priv);
+ pr_debug("client 0x%p called 'trylock'\n", priv);
if (!vga_str_to_iostate(curr_pos, remaining, _state)) {
ret_val = -EPROTO;
@@ -961,7 +962,7 @@ static ssize_t vga_arb_write(struct file *file, const char
__user * buf,
curr_pos += 7;
remaining -= 7;
- pr_devel("client 0x%p called 'target'\n", priv);
+ pr_debug("client 0x%p called 'target'\n", priv);
/* if target is default */
if (!strncmp(curr_pos, "default", 7))
pdev = pci_dev_get(vga_default_device());
@@ -971,11 +972,11 @@ static ssize_t vga_arb_write(struct file *file, const
char __user * buf,
ret_val = -EPROTO;
goto done;
}
- pr_devel("vgaarb: %s ==> %x:%x:%x.%x\n", curr_pos,
+ pr_debug("vgaarb: %s ==> %x:%x:%x.%x\n", curr_pos,
domain, bus, PCI_SLOT(devfn), PCI_FUNC(devfn));
pbus = pci_find_bus(domain, bus);
- pr_devel("vgaarb: pbus %p\n", pbus);
+ pr_debug("vgaarb: pbus %p\n", pbus);
if (pbus == NULL) {
pr_err("vgaarb: invalid PCI domain and/or bus
address %x:%x\n",
domain, bus);
@@ -983,7 +984,7 @@ static ssize_t vga_arb_write(struct file *file, const char
__user * buf,
goto done;
}
pdev = pci_get_slot(pbus, devfn);
- pr_devel("vgaarb: pdev %p\n", pdev);
+ pr_debug("vgaarb: pdev %p\n", pdev);
if (!pdev) {
pr_err("vgaarb: invalid PCI address %x:%x\n",
bus, devfn);
@@ -993,7 +994,7 @@ static ssize_t vga_arb_write(struct file *file, const char
__user * buf,
}
vgadev = vgadev_find(pdev);
- pr_devel("vgaarb: vgadev %p\n", vgadev);
+ pr_debug("vgaarb: vgadev %p\n", vgadev);
if (vgadev == NULL) {
[Bug 28229] Radeon driver not detecting HDMI monitor correctly when using KMS
https://bugs.freedesktop.org/show_bug.cgi?id=28229 --- Comment #12 from Magnus Jensen 2010-05-24 16:38:28 PDT --- Created an attachment (id=35839) --> (https://bugs.freedesktop.org/attachment.cgi?id=35839) edid from "/sys/class/drm/card0-HDMI Type A-1/" This is the edid it sees when booting with Linux kernel 2.6.33.4. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 28229] Radeon driver not detecting HDMI monitor correctly when using KMS
https://bugs.freedesktop.org/show_bug.cgi?id=28229 --- Comment #11 from Christian K?nig 2010-05-24 16:26:09 PDT --- Invalid checksums on CEA extension is a problem I have found on a couple of A/V receivers + TV combinations. The A/V receivers usually try to update the audio infos and CEC physical address in the CEA extension, but sometimes fails to recalculate the checksum of the block. I would suggest to lower the error to a simple warning and try to use the infos in the extension block anyway. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[PATCH -next] nouveau: fix acpi_lid_open undefined
On Mon, May 24, 2010 at 06:53:51AM -0700, Randy Dunlap wrote: > On 05/24/10 05:56, Matthew Garrett wrote: > > Won't this result in a behavioural difference? The desirable outcome is > > It could, yes. > > > that that configuration be impossible, not for that configuration to > > build but be buggy. > > so nouveau should depend on (or select, if ACPI is enabled) ACPI_BUTTON? There's an argument that it doesn't need to depend on it, but if button is a module then nouveau has to be. Except the inverse isn't true. Kconfig is hard, let's weep gently. -- Matthew Garrett | mjg59 at srcf.ucam.org
[PATCH -next] nouveau: fix acpi_lid_open undefined
On Sun, May 23, 2010 at 05:00:40PM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > When CONFIG_ACPI_BUTTON=m (and probably when ACPI_BUTTON is not enabled) > and NOUVEAU is built-in (not as a loadable module): Won't this result in a behavioural difference? The desirable outcome is that that configuration be impossible, not for that configuration to build but be buggy. -- Matthew Garrett | mjg59 at srcf.ucam.org
[Bug 28217] Black screen and crash on r600 with radeon module not loaded
https://bugs.freedesktop.org/show_bug.cgi?id=28217 --- Comment #7 from Alex Deucher 2010-05-24 11:13:58 PDT --- Are you trying to use ums rather than kms? You need to disable kms if you want to use ums. (boot with radeon.modeset=0). If you want to use kms, the drm must be loaded before starting X. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 28217] Black screen and crash on r600 with radeon module not loaded
https://bugs.freedesktop.org/show_bug.cgi?id=28217 Gael Le Mignot changed: What|Removed |Added Attachment #35828|Xorg log with no manually |Xorg log with no manual description|loading of radeon module|loading of radeon module -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 28217] Black screen and crash on r600 with radeon module not loaded
https://bugs.freedesktop.org/show_bug.cgi?id=28217 Gael Le Mignot changed: What|Removed |Added Attachment #35829|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 28217] Black screen and crash on r600 with radeon module not loaded
https://bugs.freedesktop.org/show_bug.cgi?id=28217 Gael Le Mignot changed: What|Removed |Added Attachment #35828|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 28217] Black screen and crash on r600 with radeon module not loaded
https://bugs.freedesktop.org/show_bug.cgi?id=28217 Gael Le Mignot changed: What|Removed |Added Attachment #35830|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 28217] Black screen and crash on r600 with radeon module not loaded
https://bugs.freedesktop.org/show_bug.cgi?id=28217 --- Comment #4 from Gael Le Mignot 2010-05-24 10:57:17 PDT --- Created an attachment (id=35830) --> (https://bugs.freedesktop.org/attachment.cgi?id=35830) dmesg log with no manual loading of radeon module -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 28217] Black screen and crash on r600 with radeon module not loaded
https://bugs.freedesktop.org/show_bug.cgi?id=28217 --- Comment #2 from Gael Le Mignot 2010-05-24 10:56:23 PDT --- Created an attachment (id=35828) --> (https://bugs.freedesktop.org/attachment.cgi?id=35828) Xorg log with no manually loading of radeon module -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 26686] Some textures are distorted with libdrm 2.4.18 in GTAVC
https://bugs.freedesktop.org/show_bug.cgi?id=26686 --- Comment #9 from Chris Wilson 2010-05-24 10:44:27 PDT --- Ruslan, it would be invaluable if you could add an assert(ret == 0); and track down the source of the EINVAL. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 26686] Some textures are distorted with libdrm 2.4.18 in GTAVC
https://bugs.freedesktop.org/show_bug.cgi?id=26686 Chris Wilson changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #8 from Chris Wilson 2010-05-24 10:42:56 PDT --- commit fcf3e616eeeb289f96af1436d809f0a1a42bebb7 Author: Chris Wilson Date: Mon May 24 18:35:41 2010 +0100 intel: Don't change tiling mode unless the kernel reports success. Fixes: Bug 26686 - Some textures are distorted with libdrm 2.4.18 in GTAVC http://bugs.freedesktop.org/show_bug.cgi?id=26686 This bug continues to haunt me. The kernel SET_TILING ioctl is inconsistent in its return values when reporting an error. If one of its sanity checks fail, then the input values are left unchanged. If the kernel later fails to change the tiling mode, then the input values are modified to match the current tiling on the object. In short, userspace cannot trust the return values upon error and so we must assume that upon error our current tiling mode matches reality and not update. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 26686] Some textures are distorted with libdrm 2.4.18 in GTAVC
https://bugs.freedesktop.org/show_bug.cgi?id=26686 --- Comment #7 from Ruslan 2010-05-24 10:29:52 PDT --- Still present with libdrm 2.4.20. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 28229] Radeon driver not detecting HDMI monitor correctly when using KMS
https://bugs.freedesktop.org/show_bug.cgi?id=28229 --- Comment #10 from Magnus Jensen 2010-05-24 09:26:47 PDT --- sorry i meant to say 2.6.33.4 that's the stock kernel in slackware64-current -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 28229] Radeon driver not detecting HDMI monitor correctly when using KMS
https://bugs.freedesktop.org/show_bug.cgi?id=28229 --- Comment #9 from Alex Deucher 2010-05-24 08:26:51 PDT --- Should we add a quirk for this particular monitor or add some logic to use edids with faulty checksums? It would probably be better to attempt to use an edid than to not, at least for digital monitors. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 28229] Radeon driver not detecting HDMI monitor correctly when using KMS
https://bugs.freedesktop.org/show_bug.cgi?id=28229 --- Comment #8 from Magnus Jensen 2010-05-24 08:25:54 PDT --- so i guess it's not a bug then, but isn't there any way to circumvent the problem, other that flashing a new edid or buying a new tv? (b.t.w i managed to get correct screen resolution in X by using CustomEDID option in xorg.conf with an edid bin i grabbed using 2.6.33.3 kernel, but only if i load X before module, but then i still get no HDMI audio because xf86-video-ati doesn't get the modesetting) What i thought was strange was that it doesn't react this way on stock 2.6.33.3 kernel. On that kernel HDMI works beautifully with audio. i am pretty sure i compiled the kernel correctly. So i think it may be a regression (or rather progression since my EDID seems to really be broken) that causes trouble for me with the drm driver. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 28226] FPS drops to 1 on Disabling KMS while running Openarena
https://bugs.freedesktop.org/show_bug.cgi?id=28226 --- Comment #4 from Alex Deucher 2010-05-24 08:01:13 PDT --- Does openarena have the bloom option turned on? If so, performance will be slow with ums as that path requires hw accelerated tex(sub)image support which is only possible with kms. Also, please check glxinfo with ums to make sure 3D is working. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 28226] FPS drops to 1 on Disabling KMS while running Openarena
https://bugs.freedesktop.org/show_bug.cgi?id=28226 Alex Deucher changed: What|Removed |Added Attachment #35818|application/octet-stream|text/plain mime type|| Attachment #35818|0 |1 is patch|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[PATCH -next] nouveau: fix acpi_lid_open undefined
On 05/24/10 06:59, Matthew Garrett wrote: > On Mon, May 24, 2010 at 06:53:51AM -0700, Randy Dunlap wrote: >> On 05/24/10 05:56, Matthew Garrett wrote: >>> Won't this result in a behavioural difference? The desirable outcome is >> >> It could, yes. >> >>> that that configuration be impossible, not for that configuration to >>> build but be buggy. >> >> so nouveau should depend on (or select, if ACPI is enabled) ACPI_BUTTON? > > There's an argument that it doesn't need to depend on it, but if button > is a module then nouveau has to be. Except the inverse isn't true. > Kconfig is hard, let's weep gently. Maybe Dave can weep with us when he is back at work... -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
[PATCH -next] nouveau: fix acpi_lid_open undefined
On 05/24/10 05:56, Matthew Garrett wrote: > On Sun, May 23, 2010 at 05:00:40PM -0700, Randy Dunlap wrote: >> From: Randy Dunlap >> >> When CONFIG_ACPI_BUTTON=m (and probably when ACPI_BUTTON is not enabled) >> and NOUVEAU is built-in (not as a loadable module): > > Won't this result in a behavioural difference? The desirable outcome is It could, yes. > that that configuration be impossible, not for that configuration to > build but be buggy. so nouveau should depend on (or select, if ACPI is enabled) ACPI_BUTTON? -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
[Bug 28229] Radeon driver not detecting HDMI monitor correctly when using KMS
https://bugs.freedesktop.org/show_bug.cgi?id=28229 --- Comment #7 from ajax at nwnk dot net 2010-05-24 06:46:51 PDT --- Just to make it clear what's going on here: the CEA extension block really does have a broken checksum, although it looks correct otherwise. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 28229] Radeon driver not detecting HDMI monitor correctly when using KMS
https://bugs.freedesktop.org/show_bug.cgi?id=28229 Magnus Jensen changed: What|Removed |Added Version|XOrg CVS|unspecified --- Comment #6 from Magnus Jensen 2010-05-24 06:02:23 PDT --- I should add that i'm trying drm-radeon-testing from git repository and i have also tried compiling latest 2.6.34 git from kernel.org. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 28229] Radeon driver not detecting HDMI monitor correctly when using KMS
https://bugs.freedesktop.org/show_bug.cgi?id=28229 --- Comment #5 from Magnus Jensen 2010-05-24 05:01:56 PDT --- Created an attachment (id=35824) --> (https://bugs.freedesktop.org/attachment.cgi?id=35824) dmesg-boot -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 28229] Radeon driver not detecting HDMI monitor correctly when using KMS
https://bugs.freedesktop.org/show_bug.cgi?id=28229 Magnus Jensen changed: What|Removed |Added Attachment #35823|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 28229] Radeon driver not detecting HDMI monitor correctly when using KMS
https://bugs.freedesktop.org/show_bug.cgi?id=28229 Magnus Jensen changed: What|Removed |Added Attachment #35822|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 28229] Radeon driver not detecting HDMI monitor correctly when using KMS
https://bugs.freedesktop.org/show_bug.cgi?id=28229 --- Comment #4 from Magnus Jensen 2010-05-24 04:56:14 PDT --- Created an attachment (id=35823) --> (https://bugs.freedesktop.org/attachment.cgi?id=35823) dmesg-current -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 28229] Radeon driver not detecting HDMI monitor correctly when using KMS
https://bugs.freedesktop.org/show_bug.cgi?id=28229 --- Comment #3 from Magnus Jensen 2010-05-24 04:54:39 PDT --- Created an attachment (id=35822) --> (https://bugs.freedesktop.org/attachment.cgi?id=35822) Xorg.0.log - with KMS -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 28229] Radeon driver not detecting HDMI monitor correctly when using KMS
https://bugs.freedesktop.org/show_bug.cgi?id=28229 Magnus Jensen changed: What|Removed |Added Attachment #35821|Xorg.0.log |Xorg.0.log-with UMS description|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 28229] Radeon driver not detecting HDMI monitor correctly when using KMS
https://bugs.freedesktop.org/show_bug.cgi?id=28229 --- Comment #1 from Magnus Jensen 2010-05-24 04:47:24 PDT --- Created an attachment (id=35821) --> (https://bugs.freedesktop.org/attachment.cgi?id=35821) Xorg.0.log -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 28229] New: Radeon driver not detecting HDMI monitor correctly when using KMS
https://bugs.freedesktop.org/show_bug.cgi?id=28229 Summary: Radeon driver not detecting HDMI monitor correctly when using KMS Product: DRI Version: XOrg CVS Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: major Priority: medium Component: DRM/Radeon AssignedTo: dri-devel at lists.freedesktop.org ReportedBy: magnus at jensenligan.se -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 28226] FPS drops to 1 on Disabling KMS while running Openarena
https://bugs.freedesktop.org/show_bug.cgi?id=28226 --- Comment #3 from samit vats 2010-05-24 04:08:48 PDT --- Created an attachment (id=35820) --> (https://bugs.freedesktop.org/attachment.cgi?id=35820) glxinfo -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 28226] FPS drops to 1 on Disabling KMS while running Openarena
https://bugs.freedesktop.org/show_bug.cgi?id=28226 --- Comment #2 from samit vats 2010-05-24 04:08:00 PDT --- Created an attachment (id=35819) --> (https://bugs.freedesktop.org/attachment.cgi?id=35819) Xorg.0.enable-kms.log -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 28226] FPS drops to 1 on Disabling KMS while running Openarena
https://bugs.freedesktop.org/show_bug.cgi?id=28226 --- Comment #1 from samit vats 2010-05-24 04:06:09 PDT --- Created an attachment (id=35818) --> (https://bugs.freedesktop.org/attachment.cgi?id=35818) Xorg.log-kms-disable -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 28226] New: FPS drops to 1 on Disabling KMS while running Openarena
https://bugs.freedesktop.org/show_bug.cgi?id=28226 Summary: FPS drops to 1 on Disabling KMS while running Openarena Product: Mesa Version: git Platform: x86 (IA32) OS/Version: All Status: NEW Severity: critical Priority: medium Component: Drivers/DRI/R600 AssignedTo: dri-devel at lists.freedesktop.org ReportedBy: hysvats at gmail.com KMS Driver Stack details : = 1)Kernel-2.6.32-21-generic-pae 2)Libdrm-2.4.19 3)Mesa-7.8-rc2 4)Xorg-server-1.7.4 5)ddx: xf86-video-ati-6.13.0 System Environment : === O.S. - Ubuntu-10.04(32bit) Asic - M97 CPU - Intel(R) Pentium(R)@ 3.60 GHz Steps to Reproduce: === A)Running with KMS enabled by default 1) Install Phoronix-test-suite from http://www.phoronix-test-suite.com/releases/repo/pts.debian/files/phoronix-test-suite_2.4.1_all.deb 2) Install Openarena phoronix-test-suite install openarena 3) Run the game with 1280x1024 or any other resolution phoronix-test-suite run openarena FPS Observed is 48.60 B)Disable KMS,reboot and run the test again FPS observed is 1 FPS -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 28223] New: Screen Blanks on launching racing game Vdrift
https://bugs.freedesktop.org/show_bug.cgi?id=28223 Summary: Screen Blanks on launching racing game Vdrift Product: Mesa Version: git Platform: x86 (IA32) OS/Version: other Status: NEW Severity: major Priority: medium Component: Drivers/DRI/R600 AssignedTo: dri-devel@lists.freedesktop.org ReportedBy: hysv...@gmail.com Created an attachment (id=35808) -- (https://bugs.freedesktop.org/attachment.cgi?id=35808) Xorg.log KMS Driver Stack details : = 1)Kernel-2.6.32-21-generic-pae 2)Libdrm-2.4.19 3)Mesa-7.8-rc2 4)Xorg-server-1.7.4 5)ddx: xf86-video-ati-6.13.0 System Environment : === O.S. - Ubuntu-10.04(32bit) Asic - M97 CPU - Intel(R) Core(TM)@ 1.86GHz Steps to Reproduce: === 1) Install Phoronix-test-suite from http://www.phoronix-test-suite.com/releases/repo/pts.debian/files/phoronix-test-suite_2.4.1_all.deb 2) Install vdrift racing game phoronix-test-suite install vdrift 3) Run the game with 1280x1024 or any other resolution phoronix-test-suite run vdrift Observation : = Screen Blanks and intermittent corruption observed on the Desktop -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 28223] Screen Blanks on launching racing game Vdrift
https://bugs.freedesktop.org/show_bug.cgi?id=28223 --- Comment #1 from samit vats hysv...@gmail.com 2010-05-23 23:48:25 PDT --- Created an attachment (id=35809) -- (https://bugs.freedesktop.org/attachment.cgi?id=35809) glxinfo -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH -next] nouveau: fix acpi_lid_open undefined
On Sun, 2010-05-23 at 17:00 -0700, Randy Dunlap wrote:
From: Randy Dunlap randy.dun...@oracle.com
When CONFIG_ACPI_BUTTON=m (and probably when ACPI_BUTTON is not enabled)
and NOUVEAU is built-in (not as a loadable module):
nouveau_connector.c:(.text+0xe17ce): undefined reference to `acpi_lid_open'
Signed-off-by: Randy Dunlap randy.dun...@oracle.com
Acked-by: Ben Skeggs bske...@redhat.com
Cc: David Airlie airl...@linux.ie
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/nouveau/nouveau_connector.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-next-20100522.orig/drivers/gpu/drm/nouveau/nouveau_connector.c
+++ linux-next-20100522/drivers/gpu/drm/nouveau/nouveau_connector.c
@@ -241,7 +241,8 @@ nouveau_connector_detect(struct drm_conn
if (nv_encoder nv_connector-native_mode) {
unsigned status = connector_status_connected;
-#ifdef CONFIG_ACPI
+#if defined(CONFIG_ACPI_BUTTON) || \
+ (defined(CONFIG_ACPI_BUTTON_MODULE) defined(MODULE))
if (!nouveau_ignorelid !acpi_lid_open())
status = connector_status_unknown;
#endif
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 28226] FPS drops to 1 on Disabling KMS while running Openarena
https://bugs.freedesktop.org/show_bug.cgi?id=28226 --- Comment #2 from samit vats hysv...@gmail.com 2010-05-24 04:08:00 PDT --- Created an attachment (id=35819) -- (https://bugs.freedesktop.org/attachment.cgi?id=35819) Xorg.0.enable-kms.log -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 28229] Radeon driver not detecting HDMI monitor correctly when using KMS
https://bugs.freedesktop.org/show_bug.cgi?id=28229 --- Comment #1 from Magnus Jensen mag...@jensenligan.se 2010-05-24 04:47:24 PDT --- Created an attachment (id=35821) -- (https://bugs.freedesktop.org/attachment.cgi?id=35821) Xorg.0.log -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 28229] Radeon driver not detecting HDMI monitor correctly when using KMS
https://bugs.freedesktop.org/show_bug.cgi?id=28229 Magnus Jensen mag...@jensenligan.se changed: What|Removed |Added Attachment #35821|Xorg.0.log |Xorg.0.log-with UMS description|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 28229] Radeon driver not detecting HDMI monitor correctly when using KMS
https://bugs.freedesktop.org/show_bug.cgi?id=28229 --- Comment #2 from Magnus Jensen mag...@jensenligan.se 2010-05-24 04:50:17 PDT --- When loading radeon module with modeset=1 the dmesg gets flooded with: [drm:drm_edid_block_valid] *ERROR* EDID checksum is invalid, remainder is 255 [drm:drm_edid_block_valid] *ERROR* Raw EDID: 302 03 20 f1 4c 05 04 03 14 93 12 01 02 11 15 16 .. .L... 31e 23 09 07 07 83 01 00 00 66 03 0c 00 10 00 80 .#...f.. 300 1d 00 bc 52 d0 1e 20 b8 28 55 40 bd fa 10 00 R.. .(u...@ 300 1e 01 1d 80 18 71 1c 16 20 58 2c 25 00 bd fa ..q.. X,%... 310 00 00 9e 8c 0a d0 8a 20 e0 2d 10 10 3e 96 00 .- 3bd fa 10 00 00 18 01 1d 80 d0 72 1c 16 20 10 2c ..r.. ., 325 80 bd fa 10 00 00 9e 01 1d 00 bc 52 d0 1e 20 %...R.. 3b8 28 55 40 bd fa 10 00 00 1e 00 00 00 00 00 a2 .(u...@ the drmradeonfb also sets a lower resolution than normal (1024x768) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 28229] Radeon driver not detecting HDMI monitor correctly when using KMS
https://bugs.freedesktop.org/show_bug.cgi?id=28229 --- Comment #3 from Magnus Jensen mag...@jensenligan.se 2010-05-24 04:54:39 PDT --- Created an attachment (id=35822) -- (https://bugs.freedesktop.org/attachment.cgi?id=35822) Xorg.0.log - with KMS -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 28229] Radeon driver not detecting HDMI monitor correctly when using KMS
https://bugs.freedesktop.org/show_bug.cgi?id=28229 --- Comment #4 from Magnus Jensen mag...@jensenligan.se 2010-05-24 04:56:14 PDT --- Created an attachment (id=35823) -- (https://bugs.freedesktop.org/attachment.cgi?id=35823) dmesg-current -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 28229] Radeon driver not detecting HDMI monitor correctly when using KMS
https://bugs.freedesktop.org/show_bug.cgi?id=28229 Magnus Jensen mag...@jensenligan.se changed: What|Removed |Added Attachment #35822|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 28229] Radeon driver not detecting HDMI monitor correctly when using KMS
https://bugs.freedesktop.org/show_bug.cgi?id=28229 Magnus Jensen mag...@jensenligan.se changed: What|Removed |Added Attachment #35823|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 28229] Radeon driver not detecting HDMI monitor correctly when using KMS
https://bugs.freedesktop.org/show_bug.cgi?id=28229 --- Comment #5 from Magnus Jensen mag...@jensenligan.se 2010-05-24 05:01:56 PDT --- Created an attachment (id=35824) -- (https://bugs.freedesktop.org/attachment.cgi?id=35824) dmesg-boot -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 28229] Radeon driver not detecting HDMI monitor correctly when using KMS
https://bugs.freedesktop.org/show_bug.cgi?id=28229 Magnus Jensen mag...@jensenligan.se changed: What|Removed |Added Version|XOrg CVS|unspecified --- Comment #6 from Magnus Jensen mag...@jensenligan.se 2010-05-24 06:02:23 PDT --- I should add that i'm trying drm-radeon-testing from git repository and i have also tried compiling latest 2.6.34 git from kernel.org. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH -next] nouveau: fix acpi_lid_open undefined
On 05/24/10 06:59, Matthew Garrett wrote: On Mon, May 24, 2010 at 06:53:51AM -0700, Randy Dunlap wrote: On 05/24/10 05:56, Matthew Garrett wrote: Won't this result in a behavioural difference? The desirable outcome is It could, yes. that that configuration be impossible, not for that configuration to build but be buggy. so nouveau should depend on (or select, if ACPI is enabled) ACPI_BUTTON? There's an argument that it doesn't need to depend on it, but if button is a module then nouveau has to be. Except the inverse isn't true. Kconfig is hard, let's weep gently. Maybe Dave can weep with us when he is back at work... -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 28226] FPS drops to 1 on Disabling KMS while running Openarena
https://bugs.freedesktop.org/show_bug.cgi?id=28226 --- Comment #4 from Alex Deucher ag...@yahoo.com 2010-05-24 08:01:13 PDT --- Does openarena have the bloom option turned on? If so, performance will be slow with ums as that path requires hw accelerated tex(sub)image support which is only possible with kms. Also, please check glxinfo with ums to make sure 3D is working. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 26686] Some textures are distorted with libdrm 2.4.18 in GTAVCGTA3
https://bugs.freedesktop.org/show_bug.cgi?id=26686 --- Comment #7 from Ruslan b7.10110...@gmail.com 2010-05-24 10:29:52 PDT --- Still present with libdrm 2.4.20. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 26686] Some textures are distorted with libdrm 2.4.18 in GTAVCGTA3
https://bugs.freedesktop.org/show_bug.cgi?id=26686 Chris Wilson ch...@chris-wilson.co.uk changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #8 from Chris Wilson ch...@chris-wilson.co.uk 2010-05-24 10:42:56 PDT --- commit fcf3e616eeeb289f96af1436d809f0a1a42bebb7 Author: Chris Wilson ch...@chris-wilson.co.uk Date: Mon May 24 18:35:41 2010 +0100 intel: Don't change tiling mode unless the kernel reports success. Fixes: Bug 26686 - Some textures are distorted with libdrm 2.4.18 in GTAVCGTA3 http://bugs.freedesktop.org/show_bug.cgi?id=26686 This bug continues to haunt me. The kernel SET_TILING ioctl is inconsistent in its return values when reporting an error. If one of its sanity checks fail, then the input values are left unchanged. If the kernel later fails to change the tiling mode, then the input values are modified to match the current tiling on the object. In short, userspace cannot trust the return values upon error and so we must assume that upon error our current tiling mode matches reality and not update. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 28217] Black screen and crash on r600 with radeon module not loaded
https://bugs.freedesktop.org/show_bug.cgi?id=28217 --- Comment #2 from Gael Le Mignot kilo...@freesurf.fr 2010-05-24 10:56:23 PDT --- Created an attachment (id=35828) -- (https://bugs.freedesktop.org/attachment.cgi?id=35828) Xorg log with no manually loading of radeon module -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 28217] Black screen and crash on r600 with radeon module not loaded
https://bugs.freedesktop.org/show_bug.cgi?id=28217 --- Comment #5 from Gael Le Mignot kilo...@freesurf.fr 2010-05-24 10:57:41 PDT --- Created an attachment (id=35831) -- (https://bugs.freedesktop.org/attachment.cgi?id=35831) dmesg log with manual loading of radeon module -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 28217] Black screen and crash on r600 with radeon module not loaded
https://bugs.freedesktop.org/show_bug.cgi?id=28217 Gael Le Mignot kilo...@freesurf.fr changed: What|Removed |Added Attachment #35830|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 28217] Black screen and crash on r600 with radeon module not loaded
https://bugs.freedesktop.org/show_bug.cgi?id=28217 Gael Le Mignot kilo...@freesurf.fr changed: What|Removed |Added Attachment #35828|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 28217] Black screen and crash on r600 with radeon module not loaded
https://bugs.freedesktop.org/show_bug.cgi?id=28217 Gael Le Mignot kilo...@freesurf.fr changed: What|Removed |Added Attachment #35829|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH -next] nouveau: fix acpi_lid_open undefined
On Mon, May 24, 2010 at 06:53:51AM -0700, Randy Dunlap wrote: On 05/24/10 05:56, Matthew Garrett wrote: Won't this result in a behavioural difference? The desirable outcome is It could, yes. that that configuration be impossible, not for that configuration to build but be buggy. so nouveau should depend on (or select, if ACPI is enabled) ACPI_BUTTON? There's an argument that it doesn't need to depend on it, but if button is a module then nouveau has to be. Except the inverse isn't true. Kconfig is hard, let's weep gently. -- Matthew Garrett | mj...@srcf.ucam.org ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 1/3] vgaarb: convert pr_devel() to pr_debug()
We want to be able to use CONFIG_DYNAMIC_DEBUG in arbiter code, switch
the few existing pr_devel() calls to pr_debug().
Also, add one more debug information regarding decoding count.
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com
---
drivers/gpu/vga/vgaarb.c | 35 ++-
1 files changed, 18 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c
index 441e38c..290b0cc 100644
--- a/drivers/gpu/vga/vgaarb.c
+++ b/drivers/gpu/vga/vgaarb.c
@@ -155,8 +155,8 @@ static struct vga_device *__vga_tryget(struct vga_device
*vgadev,
(vgadev-decodes VGA_RSRC_LEGACY_MEM))
rsrc |= VGA_RSRC_LEGACY_MEM;
- pr_devel(%s: %d\n, __func__, rsrc);
- pr_devel(%s: owns: %d\n, __func__, vgadev-owns);
+ pr_debug(%s: %d\n, __func__, rsrc);
+ pr_debug(%s: owns: %d\n, __func__, vgadev-owns);
/* Check what resources we need to acquire */
wants = rsrc ~vgadev-owns;
@@ -268,7 +268,7 @@ static void __vga_put(struct vga_device *vgadev, unsigned
int rsrc)
{
unsigned int old_locks = vgadev-locks;
- pr_devel(%s\n, __func__);
+ pr_debug(%s\n, __func__);
/* Update our counters, and account for equivalent legacy resources
* if we decode them
@@ -575,6 +575,7 @@ static inline void vga_update_device_decodes(struct
vga_device *vgadev,
else
vga_decode_count--;
}
+ pr_debug(vgaarb: decoding count now is: %d\n, vga_decode_count);
}
void __vga_set_legacy_decoding(struct pci_dev *pdev, unsigned int decodes,
bool userspace)
@@ -831,7 +832,7 @@ static ssize_t vga_arb_write(struct file *file, const char
__user * buf,
curr_pos += 5;
remaining -= 5;
- pr_devel(client 0x%p called 'lock'\n, priv);
+ pr_debug(client 0x%p called 'lock'\n, priv);
if (!vga_str_to_iostate(curr_pos, remaining, io_state)) {
ret_val = -EPROTO;
@@ -867,7 +868,7 @@ static ssize_t vga_arb_write(struct file *file, const char
__user * buf,
curr_pos += 7;
remaining -= 7;
- pr_devel(client 0x%p called 'unlock'\n, priv);
+ pr_debug(client 0x%p called 'unlock'\n, priv);
if (strncmp(curr_pos, all, 3) == 0)
io_state = VGA_RSRC_LEGACY_IO | VGA_RSRC_LEGACY_MEM;
@@ -917,7 +918,7 @@ static ssize_t vga_arb_write(struct file *file, const char
__user * buf,
curr_pos += 8;
remaining -= 8;
- pr_devel(client 0x%p called 'trylock'\n, priv);
+ pr_debug(client 0x%p called 'trylock'\n, priv);
if (!vga_str_to_iostate(curr_pos, remaining, io_state)) {
ret_val = -EPROTO;
@@ -961,7 +962,7 @@ static ssize_t vga_arb_write(struct file *file, const char
__user * buf,
curr_pos += 7;
remaining -= 7;
- pr_devel(client 0x%p called 'target'\n, priv);
+ pr_debug(client 0x%p called 'target'\n, priv);
/* if target is default */
if (!strncmp(curr_pos, default, 7))
pdev = pci_dev_get(vga_default_device());
@@ -971,11 +972,11 @@ static ssize_t vga_arb_write(struct file *file, const
char __user * buf,
ret_val = -EPROTO;
goto done;
}
- pr_devel(vgaarb: %s == %x:%x:%x.%x\n, curr_pos,
+ pr_debug(vgaarb: %s == %x:%x:%x.%x\n, curr_pos,
domain, bus, PCI_SLOT(devfn), PCI_FUNC(devfn));
pbus = pci_find_bus(domain, bus);
- pr_devel(vgaarb: pbus %p\n, pbus);
+ pr_debug(vgaarb: pbus %p\n, pbus);
if (pbus == NULL) {
pr_err(vgaarb: invalid PCI domain and/or bus
address %x:%x\n,
domain, bus);
@@ -983,7 +984,7 @@ static ssize_t vga_arb_write(struct file *file, const char
__user * buf,
goto done;
}
pdev = pci_get_slot(pbus, devfn);
- pr_devel(vgaarb: pdev %p\n, pdev);
+ pr_debug(vgaarb: pdev %p\n, pdev);
if (!pdev) {
pr_err(vgaarb: invalid PCI address %x:%x\n,
bus, devfn);
@@ -993,7 +994,7 @@ static ssize_t vga_arb_write(struct file *file, const char
__user * buf,
}
vgadev = vgadev_find(pdev);
- pr_devel(vgaarb: vgadev %p\n, vgadev);
+ pr_debug(vgaarb: vgadev %p\n, vgadev);
if (vgadev == NULL) {
pr_err(vgaarb: this pci
[PATCH resent twice 2/3] vgaarb: use MIT license
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Cc: Henry Zhao henry.z...@sun.com --- Jesse and Dave, that was send two times already and no one said anything. Please, pull it. Oracle's Henry Zhao is already employing it in Solaris and, after all authors agreed, we haven't changed yet the license. drivers/gpu/vga/vgaarb.c | 26 +++--- include/linux/vgaarb.h | 21 + 2 files changed, 44 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c index 290b0cc..b87569e 100644 --- a/drivers/gpu/vga/vgaarb.c +++ b/drivers/gpu/vga/vgaarb.c @@ -1,12 +1,32 @@ /* - * vgaarb.c + * vgaarb.c: Implements the VGA arbitration. For details refer to + * Documentation/vgaarbiter.txt + * * * (C) Copyright 2005 Benjamin Herrenschmidt b...@kernel.crashing.org * (C) Copyright 2007 Paulo R. Zanoni przan...@gmail.com * (C) Copyright 2007, 2009 Tiago Vignatti vigna...@freedesktop.org * - * Implements the VGA arbitration. For details refer to - * Documentation/vgaarbiter.txt + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the Software), + * to deal in the Software without restriction, including without limitation + * the rights to use, copy, modify, merge, publish, distribute, sublicense, + * and/or sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice (including the next + * paragraph) shall be included in all copies or substantial portions of the + * Software. + * + * THE SOFTWARE IS PROVIDED AS IS, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS + * IN THE SOFTWARE. + * */ #include linux/module.h diff --git a/include/linux/vgaarb.h b/include/linux/vgaarb.h index 2dfaa29..c9a9759 100644 --- a/include/linux/vgaarb.h +++ b/include/linux/vgaarb.h @@ -5,6 +5,27 @@ * (C) Copyright 2005 Benjamin Herrenschmidt b...@kernel.crashing.org * (C) Copyright 2007 Paulo R. Zanoni przan...@gmail.com * (C) Copyright 2007, 2009 Tiago Vignatti vigna...@freedesktop.org + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the Software), + * to deal in the Software without restriction, including without limitation + * the rights to use, copy, modify, merge, publish, distribute, sublicense, + * and/or sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice (including the next + * paragraph) shall be included in all copies or substantial portions of the + * Software. + * + * THE SOFTWARE IS PROVIDED AS IS, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS + * IN THE SOFTWARE. + * */ #ifndef LINUX_VGA_H -- 1.6.0.4 ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH -next] nouveau: fix acpi_lid_open undefined
Hi. On 25/05/10 08:47, Dave Airlie wrote: On Mon, 2010-05-24 at 07:17 -0700, Randy Dunlap wrote: On 05/24/10 06:59, Matthew Garrett wrote: On Mon, May 24, 2010 at 06:53:51AM -0700, Randy Dunlap wrote: On 05/24/10 05:56, Matthew Garrett wrote: Won't this result in a behavioural difference? The desirable outcome is It could, yes. that that configuration be impossible, not for that configuration to build but be buggy. so nouveau should depend on (or select, if ACPI is enabled) ACPI_BUTTON? There's an argument that it doesn't need to depend on it, but if button is a module then nouveau has to be. Except the inverse isn't true. Kconfig is hard, let's weep gently. Maybe Dave can weep with us when he is back at work... Yeah I've had problems like this a few times lately with the drm, I'm torn between just adding select all over the place, or assuming someone sane is configuring the kernel. I'm sort of erring on the someone sane is configuring the kernel just because Linus's objects to default y things seems to point at that we can't really give pointers to the people who haven't done it before. So I'm quite happy to leave it having different behaviour depending on the configuration and simply ignoring bug reports from incompetents. 'scuse me for butting in, but would you at least consider adding something to the help for the Nouveau and/or ACPI button options? You might have a sane person configuring the kernel, but that doesn't mean a dependency like this would necessarily be obvious to them. Personally, I'd argue for the select. Regards, Nigel ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
