[Bug 30651] r600g: gl output in mplayer have no colors if used with a fragment program with additional lookup and bicubic B-spline filtering

2010-10-22 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=30651

--- Comment #3 from Sergey Kondakov  2010-10-22 
18:49:34 PDT ---
tested commit 469907d59738ad32c7a3b95072897432f1e81a0f with kernel 2.6.36 and
"ColorTiling"="on".
same thing :(

tested without 'lscale=1,cscale=1' and it makes no difference. setting 'yuv=4'
triggers bug alright.
but specifying 'yuv=1' and '5' (register combiners/GL_NV_register_combiners and
GL_ATI_fragment_shader) also gives colorless picture and it's much darker.

i will use method '6' for now with hope that it's not really "Extremely slow
(software emulation) on some (all?) ATI cards since it uses a texture with
border pixels" as mplayer's manual says.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[PATCH RESEND] drm: include missing types header to drm_mode.h

2010-10-22 Thread Randy Dunlap 
On Fri, 22 Oct 2010 16:55:17 -0700 Andrew Morton wrote:

> On Fri, 22 Oct 2010 10:13:19 -0300
> Davidlohr Bueso  wrote:
> 
> > drm: include missing types header to drm_mode.h
> > 
> > Signed-off-by: Davidlohr Bueso 
> > ---
> >  include/drm/drm_mode.h |2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h
> > index 0fc7397..eddd7f4 100644
> > --- a/include/drm/drm_mode.h
> > +++ b/include/drm/drm_mode.h
> > @@ -24,6 +24,8 @@
> >   * IN THE SOFTWARE.
> >   */
> >  
> > +#include 
> > +
> >  #ifndef _DRM_MODE_H
> >  #define _DRM_MODE_H
> >  
> 
> Does this fix a build error?  If so, please send along the compiler
> error output.


Every build that has CONFIG_HEADERS_CHECK=y reports the following:

linux-next-20101022/X64/usr/include/drm/drm_mode.h:85: found __[us]{8,16,32,64} 
type without #include 
linux-next-20101022/X64/usr/include/drm/i915_drm.h:120: found 
__[us]{8,16,32,64} type without #include 
linux-next-20101022/X64/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64} 
type without #include 
linux-next-20101022/X64/usr/include/drm/radeon_drm.h:758: found 
__[us]{8,16,32,64} type without #include 
linux-next-20101022/X64/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64} 
type without #include 
linux-next-20101022/X64/usr/include/scsi/scsi_netlink.h:108: found 
__[us]{8,16,32,64} type without #include 
linux-next-20101022/X64/usr/include/linux/resource.h:49: found 
__[us]{8,16,32,64} type without #include 


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

[PATCH RESEND] drm: include missing types header to drm_mode.h

2010-10-22 Thread Andrew Morton 
On Fri, 22 Oct 2010 10:13:19 -0300
Davidlohr Bueso  wrote:

> drm: include missing types header to drm_mode.h
> 
> Signed-off-by: Davidlohr Bueso 
> ---
>  include/drm/drm_mode.h |2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h
> index 0fc7397..eddd7f4 100644
> --- a/include/drm/drm_mode.h
> +++ b/include/drm/drm_mode.h
> @@ -24,6 +24,8 @@
>   * IN THE SOFTWARE.
>   */
>  
> +#include 
> +
>  #ifndef _DRM_MODE_H
>  #define _DRM_MODE_H
>  

Does this fix a build error?  If so, please send along the compiler
error output.

[Bug 28294] [r300g] Unigine Sanctuary v2.2: black glitches

2010-10-22 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=28294

--- Comment #40 from Tom Stellard  2010-10-22 16:30:09 
PDT ---
Does running with RADEON_DEBUG=noopt fix this bug?
If it does, can you post the output of RADEON_DEBUG=fp,vp,pstat?
If it doesn't, can you post the output of RADEON_DEBUG=noopt,fp,vp,pstat?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[PATCH 0/9] Typo fixes of faild to failed

2010-10-22 Thread Mike Frysinger 
On Fri, Oct 22, 2010 at 01:17, Joe Perches wrote:
> ?drivers/ata/pata_bf54x.c ? ? ? ? ? | ? ?2 +-
> ?drivers/video/bf54x-lq043fb.c ? ? ?| ? ?6 +++---
> ?drivers/video/bfin-t350mcqb-fb.c ? | ? ?2 +-

Acked-by: Mike Frysinger 
-mike

[Bug 31052] drm radeon modesetting enabled hits Linux kernel BUG null pointer

2010-10-22 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=31052

--- Comment #1 from Chris  2010-10-22 15:50:05 PDT ---
Created an attachment (id=39640)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=39640)
The bios of the AVGA3000 (radeon 2600 RV630) card

This may help, this is the bios of this card which is modified to hold
modelines that are custom made for an arcade monitor.  I think there's more
modified though than just that, since the radeon drm driver in KMS hits a null
pointer and crashes.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[PATCH 2/2] drm/kms: Fix missing locking in some fb helpers.

2010-10-22 Thread Francisco Jerez 
Signed-off-by: Francisco Jerez 
---
 drivers/gpu/drm/drm_fb_helper.c |   14 --
 1 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 6a5e403..4d608b7 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -1449,6 +1449,8 @@ bool drm_fb_helper_initial_config(struct drm_fb_helper 
*fb_helper, int bpp_sel)
struct drm_device *dev = fb_helper->dev;
int count = 0;

+   mutex_lock(>mode_config.mutex);
+
/* disable all the possible outputs/crtcs before entering KMS mode */
drm_helper_disable_unused_functions(fb_helper->dev);

@@ -1465,19 +1467,23 @@ bool drm_fb_helper_initial_config(struct drm_fb_helper 
*fb_helper, int bpp_sel)
}
drm_setup_crtcs(fb_helper);

+   mutex_unlock(>mode_config.mutex);
+
return drm_fb_helper_single_fb_probe(fb_helper, bpp_sel);
 }
 EXPORT_SYMBOL(drm_fb_helper_initial_config);

 bool drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper)
 {
+   struct drm_device *dev = fb_helper->dev;
int count = 0;
u32 max_width, max_height, bpp_sel;
bool bound = false, crtcs_bound = false;
struct drm_crtc *crtc;

+   mutex_lock(>mode_config.mutex);
if (!fb_helper->fb)
-   return false;
+   goto fail;

list_for_each_entry(crtc, _helper->dev->mode_config.crtc_list, head) 
{
if (crtc->fb)
@@ -1488,7 +1494,7 @@ bool drm_fb_helper_hotplug_event(struct drm_fb_helper 
*fb_helper)

if (!bound && crtcs_bound) {
fb_helper->delayed_hotplug = true;
-   return false;
+   goto fail;
}
DRM_DEBUG_KMS("\n");

@@ -1500,7 +1506,11 @@ bool drm_fb_helper_hotplug_event(struct drm_fb_helper 
*fb_helper)
max_height);
drm_setup_crtcs(fb_helper);

+   mutex_unlock(>mode_config.mutex);
return drm_fb_helper_single_fb_probe(fb_helper, bpp_sel);
+fail:
+   mutex_unlock(>mode_config.mutex);
+   return false;
 }
 EXPORT_SYMBOL(drm_fb_helper_hotplug_event);

-- 
1.6.4.4

[PATCH 1/2] drm/kms: Lock mode_config.mutex consistently from the sysfs handling code.

2010-10-22 Thread Francisco Jerez 
Among other potential issues, this fixes a race between output polling
and status_show() that could cause a load detection false positive
with the nouveau driver.

Signed-off-by: Francisco Jerez 
---
 drivers/gpu/drm/drm_sysfs.c |   71 ---
 1 files changed, 46 insertions(+), 25 deletions(-)

diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c
index 85da4c4..25a9d9e 100644
--- a/drivers/gpu/drm/drm_sysfs.c
+++ b/drivers/gpu/drm/drm_sysfs.c
@@ -157,9 +157,13 @@ static ssize_t status_show(struct device *device,
   char *buf)
 {
struct drm_connector *connector = to_drm_connector(device);
+   struct drm_device *dev = connector->dev;
enum drm_connector_status status;

+   mutex_lock(>mode_config.mutex);
status = connector->funcs->detect(connector, true);
+   mutex_unlock(>mode_config.mutex);
+
return snprintf(buf, PAGE_SIZE, "%s\n",
drm_get_connector_status_name(status));
 }
@@ -173,9 +177,11 @@ static ssize_t dpms_show(struct device *device,
uint64_t dpms_status;
int ret;

+   mutex_lock(>mode_config.mutex);
ret = drm_connector_property_get_value(connector,
dev->mode_config.dpms_property,
_status);
+   mutex_unlock(>mode_config.mutex);
if (ret)
return 0;

@@ -199,25 +205,27 @@ static ssize_t edid_show(struct file *filp, struct 
kobject *kobj,
 {
struct device *connector_dev = container_of(kobj, struct device, kobj);
struct drm_connector *connector = to_drm_connector(connector_dev);
+   struct drm_device *dev = connector->dev;
unsigned char *edid;
-   size_t size;
+   size_t size, n = 0;

+   mutex_lock(>mode_config.mutex);
if (!connector->edid_blob_ptr)
-   return 0;
+   goto out;

edid = connector->edid_blob_ptr->data;
size = connector->edid_blob_ptr->length;
if (!edid)
-   return 0;
+   goto out;

if (off >= size)
-   return 0;
-
-   if (off + count > size)
-   count = size - off;
-   memcpy(buf, edid + off, count);
+   goto out;

-   return count;
+   n = min(count, size - (size_t)off);
+   memcpy(buf, edid + off, n);
+out:
+   mutex_unlock(>mode_config.mutex);
+   return n;
 }

 static ssize_t modes_show(struct device *device,
@@ -225,13 +233,16 @@ static ssize_t modes_show(struct device *device,
   char *buf)
 {
struct drm_connector *connector = to_drm_connector(device);
+   struct drm_device *dev = connector->dev;
struct drm_display_mode *mode;
int written = 0;

+   mutex_lock(>mode_config.mutex);
list_for_each_entry(mode, >modes, head) {
written += snprintf(buf + written, PAGE_SIZE - written, "%s\n",
mode->name);
}
+   mutex_unlock(>mode_config.mutex);

return written;
 }
@@ -245,7 +256,9 @@ static ssize_t subconnector_show(struct device *device,
struct drm_property *prop = NULL;
uint64_t subconnector;
int is_tv = 0;
-   int ret;
+   int ret = 0;
+
+   mutex_lock(>mode_config.mutex);

switch (connector->connector_type) {
case DRM_MODE_CONNECTOR_DVII:
@@ -260,21 +273,24 @@ static ssize_t subconnector_show(struct device *device,
break;
default:
DRM_ERROR("Wrong connector type for this property\n");
-   return 0;
+   goto out;
}

if (!prop) {
DRM_ERROR("Unable to find subconnector property\n");
-   return 0;
+   goto out;
}

ret = drm_connector_property_get_value(connector, prop, );
if (ret)
-   return 0;
+   goto out;

-   return snprintf(buf, PAGE_SIZE, "%s", is_tv ?
-   drm_get_tv_subconnector_name((int)subconnector) :
-   drm_get_dvi_i_subconnector_name((int)subconnector));
+   ret = snprintf(buf, PAGE_SIZE, "%s", is_tv ?
+  drm_get_tv_subconnector_name((int)subconnector) :
+  drm_get_dvi_i_subconnector_name((int)subconnector));
+out:
+   mutex_unlock(>mode_config.mutex);
+   return ret;
 }

 static ssize_t select_subconnector_show(struct device *device,
@@ -286,7 +302,9 @@ static ssize_t select_subconnector_show(struct device 
*device,
struct drm_property *prop = NULL;
uint64_t subconnector;
int is_tv = 0;
-   int ret;
+   int ret = 0;
+
+   mutex_lock(>mode_config.mutex);

switch (connector->connector_type) {
case DRM_MODE_CONNECTOR_DVII:
@@ -301,21 +319,24 @@ static

[067/103] drm/radeon/kms: fix possible sigbus in evergreen accel code

2010-10-22 Thread Greg KH 
2.6.35-stable review patch.  If anyone has any objections, please let us know.

--

From: Alex Deucher 

Not upstream in Linus's tree as it was fixed by a much more intrusive
patch in a different manner, commit c919b371cb734f42b11


2.6.35 and 2.6.36 do not contain blit support for evergreen
asics so if they use unmappable vram, you can end up with an
unreachable buffer address.  This should not be applied to drm-next
as that tree already contains evergreen blit support.  This should
only be applied to the 2.6.35 and 2.6.36 stable trees.

Fixes:
https://bugs.freedesktop.org/show_bug.cgi?id=30188

Signed-off-by: Alex Deucher 
Acked-by: Dave Airlie 
Signed-off-by: Greg Kroah-Hartman 

---
 drivers/gpu/drm/radeon/evergreen.c |2 ++
 1 file changed, 2 insertions(+)

--- a/drivers/gpu/drm/radeon/evergreen.c
+++ b/drivers/gpu/drm/radeon/evergreen.c
@@ -1389,6 +1389,8 @@ int evergreen_mc_init(struct radeon_devi
rdev->mc.mc_vram_size = RREG32(CONFIG_MEMSIZE) * 1024 * 1024;
rdev->mc.real_vram_size = RREG32(CONFIG_MEMSIZE) * 1024 * 1024;
rdev->mc.visible_vram_size = rdev->mc.aper_size;
+   /* limit it to the aperture size for now as there is no blit support in 
2.6.35/36*/
+   rdev->mc.real_vram_size = rdev->mc.visible_vram_size;
r600_vram_gtt_location(rdev, >mc);
radeon_update_bandwidth_info(rdev);

[Bug 28294] [r300g] Unigine Sanctuary v2.2: black glitches

2010-10-22 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=28294

--- Comment #39 from Pavel Ondra?ka  2010-10-22 10:25:26 
PDT ---
Created an attachment (id=39633)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=39633)
screenshot with mesa dd2499b484b34e7efb8800f57c915c2f62ab1db4

With latest mesa this is much better, shadows are now working correctly except
for one area which is still missing shadows, screenshot attached.

BTW commit which caused this change is
9d2ab6cb00e72fd8b53d0f97578758504b49ee23
Author: Tom Stellard 
Date:   Sun Oct 10 12:39:00 2010 -0700

r300/compiler: Add a new function for more efficient dataflow analysis

rc_get_readers_normal() supplies a list of readers for a given
instruction.  This function is now being used by the copy propagate
optimization and will eventually be used by most other optimization
passes as well.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[PATCH RESEND] drm: include missing types header to drm_mode.h

2010-10-22 Thread Davidlohr Bueso 
drm: include missing types header to drm_mode.h

Signed-off-by: Davidlohr Bueso 
---
 include/drm/drm_mode.h |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h
index 0fc7397..eddd7f4 100644
--- a/include/drm/drm_mode.h
+++ b/include/drm/drm_mode.h
@@ -24,6 +24,8 @@
  * IN THE SOFTWARE.
  */

+#include 
+
 #ifndef _DRM_MODE_H
 #define _DRM_MODE_H

-- 
1.7.0.4



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Bug 31052] New: drm radeon modesetting enabled hits Linux kernel BUG null pointer

2010-10-22 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=31052

   Summary: drm radeon modesetting enabled hits Linux kernel BUG
null pointer
   Product: DRI
   Version: unspecified
  Platform: x86-64 (AMD64)
OS/Version: Linux (All)
Status: NEW
  Severity: critical
  Priority: medium
 Component: DRM/Radeon
AssignedTo: dri-devel at lists.freedesktop.org
ReportedBy: bitbytebit at gmail.com


I am using Linux 2.6.36 and a Radeon HD2600 PCIe card, has an RV630 GPU and is
an ArcadeVGA card actually which has an altered BIOS to support Arcade
Monitors.  They are sold by a guy in the UK at the ultimarc.com website, that
is where I bought it.  I can load the normal radeon drm kernel module without
modesetting, but with it I hit a bug in the kernel.  I had to comment out the
check for the ATI signature, which then it goes past that fine and detects the
Atom bios information.  Then in the TTM initialization of the memory it hits a
null pointer.  Here is the log below, I'm wondering what I should try to do to
fix this and get this card working correctly with the radeon drm stuff for
modesetting.  

Thanks,
Chris

 01:00.0 VGA compatible controller: ATI Technologies Inc Device 958f (prog-if
00 [VGA controller])
Subsystem: ATI Technologies Inc Device 0502
Flags: bus master, fast devsel, latency 0, IRQ 16
Memory at d000 (64-bit, prefetchable) [size=256M]
Memory at e0a0 (64-bit, non-prefetchable) [size=64K]
I/O ports at 1000 [size=256]
[virtual] Expansion ROM at e000 [disabled] [size=128K]
Capabilities: [50] Power Management version 3
Capabilities: [58] Express Legacy Endpoint, MSI 00
Capabilities: [a0] MSI: Enable- Count=1/1 Maskable- 64bit+
Capabilities: [100] Vendor Specific Information 
Kernel driver in use: radeon

in atom.c I commented this out since it's not an official ATI atom bios
version:

/*if (strncmp
(CSTR(ATOM_ATI_MAGIC_PTR), ATOM_ATI_MAGIC,
 strlen(ATOM_ATI_MAGIC))) {
printk(KERN_INFO "Invalid ATI magic.\n");
kfree(ctx);
return NULL;
}*/



[drm] Initialized drm 1.1.0 20060810
[drm] radeon kernel modesetting enabled.
radeon :01:00.0: PCI INT A -> GSI 16 (level, low) -> IRQ 16
radeon :01:00.0: setting latency timer to 64
[drm] initializing kernel modesetting (RV630 0x1002:0x958F).
[drm] register mmio base: 0xE0A0
[drm] register mmio size: 65536
ATOM BIOS: 102
radeon :01:00.0: VRAM: 512M 0x - 0x1FFF (512M used)
radeon :01:00.0: GTT: 512M 0x2000 - 0x3FFF
[drm] Detected VRAM RAM=512M, BAR=256M
[drm] RAM width 128bits DDR
[TTM] Zone  kernel: Available graphics memory: 512964 kiB.
[TTM] Initializing pool allocator.
BUG: unable to handle kernel NULL pointer dereference at (null)
IP: [] ttm_bo_init_mm+0x81/0x120 [ttm]
PGD 3f9d9067 PUD 3ef0d067 PMD 0
Oops:  [#1] PREEMPT SMP
last sysfs file:
/sys/devices/pci:00/:00:1f.2/host2/target2:0:0/2:0:0:0/block/sda/size
CPU 0
Modules linked in: radeon(+) ttm drm_kms_helper drm agpgart hwmon i2c_algo_bit
ipv6 nfsd snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device snd_pcm_oss
snd_mixer_oss ath9k mac80211 ath9k_common snd_hda_codec_atihdmi ath9k_hw
snd_hda_codec_realtek ath snd_hda_intel snd_hda_codec cfg80211 rfkill snd_pcm
hid_logitech rtc_cmos snd_timer led_class floppy rtc_core rtc_lib snd pcspkr
soundcore snd_page_alloc tg3 libphy e1000 nfs lockd sunrpc jfs raid10 raid456
async_raid6_recov async_memcpy async_pq raid6_pq async_xor xor async_tx raid1
raid0 dm_snapshot dm_crypt dm_mirror dm_region_hash dm_log dm_mod
scsi_wait_scan sl811_hcd usbhid ohci_hcd uhci_hcd usb_storage ehci_hcd usbcore
aic94xx libsas lpfc qla2xxx megaraid_sas megaraid_mbox megaraid_mm megaraid
aacraid sx8 DAC960 cciss 3w_9xxx 3w_ mptsas scsi_transport_sas mptfc
scsi_transport_fc mptspi mptscsih mptbase atp870u dc395x qla1280 dmx3191d
sym53c8xx gdth advansys initio BusLogic arcmsr aic7xxx aic79xx
scsi_transport_spi sg pdc_adma sata_mv ahci libahci sata_qstor sata_vsc
sata_uli sata_sis sata_sx4 sata_nv sata_via sata_svw sata_sil24 sata_sil
sata_promise pata_sis

Pid: 11692, comm: modprobe Not tainted 2.6.36 #1 0A68h/HP xw4400 Workstation
RIP: 0010:[]  [] ttm_bo_init_mm+0x81/0x120
[ttm]
RSP: 0018:88003da67b68  EFLAGS: 00010206
RAX:  RBX: 88003eed8510 RCX: 88003d8691d0
RDX:  RSI: 0002 RDI: 88003eed85c8
RBP: 88003da67ba8 R08:  R09: 88003d8691c0
R10:  R11: dead00200200 R12: 0002
R13: 0002 R14: 88003eed85a0 R15: 88003eed85c8
FS:  7fd7b2a50700() GS:88000160() knlGS:
CS:  0010 DS:  ES:  CR0: 8005003b
CR2:  CR3: 3da64000 CR4: 06f0
DR0:

[Bug 30901] Heroes of Newerth won't start when mesa is compiled with --enable-gallium-llvm

2010-10-22 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=30901

--- Comment #3 from Pavel Ondra?ka  2010-10-22 09:12:09 
PDT ---
Now I found another app which have problems with --enable-gallium-llvm. With
Unigine Sanctuary I get this crash. But it works fine when compiled without
--enable-gallium-llvm.

X Error of failed request:  BadLength (poly request too large or internal Xlib
length error)
  Major opcode of failed request:  117 (X_GetPointerMapping)
  Serial number of failed request:  27
  Current serial number in output stream:  29

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 30901] Heroes of Newerth won't start when mesa is compiled with --enable-gallium-llvm

2010-10-22 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=30901

--- Comment #2 from Pavel Ondra?ka  2010-10-22 08:35:31 
PDT ---
(In reply to comment #1)
> So either the game is picking up a different libGL.so.1 / r300_dri.so, or the
> error message is misleading and the problem is due to something not visible in
> glxinfo. As a starting point, are there any differences in the output of
> 'glxinfo -l'?

The only difference in 'glxinfo -l' output is mesa build time.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 25718] gpu death at radeon_fence_wait

2010-10-22 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=25718

Alex Deucher  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 30901] Heroes of Newerth won't start when mesa is compiled with --enable-gallium-llvm

2010-10-22 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=30901

--- Comment #1 from Michel D?nzer  2010-10-22 06:32:42 
PDT ---
(In reply to comment #1)
> [...] when I add "--enable-gallium-llvm", HoN won't start with "K2 -
> Fatal Error: ARB_vertex_buffer_object not available." 
> This is quite strange because glxinfo is identical and shows
> GL_ARB_vertex_buffer_object in both cases (and OpenGL vendor string: X.Org 
> R300
> Project, OpenGL renderer string: Gallium 0.4 on RV530, so its not like I was
> using some other driver).

So either the game is picking up a different libGL.so.1 / r300_dri.so, or the
error message is misleading and the problem is due to something not visible in
glxinfo. As a starting point, are there any differences in the output of
'glxinfo -l'?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 28771] Waiting for vline forced always on

2010-10-22 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=28771

--- Comment #29 from Artem S. Tashkinov  2010-10-22 
06:17:41 PDT ---
Is there a similar bug filed for Intel driver?

At least in RedHat's bugzilla there's a relevant patch:
https://bugzilla.redhat.com/show_bug.cgi?id=634200

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 31046] [r600g, tiling] visual errors and GPU resets

2010-10-22 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=31046

--- Comment #3 from Tobias Jakobi  2010-10-22 05:57:43 
PDT ---
You mean these ones?
http://article.gmane.org/gmane.comp.video.dri.devel/50968
http://article.gmane.org/gmane.comp.video.dri.devel/50966

Concerning s3tc, how exactly does tiling interact with that?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 31046] [r600g, tiling] visual errors and GPU resets

2010-10-22 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=31046

--- Comment #2 from Dave Airlie  2010-10-22 
04:22:45 PDT ---
I didn't get a chance to test on r700 yet, there may be some more bits I need
to look at, I haven't noticed a large FPS difference on my GPUs either, which
is sad, but I've got a bit of work to do yet, I actually added tiling to help
with s3tc rather than for the FPS boost.

btw you may also need some patches from Alex to fix the group size and any
other CS checkers patch that popped up lately.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 25718] gpu death at radeon_fence_wait

2010-10-22 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=25718

--- Comment #15 from Tobias Jakobi  2010-10-22 03:34:14 
PDT ---
I can now longer reproduce any of these issues. Should be bug be closed?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 31046] [r600g, tiling] visual errors and GPU resets

2010-10-22 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=31046

--- Comment #1 from Tobias Jakobi  2010-10-22 03:31:27 
PDT ---
Needless to say, but I didn't see _any_ performance increase with
R600_FORCE_TILING enabled. Isn't this supposed to bump the fps a lot?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 31046] New: [r600g, tiling] visual errors and GPU resets

2010-10-22 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=31046

   Summary: [r600g, tiling] visual errors and GPU resets
   Product: DRI
   Version: DRI CVS
  Platform: x86-64 (AMD64)
OS/Version: Linux (All)
Status: NEW
  Severity: major
  Priority: medium
 Component: DRM/Radeon
AssignedTo: dri-devel at lists.freedesktop.org
ReportedBy: liquid.acid at gmx.net


Hello!

Yesterday I saw with much delight that the was some new tiling code in r600g,
which could be enabled with a simple envvar. So I pulled drm-radeon-testing and
applied Dave's patch for the CS checker to it (this one:
http://article.gmane.org/gmane.comp.video.dri.devel/51060).

However I encountered several problems with the new code (exporting
R600_FORCE_TILING=1 makes a difference, so it is working to some extent:

1) ioquake3 shows lots of gfx errors. Mipmaps are affected the most (when
setting r_textureMode to GL_LINEAR these problems disappear), but also small
textures seem to be affected (staircases, which use small textures, are either
rendered totally black or black with white stripes).

2) doom3 (demo) shows similar mipmap-related errors.

3) ut2004 is completly unplayable, I get GPU resets nearly every frame and most
of the geometry is missing.

4) ut2003 kinda works, but the HUD is messed up and sprite rendering is totally
broken

Going to post some snips from the kernel log later.

My hardware:
01:00.0 VGA compatible controller: ATI Technologies Inc Radeon HD 4770 [RV740]

libdrm, mesa and xf86-video-ati are all git master tip.
ColorTiling is enabled in the xorg.conf, verified this by checking the Xorg
logfile.

Greets,
Tobias

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[PATCH] drm/radeon/kms: implement display watermark support for evergreen

2010-10-22 Thread Alex Deucher 
Improper display watermarks can result in underflow to the display
controllers which can cause flickering or other artifacts.
This patch implements display watermark support and line buffer
allocation for evergreen asics.

Signed-off-by: Alex Deucher 
---
 drivers/gpu/drm/radeon/evergreen.c  |  437 ++-
 drivers/gpu/drm/radeon/evergreend.h |   13 +
 2 files changed, 449 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/radeon/evergreen.c 
b/drivers/gpu/drm/radeon/evergreen.c
index 34d6ecc..f12a5b3 100644
--- a/drivers/gpu/drm/radeon/evergreen.c
+++ b/drivers/gpu/drm/radeon/evergreen.c
@@ -285,9 +285,444 @@ void evergreen_hpd_fini(struct radeon_device *rdev)
}
 }

+/* watermark setup */
+
+static u32 evergreen_line_buffer_adjust(struct radeon_device *rdev,
+   struct radeon_crtc *radeon_crtc,
+   struct drm_display_mode *mode,
+   struct drm_display_mode *other_mode)
+{
+   u32 tmp = 0;
+   /*
+* Line Buffer Setup
+* There are 3 line buffers, each one shared by 2 display controllers.
+* DC_LB_MEMORY_SPLIT controls how that line buffer is shared between
+* the display controllers.  The paritioning is done via one of four
+* preset allocations specified in bits 2:0:
+* first display controller
+*  0 - first half of lb (3840 * 2)
+*  1 - first 3/4 of lb (5760 * 2)
+*  2 - whole lb (7680 * 2)
+*  3 - first 1/4 of lb (1920 * 2)
+* second display controller
+*  4 - second half of lb (3840 * 2)
+*  5 - second 3/4 of lb (5760 * 2)
+*  6 - whole lb (7680 * 2)
+*  7 - last 1/4 of lb (1920 * 2)
+*/
+   if (mode && other_mode) {
+   if (mode->hdisplay > other_mode->hdisplay) {
+   if (mode->hdisplay > 2560)
+   tmp = 1; /* 3/4 */
+   else
+   tmp = 0; /* 1/2 */
+   } else if (other_mode->hdisplay > mode->hdisplay) {
+   if (other_mode->hdisplay > 2560)
+   tmp = 3; /* 1/4 */
+   else
+   tmp = 0; /* 1/2 */
+   } else
+   tmp = 0; /* 1/2 */
+   } else if (mode)
+   tmp = 2; /* whole */
+   else if (other_mode)
+   tmp = 3; /* 1/4 */
+
+   /* second controller of the pair uses second half of the lb */
+   if (radeon_crtc->crtc_id % 2)
+   tmp += 4;
+   WREG32(DC_LB_MEMORY_SPLIT + radeon_crtc->crtc_offset, tmp);
+
+   switch (tmp) {
+   case 0:
+   case 4:
+   default:
+   return 3840 * 2;
+   case 1:
+   case 5:
+   return 5760 * 2;
+   case 2:
+   case 6:
+   return 7680 * 2;
+   case 3:
+   case 7:
+   return 1920 * 2;
+   }
+}
+
+static u32 evergreen_get_number_of_dram_channels(struct radeon_device *rdev)
+{
+   u32 tmp = RREG32(MC_SHARED_CHMAP);
+
+   switch ((tmp & NOOFCHAN_MASK) >> NOOFCHAN_SHIFT) {
+   case 0:
+   default:
+   return 1;
+   case 1:
+   return 2;
+   case 2:
+   return 4;
+   case 3:
+   return 8;
+   }
+}
+
+struct evergreen_wm_params {
+   u32 dram_channels; /* number of dram channels */
+   u32 yclk;  /* bandwidth per dram data pin in kHz */
+   u32 sclk;  /* engine clock in kHz */
+   u32 disp_clk;  /* display clock in kHz */
+   u32 src_width; /* viewport width */
+   u32 active_time;   /* active display time in ns */
+   u32 blank_time;/* blank time in ns */
+   bool interlaced;/* mode is interlaced */
+   fixed20_12 vsc;/* vertical scale ratio */
+   u32 num_heads; /* number of active crtcs */
+   u32 bytes_per_pixel; /* bytes per pixel display + overlay */
+   u32 lb_size;   /* line buffer allocated to pipe */
+   u32 vtaps; /* vertical scaler taps */
+};
+
+static u32 evergreen_dram_bandwidth(struct evergreen_wm_params *wm)
+{
+   /* Calculate DRAM Bandwidth and the part allocated to display. */
+   fixed20_12 dram_efficiency; /* 0.7 */
+   fixed20_12 yclk, dram_channels, bandwidth;
+   fixed20_12 a;
+
+   a.full = dfixed_const(1000);
+   yclk.full = dfixed_const(wm->yclk);
+   yclk.full = dfixed_div(yclk, a);
+   dram_channels.full = dfixed_const(wm->dram_channels * 4);
+   a.full = dfixed_const(10);
+   dram_efficiency.full = dfixed_const(7);
+   dram_efficiency.full = dfixed_div(dram_efficiency, a);
+   bandwidth.full = dfixed_mul(dram_channels, yclk);
+   bandwidth.full = dfixed_mul(bandwidth, dram_efficiency);
+
+   return dfixed_trunc(bandwidth);
+}
+
+static u32

[PATCH] drm/radeon/kms: implement display watermark support for evergreen

2010-10-22 Thread Alex Deucher 
Improper display watermarks can result in underflow to the display
controllers which can cause flickering or other artifacts.
This patch implements display watermark support and line buffer
allocation for evergreen asics.

Signed-off-by: Alex Deucher alexdeuc...@gmail.com
---
 drivers/gpu/drm/radeon/evergreen.c  |  437 ++-
 drivers/gpu/drm/radeon/evergreend.h |   13 +
 2 files changed, 449 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/radeon/evergreen.c 
b/drivers/gpu/drm/radeon/evergreen.c
index 34d6ecc..f12a5b3 100644
--- a/drivers/gpu/drm/radeon/evergreen.c
+++ b/drivers/gpu/drm/radeon/evergreen.c
@@ -285,9 +285,444 @@ void evergreen_hpd_fini(struct radeon_device *rdev)
}
 }
 
+/* watermark setup */
+
+static u32 evergreen_line_buffer_adjust(struct radeon_device *rdev,
+   struct radeon_crtc *radeon_crtc,
+   struct drm_display_mode *mode,
+   struct drm_display_mode *other_mode)
+{
+   u32 tmp = 0;
+   /*
+* Line Buffer Setup
+* There are 3 line buffers, each one shared by 2 display controllers.
+* DC_LB_MEMORY_SPLIT controls how that line buffer is shared between
+* the display controllers.  The paritioning is done via one of four
+* preset allocations specified in bits 2:0:
+* first display controller
+*  0 - first half of lb (3840 * 2)
+*  1 - first 3/4 of lb (5760 * 2)
+*  2 - whole lb (7680 * 2)
+*  3 - first 1/4 of lb (1920 * 2)
+* second display controller
+*  4 - second half of lb (3840 * 2)
+*  5 - second 3/4 of lb (5760 * 2)
+*  6 - whole lb (7680 * 2)
+*  7 - last 1/4 of lb (1920 * 2)
+*/
+   if (mode  other_mode) {
+   if (mode-hdisplay  other_mode-hdisplay) {
+   if (mode-hdisplay  2560)
+   tmp = 1; /* 3/4 */
+   else
+   tmp = 0; /* 1/2 */
+   } else if (other_mode-hdisplay  mode-hdisplay) {
+   if (other_mode-hdisplay  2560)
+   tmp = 3; /* 1/4 */
+   else
+   tmp = 0; /* 1/2 */
+   } else
+   tmp = 0; /* 1/2 */
+   } else if (mode)
+   tmp = 2; /* whole */
+   else if (other_mode)
+   tmp = 3; /* 1/4 */
+
+   /* second controller of the pair uses second half of the lb */
+   if (radeon_crtc-crtc_id % 2)
+   tmp += 4;
+   WREG32(DC_LB_MEMORY_SPLIT + radeon_crtc-crtc_offset, tmp);
+
+   switch (tmp) {
+   case 0:
+   case 4:
+   default:
+   return 3840 * 2;
+   case 1:
+   case 5:
+   return 5760 * 2;
+   case 2:
+   case 6:
+   return 7680 * 2;
+   case 3:
+   case 7:
+   return 1920 * 2;
+   }
+}
+
+static u32 evergreen_get_number_of_dram_channels(struct radeon_device *rdev)
+{
+   u32 tmp = RREG32(MC_SHARED_CHMAP);
+
+   switch ((tmp  NOOFCHAN_MASK)  NOOFCHAN_SHIFT) {
+   case 0:
+   default:
+   return 1;
+   case 1:
+   return 2;
+   case 2:
+   return 4;
+   case 3:
+   return 8;
+   }
+}
+
+struct evergreen_wm_params {
+   u32 dram_channels; /* number of dram channels */
+   u32 yclk;  /* bandwidth per dram data pin in kHz */
+   u32 sclk;  /* engine clock in kHz */
+   u32 disp_clk;  /* display clock in kHz */
+   u32 src_width; /* viewport width */
+   u32 active_time;   /* active display time in ns */
+   u32 blank_time;/* blank time in ns */
+   bool interlaced;/* mode is interlaced */
+   fixed20_12 vsc;/* vertical scale ratio */
+   u32 num_heads; /* number of active crtcs */
+   u32 bytes_per_pixel; /* bytes per pixel display + overlay */
+   u32 lb_size;   /* line buffer allocated to pipe */
+   u32 vtaps; /* vertical scaler taps */
+};
+
+static u32 evergreen_dram_bandwidth(struct evergreen_wm_params *wm)
+{
+   /* Calculate DRAM Bandwidth and the part allocated to display. */
+   fixed20_12 dram_efficiency; /* 0.7 */
+   fixed20_12 yclk, dram_channels, bandwidth;
+   fixed20_12 a;
+
+   a.full = dfixed_const(1000);
+   yclk.full = dfixed_const(wm-yclk);
+   yclk.full = dfixed_div(yclk, a);
+   dram_channels.full = dfixed_const(wm-dram_channels * 4);
+   a.full = dfixed_const(10);
+   dram_efficiency.full = dfixed_const(7);
+   dram_efficiency.full = dfixed_div(dram_efficiency, a);
+   bandwidth.full = dfixed_mul(dram_channels, yclk);
+   bandwidth.full = dfixed_mul(bandwidth, dram_efficiency);
+
+   return dfixed_trunc(bandwidth);
+}
+
+static u32

[PATCH 0/9] Typo fixes of faild to failed

2010-10-22 Thread Joe Perches 
Joe Perches (9):
  drivers/ata: typo fix of faild to failed
  drivers/gpu: typo fix of faild to failed
  drivers/net: typo fix of faild to failed
  drivers/rtc: typo fix of faild to failed
  drivers/video: typo fix of faild to failed
  fs/exofs: typo fix of faild to failed
  fs/jfs: typo fix of faild to failed
  kernel/trace: typo fix of faild to failed
  net/wanrouter: typo fix of faild to failed

 drivers/ata/pata_bf54x.c   |2 +-
 drivers/gpu/drm/radeon/radeon_cs.c |2 +-
 drivers/net/ps3_gelic_net.c|4 ++--
 drivers/net/tulip/pnic2.c  |2 +-
 drivers/rtc/rtc-nuc900.c   |2 +-
 drivers/video/bf54x-lq043fb.c  |6 +++---
 drivers/video/bfin-t350mcqb-fb.c   |2 +-
 fs/exofs/dir.c |4 ++--
 fs/exofs/inode.c   |   14 +++---
 fs/exofs/ios.c |   10 +-
 fs/jfs/jfs_mount.c |4 ++--
 kernel/trace/trace_kprobe.c|2 +-
 net/wanrouter/wanmain.c|4 ++--
 13 files changed, 29 insertions(+), 29 deletions(-)

-- 
1.7.3.1.g432b3.dirty

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 1/2] drm/kms: Lock mode_config.mutex consistently from the sysfs handling code.

2010-10-22 Thread Francisco Jerez 
Among other potential issues, this fixes a race between output polling
and status_show() that could cause a load detection false positive
with the nouveau driver.

Signed-off-by: Francisco Jerez curroje...@riseup.net
---
 drivers/gpu/drm/drm_sysfs.c |   71 ---
 1 files changed, 46 insertions(+), 25 deletions(-)

diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c
index 85da4c4..25a9d9e 100644
--- a/drivers/gpu/drm/drm_sysfs.c
+++ b/drivers/gpu/drm/drm_sysfs.c
@@ -157,9 +157,13 @@ static ssize_t status_show(struct device *device,
   char *buf)
 {
struct drm_connector *connector = to_drm_connector(device);
+   struct drm_device *dev = connector-dev;
enum drm_connector_status status;
 
+   mutex_lock(dev-mode_config.mutex);
status = connector-funcs-detect(connector, true);
+   mutex_unlock(dev-mode_config.mutex);
+
return snprintf(buf, PAGE_SIZE, %s\n,
drm_get_connector_status_name(status));
 }
@@ -173,9 +177,11 @@ static ssize_t dpms_show(struct device *device,
uint64_t dpms_status;
int ret;
 
+   mutex_lock(dev-mode_config.mutex);
ret = drm_connector_property_get_value(connector,
dev-mode_config.dpms_property,
dpms_status);
+   mutex_unlock(dev-mode_config.mutex);
if (ret)
return 0;
 
@@ -199,25 +205,27 @@ static ssize_t edid_show(struct file *filp, struct 
kobject *kobj,
 {
struct device *connector_dev = container_of(kobj, struct device, kobj);
struct drm_connector *connector = to_drm_connector(connector_dev);
+   struct drm_device *dev = connector-dev;
unsigned char *edid;
-   size_t size;
+   size_t size, n = 0;
 
+   mutex_lock(dev-mode_config.mutex);
if (!connector-edid_blob_ptr)
-   return 0;
+   goto out;
 
edid = connector-edid_blob_ptr-data;
size = connector-edid_blob_ptr-length;
if (!edid)
-   return 0;
+   goto out;
 
if (off = size)
-   return 0;
-
-   if (off + count  size)
-   count = size - off;
-   memcpy(buf, edid + off, count);
+   goto out;
 
-   return count;
+   n = min(count, size - (size_t)off);
+   memcpy(buf, edid + off, n);
+out:
+   mutex_unlock(dev-mode_config.mutex);
+   return n;
 }
 
 static ssize_t modes_show(struct device *device,
@@ -225,13 +233,16 @@ static ssize_t modes_show(struct device *device,
   char *buf)
 {
struct drm_connector *connector = to_drm_connector(device);
+   struct drm_device *dev = connector-dev;
struct drm_display_mode *mode;
int written = 0;
 
+   mutex_lock(dev-mode_config.mutex);
list_for_each_entry(mode, connector-modes, head) {
written += snprintf(buf + written, PAGE_SIZE - written, %s\n,
mode-name);
}
+   mutex_unlock(dev-mode_config.mutex);
 
return written;
 }
@@ -245,7 +256,9 @@ static ssize_t subconnector_show(struct device *device,
struct drm_property *prop = NULL;
uint64_t subconnector;
int is_tv = 0;
-   int ret;
+   int ret = 0;
+
+   mutex_lock(dev-mode_config.mutex);
 
switch (connector-connector_type) {
case DRM_MODE_CONNECTOR_DVII:
@@ -260,21 +273,24 @@ static ssize_t subconnector_show(struct device *device,
break;
default:
DRM_ERROR(Wrong connector type for this property\n);
-   return 0;
+   goto out;
}
 
if (!prop) {
DRM_ERROR(Unable to find subconnector property\n);
-   return 0;
+   goto out;
}
 
ret = drm_connector_property_get_value(connector, prop, subconnector);
if (ret)
-   return 0;
+   goto out;
 
-   return snprintf(buf, PAGE_SIZE, %s, is_tv ?
-   drm_get_tv_subconnector_name((int)subconnector) :
-   drm_get_dvi_i_subconnector_name((int)subconnector));
+   ret = snprintf(buf, PAGE_SIZE, %s, is_tv ?
+  drm_get_tv_subconnector_name((int)subconnector) :
+  drm_get_dvi_i_subconnector_name((int)subconnector));
+out:
+   mutex_unlock(dev-mode_config.mutex);
+   return ret;
 }
 
 static ssize_t select_subconnector_show(struct device *device,
@@ -286,7 +302,9 @@ static ssize_t select_subconnector_show(struct device 
*device,
struct drm_property *prop = NULL;
uint64_t subconnector;
int is_tv = 0;
-   int ret;
+   int ret = 0;
+
+   mutex_lock(dev-mode_config.mutex);
 
switch (connector-connector_type) {

[PATCH 2/2] drm/kms: Fix missing locking in some fb helpers.

2010-10-22 Thread Francisco Jerez 
Signed-off-by: Francisco Jerez curroje...@riseup.net
---
 drivers/gpu/drm/drm_fb_helper.c |   14 --
 1 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 6a5e403..4d608b7 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -1449,6 +1449,8 @@ bool drm_fb_helper_initial_config(struct drm_fb_helper 
*fb_helper, int bpp_sel)
struct drm_device *dev = fb_helper-dev;
int count = 0;
 
+   mutex_lock(dev-mode_config.mutex);
+
/* disable all the possible outputs/crtcs before entering KMS mode */
drm_helper_disable_unused_functions(fb_helper-dev);
 
@@ -1465,19 +1467,23 @@ bool drm_fb_helper_initial_config(struct drm_fb_helper 
*fb_helper, int bpp_sel)
}
drm_setup_crtcs(fb_helper);
 
+   mutex_unlock(dev-mode_config.mutex);
+
return drm_fb_helper_single_fb_probe(fb_helper, bpp_sel);
 }
 EXPORT_SYMBOL(drm_fb_helper_initial_config);
 
 bool drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper)
 {
+   struct drm_device *dev = fb_helper-dev;
int count = 0;
u32 max_width, max_height, bpp_sel;
bool bound = false, crtcs_bound = false;
struct drm_crtc *crtc;
 
+   mutex_lock(dev-mode_config.mutex);
if (!fb_helper-fb)
-   return false;
+   goto fail;
 
list_for_each_entry(crtc, fb_helper-dev-mode_config.crtc_list, head) 
{
if (crtc-fb)
@@ -1488,7 +1494,7 @@ bool drm_fb_helper_hotplug_event(struct drm_fb_helper 
*fb_helper)
 
if (!bound  crtcs_bound) {
fb_helper-delayed_hotplug = true;
-   return false;
+   goto fail;
}
DRM_DEBUG_KMS(\n);
 
@@ -1500,7 +1506,11 @@ bool drm_fb_helper_hotplug_event(struct drm_fb_helper 
*fb_helper)
max_height);
drm_setup_crtcs(fb_helper);
 
+   mutex_unlock(dev-mode_config.mutex);
return drm_fb_helper_single_fb_probe(fb_helper, bpp_sel);
+fail:
+   mutex_unlock(dev-mode_config.mutex);
+   return false;
 }
 EXPORT_SYMBOL(drm_fb_helper_hotplug_event);
 
-- 
1.6.4.4

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 31046] [r600g, tiling] visual errors and GPU resets

2010-10-22 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=31046

--- Comment #3 from Tobias Jakobi liquid.a...@gmx.net 2010-10-22 05:57:43 PDT 
---
You mean these ones?
http://article.gmane.org/gmane.comp.video.dri.devel/50968
http://article.gmane.org/gmane.comp.video.dri.devel/50966

Concerning s3tc, how exactly does tiling interact with that?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH RESEND] drm: include missing types header to drm_mode.h

2010-10-22 Thread Davidlohr Bueso 
drm: include missing types header to drm_mode.h

Signed-off-by: Davidlohr Bueso d...@gnu.org
---
 include/drm/drm_mode.h |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h
index 0fc7397..eddd7f4 100644
--- a/include/drm/drm_mode.h
+++ b/include/drm/drm_mode.h
@@ -24,6 +24,8 @@
  * IN THE SOFTWARE.
  */
 
+#include linux/types.h
+
 #ifndef _DRM_MODE_H
 #define _DRM_MODE_H
 
-- 
1.7.0.4



--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 30901] Heroes of Newerth won't start when mesa is compiled with --enable-gallium-llvm

2010-10-22 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=30901

--- Comment #1 from Michel Dänzer mic...@daenzer.net 2010-10-22 06:32:42 PDT 
---
(In reply to comment #1)
 [...] when I add --enable-gallium-llvm, HoN won't start with K2 -
 Fatal Error: ARB_vertex_buffer_object not available. 
 This is quite strange because glxinfo is identical and shows
 GL_ARB_vertex_buffer_object in both cases (and OpenGL vendor string: X.Org 
 R300
 Project, OpenGL renderer string: Gallium 0.4 on RV530, so its not like I was
 using some other driver).

So either the game is picking up a different libGL.so.1 / r300_dri.so, or the
error message is misleading and the problem is due to something not visible in
glxinfo. As a starting point, are there any differences in the output of
'glxinfo -l'?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 25718] gpu death at radeon_fence_wait

2010-10-22 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=25718

Alex Deucher ag...@yahoo.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 30901] Heroes of Newerth won't start when mesa is compiled with --enable-gallium-llvm

2010-10-22 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=30901

--- Comment #2 from Pavel Ondračka dra...@centrum.cz 2010-10-22 08:35:31 PDT 
---
(In reply to comment #1)
 So either the game is picking up a different libGL.so.1 / r300_dri.so, or the
 error message is misleading and the problem is due to something not visible in
 glxinfo. As a starting point, are there any differences in the output of
 'glxinfo -l'?

The only difference in 'glxinfo -l' output is mesa build time.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 31052] New: drm radeon modesetting enabled hits Linux kernel BUG null pointer

2010-10-22 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=31052

   Summary: drm radeon modesetting enabled hits Linux kernel BUG
null pointer
   Product: DRI
   Version: unspecified
  Platform: x86-64 (AMD64)
OS/Version: Linux (All)
Status: NEW
  Severity: critical
  Priority: medium
 Component: DRM/Radeon
AssignedTo: dri-devel@lists.freedesktop.org
ReportedBy: bitbyte...@gmail.com


I am using Linux 2.6.36 and a Radeon HD2600 PCIe card, has an RV630 GPU and is
an ArcadeVGA card actually which has an altered BIOS to support Arcade
Monitors.  They are sold by a guy in the UK at the ultimarc.com website, that
is where I bought it.  I can load the normal radeon drm kernel module without
modesetting, but with it I hit a bug in the kernel.  I had to comment out the
check for the ATI signature, which then it goes past that fine and detects the
Atom bios information.  Then in the TTM initialization of the memory it hits a
null pointer.  Here is the log below, I'm wondering what I should try to do to
fix this and get this card working correctly with the radeon drm stuff for
modesetting.  

Thanks,
Chris

 01:00.0 VGA compatible controller: ATI Technologies Inc Device 958f (prog-if
00 [VGA controller])
Subsystem: ATI Technologies Inc Device 0502
Flags: bus master, fast devsel, latency 0, IRQ 16
Memory at d000 (64-bit, prefetchable) [size=256M]
Memory at e0a0 (64-bit, non-prefetchable) [size=64K]
I/O ports at 1000 [size=256]
[virtual] Expansion ROM at e000 [disabled] [size=128K]
Capabilities: [50] Power Management version 3
Capabilities: [58] Express Legacy Endpoint, MSI 00
Capabilities: [a0] MSI: Enable- Count=1/1 Maskable- 64bit+
Capabilities: [100] Vendor Specific Information ?
Kernel driver in use: radeon

in atom.c I commented this out since it's not an official ATI atom bios
version:

/*if (strncmp
(CSTR(ATOM_ATI_MAGIC_PTR), ATOM_ATI_MAGIC,
 strlen(ATOM_ATI_MAGIC))) {
printk(KERN_INFO Invalid ATI magic.\n);
kfree(ctx);
return NULL;
}*/



[drm] Initialized drm 1.1.0 20060810
[drm] radeon kernel modesetting enabled.
radeon :01:00.0: PCI INT A - GSI 16 (level, low) - IRQ 16
radeon :01:00.0: setting latency timer to 64
[drm] initializing kernel modesetting (RV630 0x1002:0x958F).
[drm] register mmio base: 0xE0A0
[drm] register mmio size: 65536
ATOM BIOS: 102
radeon :01:00.0: VRAM: 512M 0x - 0x1FFF (512M used)
radeon :01:00.0: GTT: 512M 0x2000 - 0x3FFF
[drm] Detected VRAM RAM=512M, BAR=256M
[drm] RAM width 128bits DDR
[TTM] Zone  kernel: Available graphics memory: 512964 kiB.
[TTM] Initializing pool allocator.
BUG: unable to handle kernel NULL pointer dereference at (null)
IP: [a0a5d101] ttm_bo_init_mm+0x81/0x120 [ttm]
PGD 3f9d9067 PUD 3ef0d067 PMD 0
Oops:  [#1] PREEMPT SMP
last sysfs file:
/sys/devices/pci:00/:00:1f.2/host2/target2:0:0/2:0:0:0/block/sda/size
CPU 0
Modules linked in: radeon(+) ttm drm_kms_helper drm agpgart hwmon i2c_algo_bit
ipv6 nfsd snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device snd_pcm_oss
snd_mixer_oss ath9k mac80211 ath9k_common snd_hda_codec_atihdmi ath9k_hw
snd_hda_codec_realtek ath snd_hda_intel snd_hda_codec cfg80211 rfkill snd_pcm
hid_logitech rtc_cmos snd_timer led_class floppy rtc_core rtc_lib snd pcspkr
soundcore snd_page_alloc tg3 libphy e1000 nfs lockd sunrpc jfs raid10 raid456
async_raid6_recov async_memcpy async_pq raid6_pq async_xor xor async_tx raid1
raid0 dm_snapshot dm_crypt dm_mirror dm_region_hash dm_log dm_mod
scsi_wait_scan sl811_hcd usbhid ohci_hcd uhci_hcd usb_storage ehci_hcd usbcore
aic94xx libsas lpfc qla2xxx megaraid_sas megaraid_mbox megaraid_mm megaraid
aacraid sx8 DAC960 cciss 3w_9xxx 3w_ mptsas scsi_transport_sas mptfc
scsi_transport_fc mptspi mptscsih mptbase atp870u dc395x qla1280 dmx3191d
sym53c8xx gdth advansys initio BusLogic arcmsr aic7xxx aic79xx
scsi_transport_spi sg pdc_adma sata_mv ahci libahci sata_qstor sata_vsc
sata_uli sata_sis sata_sx4 sata_nv sata_via sata_svw sata_sil24 sata_sil
sata_promise pata_sis

Pid: 11692, comm: modprobe Not tainted 2.6.36 #1 0A68h/HP xw4400 Workstation
RIP: 0010:[a0a5d101]  [a0a5d101] ttm_bo_init_mm+0x81/0x120
[ttm]
RSP: 0018:88003da67b68  EFLAGS: 00010206
RAX:  RBX: 88003eed8510 RCX: 88003d8691d0
RDX:  RSI: 0002 RDI: 88003eed85c8
RBP: 88003da67ba8 R08:  R09: 88003d8691c0
R10:  R11: dead00200200 R12: 0002
R13: 0002 R14: 88003eed85a0 R15: 88003eed85c8
FS:  7fd7b2a50700() GS:88000160() knlGS:
CS:  0010 DS:  ES:  CR0: 8005003b
CR2:  CR3: 3da64000

[Bug 28294] [r300g] Unigine Sanctuary v2.2: black glitches

2010-10-22 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=28294

--- Comment #39 from Pavel Ondračka dra...@centrum.cz 2010-10-22 10:25:26 PDT 
---
Created an attachment (id=39633)
 -- (https://bugs.freedesktop.org/attachment.cgi?id=39633)
screenshot with mesa dd2499b484b34e7efb8800f57c915c2f62ab1db4

With latest mesa this is much better, shadows are now working correctly except
for one area which is still missing shadows, screenshot attached.

BTW commit which caused this change is
9d2ab6cb00e72fd8b53d0f97578758504b49ee23
Author: Tom Stellard tstel...@gmail.com
Date:   Sun Oct 10 12:39:00 2010 -0700

r300/compiler: Add a new function for more efficient dataflow analysis

rc_get_readers_normal() supplies a list of readers for a given
instruction.  This function is now being used by the copy propagate
optimization and will eventually be used by most other optimization
passes as well.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 0/9] Typo fixes of faild to failed

2010-10-22 Thread Mike Frysinger 
On Fri, Oct 22, 2010 at 01:17, Joe Perches wrote:
  drivers/ata/pata_bf54x.c           |    2 +-
  drivers/video/bf54x-lq043fb.c      |    6 +++---
  drivers/video/bfin-t350mcqb-fb.c   |    2 +-

Acked-by: Mike Frysinger vap...@gentoo.org
-mike
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 31052] drm radeon modesetting enabled hits Linux kernel BUG null pointer

2010-10-22 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=31052

--- Comment #1 from Chris bitbyte...@gmail.com 2010-10-22 15:50:05 PDT ---
Created an attachment (id=39640)
 -- (https://bugs.freedesktop.org/attachment.cgi?id=39640)
The bios of the AVGA3000 (radeon 2600 RV630) card

This may help, this is the bios of this card which is modified to hold
modelines that are custom made for an arcade monitor.  I think there's more
modified though than just that, since the radeon drm driver in KMS hits a null
pointer and crashes.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH RESEND] drm: include missing types header to drm_mode.h

2010-10-22 Thread Andrew Morton 
On Fri, 22 Oct 2010 10:13:19 -0300
Davidlohr Bueso d...@gnu.org wrote:

 drm: include missing types header to drm_mode.h
 
 Signed-off-by: Davidlohr Bueso d...@gnu.org
 ---
  include/drm/drm_mode.h |2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)
 
 diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h
 index 0fc7397..eddd7f4 100644
 --- a/include/drm/drm_mode.h
 +++ b/include/drm/drm_mode.h
 @@ -24,6 +24,8 @@
   * IN THE SOFTWARE.
   */
  
 +#include linux/types.h
 +
  #ifndef _DRM_MODE_H
  #define _DRM_MODE_H
  

Does this fix a build error?  If so, please send along the compiler
error output.

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH RESEND] drm: include missing types header to drm_mode.h

2010-10-22 Thread Randy Dunlap 
On Fri, 22 Oct 2010 16:55:17 -0700 Andrew Morton wrote:

 On Fri, 22 Oct 2010 10:13:19 -0300
 Davidlohr Bueso d...@gnu.org wrote:
 
  drm: include missing types header to drm_mode.h
  
  Signed-off-by: Davidlohr Bueso d...@gnu.org
  ---
   include/drm/drm_mode.h |2 ++
   1 files changed, 2 insertions(+), 0 deletions(-)
  
  diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h
  index 0fc7397..eddd7f4 100644
  --- a/include/drm/drm_mode.h
  +++ b/include/drm/drm_mode.h
  @@ -24,6 +24,8 @@
* IN THE SOFTWARE.
*/
   
  +#include linux/types.h
  +
   #ifndef _DRM_MODE_H
   #define _DRM_MODE_H
   
 
 Does this fix a build error?  If so, please send along the compiler
 error output.


Every build that has CONFIG_HEADERS_CHECK=y reports the following:

linux-next-20101022/X64/usr/include/drm/drm_mode.h:85: found __[us]{8,16,32,64} 
type without #include linux/types.h
linux-next-20101022/X64/usr/include/drm/i915_drm.h:120: found 
__[us]{8,16,32,64} type without #include linux/types.h
linux-next-20101022/X64/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64} 
type without #include linux/types.h
linux-next-20101022/X64/usr/include/drm/radeon_drm.h:758: found 
__[us]{8,16,32,64} type without #include linux/types.h
linux-next-20101022/X64/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64} 
type without #include linux/types.h
linux-next-20101022/X64/usr/include/scsi/scsi_netlink.h:108: found 
__[us]{8,16,32,64} type without #include linux/types.h
linux-next-20101022/X64/usr/include/linux/resource.h:49: found 
__[us]{8,16,32,64} type without #include linux/types.h


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH RESEND] drm: include missing types header to drm_mode.h

2010-10-22 Thread Dave Airlie 
On Sat, Oct 23, 2010 at 10:02 AM, Randy Dunlap rdun...@xenotime.net wrote:
 On Fri, 22 Oct 2010 16:55:17 -0700 Andrew Morton wrote:

 On Fri, 22 Oct 2010 10:13:19 -0300
 Davidlohr Bueso d...@gnu.org wrote:

  drm: include missing types header to drm_mode.h
 
  Signed-off-by: Davidlohr Bueso d...@gnu.org
  ---
   include/drm/drm_mode.h |    2 ++
   1 files changed, 2 insertions(+), 0 deletions(-)
 
  diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h
  index 0fc7397..eddd7f4 100644
  --- a/include/drm/drm_mode.h
  +++ b/include/drm/drm_mode.h
  @@ -24,6 +24,8 @@
    * IN THE SOFTWARE.
    */
 
  +#include linux/types.h
  +
   #ifndef _DRM_MODE_H
   #define _DRM_MODE_H
 

 Does this fix a build error?  If so, please send along the compiler
 error output.


 Every build that has CONFIG_HEADERS_CHECK=y reports the following:

 linux-next-20101022/X64/usr/include/drm/drm_mode.h:85: found 
 __[us]{8,16,32,64} type without #include linux/types.h
 linux-next-20101022/X64/usr/include/drm/i915_drm.h:120: found 
 __[us]{8,16,32,64} type without #include linux/types.h
 linux-next-20101022/X64/usr/include/drm/mga_drm.h:260: found 
 __[us]{8,16,32,64} type without #include linux/types.h
 linux-next-20101022/X64/usr/include/drm/radeon_drm.h:758: found 
 __[us]{8,16,32,64} type without #include linux/types.h
 linux-next-20101022/X64/usr/include/drm/via_drm.h:117: found 
 __[us]{8,16,32,64} type without #include linux/types.h
 linux-next-20101022/X64/usr/include/scsi/scsi_netlink.h:108: found 
 __[us]{8,16,32,64} type without #include linux/types.h
 linux-next-20101022/X64/usr/include/linux/resource.h:49: found 
 __[us]{8,16,32,64} type without #include linux/types.h



Why doesn't the tool understand header recursion? drm_mode.h needs to
include drm.h but the rest already include drm.h.

Including drm.h includes linux/types.h if defined(__linux__)

So really I've said this a few times now, its the stupid tool that is
broken for most of these, fix the tool and I'll fix drm_mode.h

Dave.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 30651] r600g: gl output in mplayer have no colors if used with a fragment program with additional lookup and bicubic B-spline filtering

2010-10-22 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=30651

--- Comment #3 from Sergey Kondakov virtuous...@gmail.com 2010-10-22 18:49:34 
PDT ---
tested commit 469907d59738ad32c7a3b95072897432f1e81a0f with kernel 2.6.36 and
ColorTiling=on.
same thing :(

tested without 'lscale=1,cscale=1' and it makes no difference. setting 'yuv=4'
triggers bug alright.
but specifying 'yuv=1' and '5' (register combiners/GL_NV_register_combiners and
GL_ATI_fragment_shader) also gives colorless picture and it's much darker.

i will use method '6' for now with hope that it's not really Extremely slow
(software emulation) on some (all?) ATI cards since it uses a texture with
border pixels as mplayer's manual says.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel